mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-01-27 03:19:56 +00:00

Files

Alexander Brown dbb0bd961f Chore: TypeScript cleanup - remove 254 @ts-expect-error suppressions (#7884 )

## Summary

Removes **254** `@ts-expect-error` suppressions through proper type
fixes rather than type assertions.

## Key Changes

### Type System Improvements
- Add `globalDefs` and `groupNodes` types to `ComfyAppWindowExtension`
- Extract interfaces for group node handling (`GroupNodeHandler`,
`InnerNodeOutput`, etc.)
- Add `getHandler()` helper to consolidate GROUP symbol access pattern

### Files Fixed
- **pnginfo.ts**: 39 suppressions removed via proper typing of
workflow/prompt data
- **app.ts**: 39 suppressions removed via interface extraction and type
narrowing
- **Tier 1 files**: 17 suppressions removed (maskeditor, imageDrawer,
groupNode, etc.)
- **groupNode.ts**: Major refactoring with proper interface organization

## Approach

Following established constraints:
- No `any` types
- No `as unknown as T` casts (except legacy API boundaries)
- Priority: Fix actual types > Type narrowing > Targeted suppressions as
last resort
- Prefix unused callback parameters with underscore
- Extract repeated inline types into named interfaces

## Validation

- ✅ `pnpm typecheck` passes
- ✅ `pnpm lint` passes
- ✅ `pnpm knip` passes

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7884-Chore-TypeScript-cleanup-remove-254-ts-expect-error-suppressions-2e26d73d3650812e9b48da203ce1d296)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>

2026-01-10 21:17:31 -08:00

load3d

fix: use pre-bundled wwobjloader2 worker for production builds (#7879 )

2026-01-07 20:46:22 -05:00

maskeditor

GPU accelerated maskeditor rendering (#6767 )

2025-11-22 09:07:16 -05:00

clipspace.ts

[TS] Require override keyword (#3746 )

2025-05-03 19:54:45 -04:00

cloudBadges.ts

change cloud feature flags to be loaded dynamically at runtime rather than set in build (#6246 )

2025-10-23 20:16:18 -07:00

cloudFeedbackTopbarButton.ts

Cloud feedback Extension (#6626 )

2025-11-08 12:36:04 +01:00

cloudRemoteConfig.ts

refresh feature flags on auth or subscription state change (#7197 )

2025-12-05 19:40:11 -07:00

cloudSessionCookie.ts

add session cookie auth on cloud dist (#6295 )

2025-10-26 00:04:30 -07:00

cloudSubscription.ts

change cloud feature flags to be loaded dynamically at runtime rather than set in build (#6246 )

2025-10-23 20:16:18 -07:00

contextMenuFilter.name.test.ts

chore: migrate tests from tests-ui/ to colocate with source files (#7811 )

2026-01-05 16:32:24 -08:00

contextMenuFilter.test.ts

chore: migrate tests from tests-ui/ to colocate with source files (#7811 )

2026-01-05 16:32:24 -08:00

contextMenuFilter.ts

[refactor] Migrate litegraph imports from npm package to local subtree

2025-08-03 22:06:29 -04:00

customCombo.ts

Implement a CustomCombo node (#7142 )

2025-12-12 02:23:44 -07:00

dynamicPrompts.test.ts

chore: migrate tests from tests-ui/ to colocate with source files (#7811 )

2026-01-05 16:32:24 -08:00

dynamicPrompts.ts

Inplace widget to input conversion (#2588 )

2025-02-16 13:41:32 -05:00

editAttention.ts

[TS] Enable noUnusedParameters (#3110 )

2025-03-17 16:47:45 -04:00

electronAdapter.ts

Centralized management of external links (#4471 )

2025-11-13 21:35:28 -08:00

groupNode.ts

Chore: TypeScript cleanup - remove 254 @ts-expect-error suppressions (#7884 )

2026-01-10 21:17:31 -08:00

groupNodeManage.css

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

groupNodeManage.ts

Chore: TypeScript cleanup - remove 254 @ts-expect-error suppressions (#7884 )

2026-01-10 21:17:31 -08:00

groupOptions.ts

Contextmenu extension migration (#5993 )

2025-10-28 04:02:28 +01:00

imageCompare.ts

feat: add ImageCompare node (#7538 )

2025-12-26 13:27:44 -07:00

index.ts

feat: add ImageCompare node (#7538 )

2025-12-26 13:27:44 -07:00

load3d.ts

3dgs & ply support (#7602 )

2025-12-20 14:04:16 -07:00

maskeditor.ts

Added MaskEditor Rotate and Mirror Functions (#7841 )

2026-01-10 12:45:08 -08:00

nodeTemplates.ts

Chore: TypeScript cleanup - remove 254 @ts-expect-error suppressions (#7884 )

2026-01-10 21:17:31 -08:00

noteNode.ts

fix: Note/MarkdownNote node color change not reactive in vueNodes mode (#7294 )

2025-12-09 09:17:07 -08:00

previewAny.ts

fix: improve type safety in litegraph library layer - No Explicit Any mission (PR 2) (#7401 )

2026-01-09 21:58:39 +01:00

README.md

docs: Clarify extension terminology and dev server limitations (#5042 )

2025-08-18 13:43:51 -07:00

rerouteNode.ts

Add front end support for type matching (#6582 )

2025-11-12 13:30:58 -07:00

saveImageExtraOutput.ts

add 'SaveVideo' into saveNodeTypes (#6647 )

2025-11-10 19:47:33 -05:00

saveMesh.ts

3dgs & ply support (#7602 )

2025-12-20 14:04:16 -07:00

selectionBorder.ts

Fix/selection toolbox reflow (#5158 )

2025-08-22 12:36:20 -07:00

simpleTouchSupport.ts

fix: reset touch state when iPad Safari loses focus (#7134 )

2025-12-03 20:34:56 -05:00

slotDefaults.ts

[refactor] Migrate litegraph imports from npm package to local subtree

2025-08-03 22:06:29 -04:00

uploadAudio.ts

Cleanup app.graph usage (#7399 )

2025-12-11 23:37:34 -07:00

uploadImage.ts

feat: enable verbatimModuleSyntax in TypeScript config (#5533 )

2025-09-18 21:05:56 -07:00

webcamCapture.ts

Cleanup app.graph usage (#7399 )

2025-12-11 23:37:34 -07:00

widgetInputs.ts

Fix doubled control application (#7550 )

2025-12-16 18:42:02 -08:00

README.md

Core Extensions

This directory contains the core extensions that provide essential functionality to the ComfyUI frontend.

📚 Full Documentation

The complete documentation for core extensions has been moved to:

/docs/extensions/core.md

Quick Reference

This directory contains built-in extensions that ship with ComfyUI, including:

Image Processing: maskeditor, uploadImage, saveImageExtraOutput, clipspace
Graph Management: groupNode, groupNodeManage, groupOptions, rerouteNode, noteNode
Input Handling: widgetInputs, uploadAudio, webcamCapture, simpleTouchSupport
UI Enhancements: contextMenuFilter, previewAny, nodeTemplates
Text Processing: dynamicPrompts, editAttention
Platform Support: electronAdapter

and more.

README.md

Core Extensions

📚 Full Documentation

Quick Reference

See Also