mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-01 22:09:55 +00:00
856eb446a5
## Summary Added pinning functionality to Vue nodes with hotkey support and visual indicators. ## Changes - **What**: Added node pinning feature with 'p' hotkey toggle and pin icon indicator - **Components**: Updated `LGraphNode.vue` and `NodeHeader.vue` with pin state tracking - **State Management**: Extended `useGraphNodeManager` to sync pinned flag with Vue components - **Tests**: Added E2E tests for single and multi-node pin toggling ## Review Focus Pin state persistence in graph serialization and visual indicator positioning in node header layout. Verify hotkey doesn't conflict with existing shortcuts. ## Technical Details - Pin state tracked via `flags.pinned` property in `LGraphNode` - Uses [Vue memoization](https://vuejs.org/api/reactivity-advanced.html#v-memo) for efficient header re-rendering - Integrates with existing node property change detection system - Visual indicator uses Lucide pin icon with theme-aware styling ## Screenshots (if applicable) <img width="875" height="977" alt="Screenshot from 2025-09-25 13-02-21" src="https://github.com/user-attachments/assets/51d46cea-08f0-44fb-8b07-56d1b939338f" /> <img width="875" height="977" alt="Screenshot from 2025-09-25 13-02-10" src="https://github.com/user-attachments/assets/ce247426-1e39-48c0-924b-658b65c24f52" /> ## Related - https://github.com/Comfy-Org/ComfyUI_frontend/pull/5715 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5772-Add-node-pinning-functionality-to-Vue-nodes-2796d73d36508195914bcfc986aa66b5) by [Unito](https://www.unito.io) --------- Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../../../fixtures/ComfyPage'
|
|
|
|
const PIN_HOTKEY = 'p'
|
|
const PIN_INDICATOR = '[data-testid="node-pin-indicator"]'
|
|
|
|
test.describe('Vue Node Pin', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('should allow toggling pin on a selected node with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const pinIndicator = checkpointNode.locator(PIN_INDICATOR)
|
|
|
|
await expect(pinIndicator).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator).not.toBeVisible()
|
|
})
|
|
|
|
test('should allow toggling pin on multiple selected nodes with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.getByText('KSampler').click({ modifiers: ['Control'] })
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const ksamplerNode = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
const pinIndicator1 = checkpointNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator1).toBeVisible()
|
|
const pinIndicator2 = ksamplerNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator2).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator1).not.toBeVisible()
|
|
await expect(pinIndicator2).not.toBeVisible()
|
|
})
|
|
|
|
test('should not allow dragging pinned nodes', async ({ comfyPage }) => {
|
|
const checkpointNodeHeader = comfyPage.page.getByText('Load Checkpoint')
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node
|
|
const headerPos = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPos) throw new Error('Failed to get header position')
|
|
await comfyPage.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is not dragged (same position before and after click-and-drag)
|
|
const headerPosAfterDrag = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPosAfterDrag)
|
|
throw new Error('Failed to get header position after drag')
|
|
expect(headerPosAfterDrag).toEqual(headerPos)
|
|
|
|
// Unpin the node with the hotkey
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node again
|
|
await comfyPage.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is dragged
|
|
const headerPosAfterDrag2 = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPosAfterDrag2)
|
|
throw new Error('Failed to get header position after drag')
|
|
expect(headerPosAfterDrag2).not.toEqual(headerPos)
|
|
})
|
|
})
|