mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 23:20:07 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
import type { Locator } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
async function verifyCustomIconSvg(iconElement: Locator) {
|
|
const svgVariable = await iconElement.evaluate((element) => {
|
|
const styles = getComputedStyle(element)
|
|
return styles.getPropertyValue('--svg')
|
|
})
|
|
|
|
expect(svgVariable).toBeTruthy()
|
|
const dataUrlMatch = svgVariable.match(
|
|
/url\("data:image\/svg\+xml,([^"]+)"\)/
|
|
)
|
|
expect(dataUrlMatch).toBeTruthy()
|
|
|
|
const encodedSvg = dataUrlMatch![1]
|
|
const decodedSvg = decodeURIComponent(encodedSvg)
|
|
|
|
// Check for SVG header to confirm it's a valid SVG
|
|
expect(decodedSvg).toContain("<svg xmlns='http://www.w3.org/2000/svg'")
|
|
}
|
|
|
|
test.describe('Custom Icons', { tag: '@settings' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('sidebar tab icons use custom SVGs', async ({ comfyPage }) => {
|
|
// Find the icon in the sidebar
|
|
const icon = comfyPage.page.locator(
|
|
'.icon-\\[comfy--ai-model\\].side-bar-button-icon'
|
|
)
|
|
await expect(icon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(icon)
|
|
})
|
|
|
|
test('Browse Templates menu item uses custom template icon', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Open the topbar menu
|
|
await comfyPage.menu.topbar.openTopbarMenu()
|
|
const menuItem = comfyPage.menu.topbar.getMenuItem('Browse Templates')
|
|
|
|
// Find the icon as a previous sibling of the menu item label
|
|
const templateIcon = menuItem
|
|
.locator('..')
|
|
.locator('.icon-\\[comfy--template\\]')
|
|
await expect(templateIcon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(templateIcon)
|
|
})
|
|
})
|