mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 10:59:53 +00:00
bc4549244e
## Summary UseNewMenu has been defaulted to Top in the app for over a year; Playwright’s test default lagged behind. This PR aligns the test default with reality and keeps legacy specs stable. ## Changes - tests(e2e): default to 'Top' via fixture; specs that previously relied on the old implicit default now explicitly set 'Comfy.UseNewMenu' to 'Disabled'. - docs(browser-tests): remove outdated README note suggesting tests set 'Top' manually. ## Review Focus - Intentional uses of 'Top' and 'Bottom' remain unchanged. - Confirm ComfyPage default remains 'Top' (see browser_tests/fixtures/ComfyPage.ts). ## Screenshots (if applicable) N/A ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5746-test-e2e-align-test-default-menu-to-Top-make-legacy-specs-explicit-2786d73d365081218d06c1346f3ae18e) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
86 lines
3.4 KiB
TypeScript
86 lines
3.4 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
// If an input is optional by node definition, it should be shown as
|
|
// a hollow circle no matter what shape it was defined in the workflow JSON.
|
|
test.describe('Optional input', () => {
|
|
test('No shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_no_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Wrong shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_wrong_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Correct shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_correct_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Force input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/force_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('force_input.png')
|
|
})
|
|
|
|
test('Default input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/default_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('default_input.png')
|
|
})
|
|
|
|
test('Only optional inputs', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/only_optional_inputs')
|
|
expect(await comfyPage.getGraphNodesCount()).toBe(1)
|
|
await expect(
|
|
comfyPage.page.locator('.comfy-missing-nodes')
|
|
).not.toBeVisible()
|
|
|
|
// If the node's multiline text widget is visible, then it was loaded successfully
|
|
await expect(comfyPage.page.locator('.comfy-multiline-input')).toHaveCount(
|
|
1
|
|
)
|
|
})
|
|
test('Old workflow with converted input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/old_workflow_converted_input')
|
|
const node = await comfyPage.getNodeRefById('1')
|
|
const inputs = await node.getProperty('inputs')
|
|
const vaeInput = inputs.find((w) => w.name === 'vae')
|
|
const convertedInput = inputs.find((w) => w.name === 'strength')
|
|
|
|
expect(vaeInput).toBeDefined()
|
|
expect(convertedInput).toBeDefined()
|
|
expect(vaeInput.link).toBeNull()
|
|
expect(convertedInput.link).not.toBeNull()
|
|
})
|
|
test('Renamed converted input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/renamed_converted_widget')
|
|
const node = await comfyPage.getNodeRefById('3')
|
|
const inputs = await node.getProperty('inputs')
|
|
const renamedInput = inputs.find((w) => w.name === 'breadth')
|
|
expect(renamedInput).toBeUndefined()
|
|
})
|
|
test('slider', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/simple_slider')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('simple_slider.png')
|
|
})
|
|
test('unknown converted widget', async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.Workflow.ShowMissingNodesWarning', false)
|
|
await comfyPage.loadWorkflow('missing/missing_nodes_converted_widget')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'missing_nodes_converted_widget.png'
|
|
)
|
|
})
|
|
test('dynamically added input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/dynamically_added_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'dynamically_added_input.png'
|
|
)
|
|
})
|
|
})
|