mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
53 lines
1.6 KiB
TypeScript
53 lines
1.6 KiB
TypeScript
import { test as base } from '@playwright/test'
|
|
|
|
export const webSocketFixture = base.extend<{
|
|
ws: { trigger(data: unknown, url?: string): Promise<void> }
|
|
}>({
|
|
ws: [
|
|
async ({ page }, use) => {
|
|
// Each time a page loads, to catch navigations
|
|
page.on('load', async () => {
|
|
await page.evaluate(function () {
|
|
// Create a wrapper for WebSocket that stores them globally
|
|
// so we can look it up to trigger messages
|
|
const store: Record<string, WebSocket> = (window.__ws__ = {})
|
|
window.WebSocket = class extends window.WebSocket {
|
|
constructor(
|
|
...rest: ConstructorParameters<typeof window.WebSocket>
|
|
) {
|
|
super(...rest)
|
|
store[this.url] = this
|
|
}
|
|
}
|
|
})
|
|
})
|
|
|
|
await use({
|
|
async trigger(data, url) {
|
|
// Trigger a websocket event on the page
|
|
await page.evaluate(
|
|
function ([data, url]) {
|
|
if (!url) {
|
|
// If no URL specified, use page URL
|
|
const u = new URL(window.location.toString())
|
|
u.protocol = 'ws:'
|
|
u.pathname = '/'
|
|
url = u.toString() + 'ws'
|
|
}
|
|
const ws: WebSocket = window.__ws__![url]
|
|
ws.dispatchEvent(
|
|
new MessageEvent('message', {
|
|
data
|
|
})
|
|
)
|
|
},
|
|
[JSON.stringify(data), url]
|
|
)
|
|
}
|
|
})
|
|
},
|
|
// We need this to run automatically as the first thing so it adds handlers as soon as the page loads
|
|
{ auto: true }
|
|
]
|
|
})
|