mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
58 lines
1.7 KiB
TypeScript
58 lines
1.7 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import type { AutoQueueMode } from '../../src/stores/queueStore'
|
|
import { TestIds } from '../fixtures/selectors'
|
|
import type { WorkspaceStore } from '../types/globals'
|
|
|
|
export class ComfyActionbar {
|
|
public readonly root: Locator
|
|
public readonly queueButton: ComfyQueueButton
|
|
public readonly propertiesButton: Locator
|
|
|
|
constructor(public readonly page: Page) {
|
|
this.root = page.locator('.actionbar-container')
|
|
this.queueButton = new ComfyQueueButton(this)
|
|
this.propertiesButton = this.root.getByLabel('Toggle properties panel')
|
|
}
|
|
|
|
async isDocked() {
|
|
const className = await this.root
|
|
.locator('.actionbar')
|
|
.getAttribute('class')
|
|
return className?.includes('static') ?? false
|
|
}
|
|
}
|
|
|
|
class ComfyQueueButton {
|
|
public readonly root: Locator
|
|
public readonly primaryButton: Locator
|
|
public readonly dropdownButton: Locator
|
|
constructor(public readonly actionbar: ComfyActionbar) {
|
|
this.root = actionbar.root.getByTestId(TestIds.topbar.queueButton)
|
|
this.primaryButton = this.root.locator('.p-splitbutton-button')
|
|
this.dropdownButton = this.root.locator('.p-splitbutton-dropdown')
|
|
}
|
|
|
|
public async toggleOptions() {
|
|
await this.dropdownButton.click()
|
|
return new ComfyQueueButtonOptions(this.actionbar.page)
|
|
}
|
|
}
|
|
|
|
class ComfyQueueButtonOptions {
|
|
constructor(public readonly page: Page) {}
|
|
|
|
public async setMode(mode: AutoQueueMode) {
|
|
await this.page.evaluate((mode) => {
|
|
;(window.app!.extensionManager as WorkspaceStore).queueSettings.mode =
|
|
mode
|
|
}, mode)
|
|
}
|
|
|
|
public async getMode() {
|
|
return await this.page.evaluate(() => {
|
|
return (window.app!.extensionManager as WorkspaceStore).queueSettings.mode
|
|
})
|
|
}
|
|
}
|