mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
105 lines
2.5 KiB
TypeScript
105 lines
2.5 KiB
TypeScript
import type { ReadOnlyRect } from '../../src/lib/litegraph/src/interfaces'
|
|
import type { ComfyPage } from '../fixtures/ComfyPage'
|
|
|
|
interface FitToViewOptions {
|
|
selectionOnly?: boolean
|
|
zoom?: number
|
|
padding?: number
|
|
}
|
|
|
|
/**
|
|
* Instantly fits the canvas view to graph content without waiting for UI animation.
|
|
*
|
|
* Lives outside the shared fixture to keep the default ComfyPage interactions user-oriented.
|
|
*/
|
|
export async function fitToViewInstant(
|
|
comfyPage: ComfyPage,
|
|
options: FitToViewOptions = {}
|
|
) {
|
|
const { selectionOnly = false, zoom = 0.75, padding = 10 } = options
|
|
|
|
const rectangles = await comfyPage.page.evaluate<
|
|
ReadOnlyRect[] | null,
|
|
{ selectionOnly: boolean }
|
|
>(
|
|
({ selectionOnly }) => {
|
|
const app = window.app
|
|
if (!app?.canvas) return null
|
|
|
|
const canvas = app.canvas
|
|
const items = (() => {
|
|
if (selectionOnly && canvas.selectedItems?.size) {
|
|
return Array.from(canvas.selectedItems)
|
|
}
|
|
try {
|
|
return Array.from(canvas.positionableItems ?? [])
|
|
} catch {
|
|
return []
|
|
}
|
|
})()
|
|
|
|
if (!items.length) return null
|
|
|
|
const rects: ReadOnlyRect[] = []
|
|
|
|
for (const item of items) {
|
|
const rect = item?.boundingRect
|
|
if (!rect) continue
|
|
|
|
const x = Number(rect[0])
|
|
const y = Number(rect[1])
|
|
const width = Number(rect[2])
|
|
const height = Number(rect[3])
|
|
|
|
rects.push([x, y, width, height] as const)
|
|
}
|
|
|
|
return rects.length ? rects : null
|
|
},
|
|
{ selectionOnly }
|
|
)
|
|
|
|
if (!rectangles || rectangles.length === 0) return
|
|
|
|
let minX = Infinity
|
|
let minY = Infinity
|
|
let maxX = -Infinity
|
|
let maxY = -Infinity
|
|
|
|
for (const [x, y, width, height] of rectangles) {
|
|
minX = Math.min(minX, Number(x))
|
|
minY = Math.min(minY, Number(y))
|
|
maxX = Math.max(maxX, Number(x) + Number(width))
|
|
maxY = Math.max(maxY, Number(y) + Number(height))
|
|
}
|
|
|
|
const hasFiniteBounds =
|
|
Number.isFinite(minX) &&
|
|
Number.isFinite(minY) &&
|
|
Number.isFinite(maxX) &&
|
|
Number.isFinite(maxY)
|
|
|
|
if (!hasFiniteBounds) return
|
|
|
|
const bounds: ReadOnlyRect = [
|
|
minX - padding,
|
|
minY - padding,
|
|
maxX - minX + 2 * padding,
|
|
maxY - minY + 2 * padding
|
|
]
|
|
|
|
await comfyPage.page.evaluate(
|
|
({ bounds, zoom }) => {
|
|
const app = window.app
|
|
if (!app?.canvas) return
|
|
|
|
const canvas = app.canvas
|
|
canvas.ds.fitToBounds(bounds, { zoom })
|
|
canvas.setDirty(true, true)
|
|
},
|
|
{ bounds, zoom }
|
|
)
|
|
|
|
await comfyPage.nextFrame()
|
|
}
|