mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
133 lines
4.5 KiB
TypeScript
133 lines
4.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import { DefaultGraphPositions } from '../fixtures/constants/defaultGraphPositions'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Copy Paste', { tag: ['@screenshot', '@workflow'] }, () => {
|
|
test('Can copy and paste node', async ({ comfyPage }) => {
|
|
await comfyPage.canvas.click({
|
|
position: DefaultGraphPositions.emptyLatentWidgetClick
|
|
})
|
|
await comfyPage.page.mouse.move(10, 10)
|
|
await comfyPage.nextFrame()
|
|
await comfyPage.clipboard.copy()
|
|
await comfyPage.clipboard.paste()
|
|
await expect(comfyPage.canvas).toHaveScreenshot('copied-node.png')
|
|
})
|
|
|
|
test('Can copy and paste node with link', async ({ comfyPage }) => {
|
|
await comfyPage.canvas.click({
|
|
position: DefaultGraphPositions.textEncodeNode1
|
|
})
|
|
await comfyPage.nextFrame()
|
|
await comfyPage.page.mouse.move(10, 10)
|
|
await comfyPage.clipboard.copy()
|
|
await comfyPage.page.keyboard.press('Control+Shift+V')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('copied-node-with-link.png')
|
|
})
|
|
|
|
test('Can copy and paste text', async ({ comfyPage }) => {
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
const originalString = await textBox.inputValue()
|
|
await textBox.selectText()
|
|
await comfyPage.clipboard.copy(null)
|
|
await comfyPage.clipboard.paste(null)
|
|
await comfyPage.clipboard.paste(null)
|
|
const resultString = await textBox.inputValue()
|
|
expect(resultString).toBe(originalString + originalString)
|
|
})
|
|
|
|
test('Can copy and paste widget value', async ({ comfyPage }) => {
|
|
// Copy width value (512) from empty latent node to KSampler's seed.
|
|
// KSampler's seed
|
|
await comfyPage.canvas.click({
|
|
position: {
|
|
x: 1005,
|
|
y: 281
|
|
}
|
|
})
|
|
await comfyPage.clipboard.copy(null)
|
|
// Empty latent node's width
|
|
await comfyPage.canvas.click({
|
|
position: {
|
|
x: 718,
|
|
y: 643
|
|
}
|
|
})
|
|
await comfyPage.clipboard.paste(null)
|
|
await comfyPage.page.keyboard.press('Enter')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('copied-widget-value.png')
|
|
})
|
|
|
|
/**
|
|
* https://github.com/Comfy-Org/ComfyUI_frontend/issues/98
|
|
*/
|
|
test('Paste in text area with node previously copied', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.canvas.click({
|
|
position: DefaultGraphPositions.emptyLatentWidgetClick
|
|
})
|
|
await comfyPage.page.mouse.move(10, 10)
|
|
await comfyPage.nextFrame()
|
|
await comfyPage.clipboard.copy(null)
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
await textBox.inputValue()
|
|
await textBox.selectText()
|
|
await comfyPage.clipboard.copy(null)
|
|
await comfyPage.clipboard.paste(null)
|
|
await comfyPage.clipboard.paste(null)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'paste-in-text-area-with-node-previously-copied.png'
|
|
)
|
|
})
|
|
|
|
test('Copy text area does not copy node', async ({ comfyPage }) => {
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
await textBox.inputValue()
|
|
await textBox.selectText()
|
|
await comfyPage.clipboard.copy(null)
|
|
// Unfocus textbox.
|
|
await comfyPage.page.mouse.click(10, 10)
|
|
await comfyPage.clipboard.paste(null)
|
|
await expect(comfyPage.canvas).toHaveScreenshot('no-node-copied.png')
|
|
})
|
|
|
|
test('Copy node by dragging + alt', async ({ comfyPage }) => {
|
|
// TextEncodeNode1
|
|
await comfyPage.page.mouse.move(618, 191)
|
|
await comfyPage.page.keyboard.down('Alt')
|
|
await comfyPage.page.mouse.down()
|
|
await comfyPage.page.mouse.move(100, 100)
|
|
await comfyPage.page.mouse.up()
|
|
await comfyPage.page.keyboard.up('Alt')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('drag-copy-copied-node.png')
|
|
})
|
|
|
|
test('Can undo paste multiple nodes as single action', async ({
|
|
comfyPage
|
|
}) => {
|
|
const initialCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(initialCount).toBeGreaterThan(1)
|
|
await comfyPage.canvas.click()
|
|
await comfyPage.keyboard.selectAll()
|
|
await comfyPage.page.mouse.move(10, 10)
|
|
await comfyPage.clipboard.copy()
|
|
await comfyPage.clipboard.paste()
|
|
|
|
const pasteCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(pasteCount).toBe(initialCount * 2)
|
|
|
|
await comfyPage.keyboard.undo()
|
|
const undoCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(undoCount).toBe(initialCount)
|
|
})
|
|
})
|