mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
127 lines
4.0 KiB
TypeScript
127 lines
4.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { SystemStats } from '../../src/schemas/apiSchema'
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Version Mismatch Warnings', { tag: '@slow' }, () => {
|
|
const ALWAYS_AHEAD_OF_INSTALLED_VERSION = '100.100.100'
|
|
const ALWAYS_BEHIND_INSTALLED_VERSION = '0.0.0'
|
|
|
|
const createMockSystemStatsRes = (
|
|
requiredFrontendVersion: string
|
|
): SystemStats => {
|
|
return {
|
|
system: {
|
|
os: 'posix',
|
|
ram_total: 67235385344,
|
|
ram_free: 13464207360,
|
|
comfyui_version: '0.3.46',
|
|
required_frontend_version: requiredFrontendVersion,
|
|
python_version: '3.12.3 (main, Jun 18 2025, 17:59:45) [GCC 13.3.0]',
|
|
pytorch_version: '2.6.0+cu124',
|
|
embedded_python: false,
|
|
argv: ['main.py']
|
|
},
|
|
devices: [
|
|
{
|
|
name: 'cuda:0 NVIDIA GeForce RTX 4070 : cudaMallocAsync',
|
|
type: 'cuda',
|
|
index: 0,
|
|
vram_total: 12557156352,
|
|
vram_free: 2439249920,
|
|
torch_vram_total: 0,
|
|
torch_vram_free: 0
|
|
}
|
|
]
|
|
}
|
|
}
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.VersionCompatibility.DisableWarnings',
|
|
false
|
|
)
|
|
})
|
|
|
|
test('should show version mismatch warnings when installed version lower than required', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_AHEAD_OF_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Expect a warning toast to be shown
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('should not show version mismatch warnings when installed version is ahead of required', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_BEHIND_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Expect no warning toast to be shown
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('should persist dismissed state across sessions', async ({
|
|
comfyPage
|
|
}) => {
|
|
test.setTimeout(30_000)
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_AHEAD_OF_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Locate the warning toast and dismiss it
|
|
const warningToast = comfyPage.page.locator('.p-toast-message').filter({
|
|
hasText: 'Version Compatibility'
|
|
})
|
|
await warningToast.waitFor({ state: 'visible' })
|
|
const dismissButton = warningToast.getByRole('button', { name: 'Close' })
|
|
await dismissButton.click()
|
|
|
|
// Wait for the dismissed state to be persisted
|
|
await comfyPage.page.waitForFunction(
|
|
() => !!localStorage.getItem('comfy.versionMismatch.dismissals')
|
|
)
|
|
|
|
// Reload the page, keeping local storage
|
|
await comfyPage.setup({ clearStorage: false })
|
|
|
|
// The same warning from same versions should not be shown to the user again
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).not.toBeVisible()
|
|
})
|
|
})
|