mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 22:59:14 +00:00
## Summary - Upgrades all GitHub Actions workflows to use `actions/checkout@v5` - Updates 33 instances across 17 workflow files - Ensures we're using the latest version with security patches and improvements ## Changes Updated the following workflow files from `actions/checkout@v4` to `actions/checkout@v5`: - `.github/workflows/backport.yaml` - `.github/workflows/chromatic.yaml` - `.github/workflows/claude-pr-review.yml` - `.github/workflows/create-release-candidate-branch.yaml` - `.github/workflows/dev-release.yaml` - `.github/workflows/devtools-python.yaml` - `.github/workflows/i18n-custom-nodes.yaml` - `.github/workflows/json-validate.yaml` - `.github/workflows/lint-and-format.yaml` - `.github/workflows/pr-playwright-deploy.yaml` - `.github/workflows/pr-storybook-deploy.yaml` - `.github/workflows/test-ui.yaml` - `.github/workflows/update-electron-types.yaml` - `.github/workflows/update-manager-types.yaml` - `.github/workflows/update-registry-types.yaml` - `.github/workflows/version-bump.yaml` - `.github/workflows/vitest.yaml` Note: `.github/workflows/publish-frontend-types.yaml` and `.github/workflows/release.yaml` were already using v5. ## Test plan - [ ] CI workflows should continue to run successfully - [ ] No functional changes - this is a dependency version upgrade only 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5859-ci-Upgrade-actions-checkout-from-v4-to-v5-27e6d73d3650815488adee20c74c0464) by [Unito](https://www.unito.io) Co-authored-by: Claude <noreply@anthropic.com>
232 lines
8.3 KiB
YAML
232 lines
8.3 KiB
YAML
name: Storybook and Chromatic CI
|
|
|
|
# - [Automate Chromatic with GitHub Actions • Chromatic docs]( https://www.chromatic.com/docs/github-actions/ )
|
|
|
|
on:
|
|
workflow_dispatch: # Allow manual triggering
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
jobs:
|
|
# Post starting comment for non-forked PRs
|
|
comment-on-pr-start:
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
|
|
permissions:
|
|
pull-requests: write
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v5
|
|
|
|
- name: Post starting comment
|
|
env:
|
|
GITHUB_TOKEN: ${{ github.token }}
|
|
run: |
|
|
chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
|
|
./scripts/cicd/pr-storybook-deploy-and-comment.sh \
|
|
"${{ github.event.pull_request.number }}" \
|
|
"${{ github.head_ref }}" \
|
|
"starting" \
|
|
"$(date -u '+%m/%d/%Y, %I:%M:%S %p')"
|
|
|
|
# Build Storybook for all PRs (free Cloudflare deployment)
|
|
storybook-build:
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request'
|
|
outputs:
|
|
conclusion: ${{ steps.job-status.outputs.conclusion }}
|
|
workflow-url: ${{ steps.workflow-url.outputs.url }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v5
|
|
|
|
- name: Install pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 10
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Cache tool outputs
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: |
|
|
.cache
|
|
storybook-static
|
|
tsconfig.tsbuildinfo
|
|
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}
|
|
restore-keys: |
|
|
storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
|
|
storybook-cache-${{ runner.os }}-
|
|
storybook-tools-cache-${{ runner.os }}-
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build Storybook
|
|
run: pnpm build-storybook
|
|
|
|
- name: Set job status
|
|
id: job-status
|
|
if: always()
|
|
run: |
|
|
echo "conclusion=${{ job.status }}" >> $GITHUB_OUTPUT
|
|
|
|
- name: Get workflow URL
|
|
id: workflow-url
|
|
if: always()
|
|
run: |
|
|
echo "url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_OUTPUT
|
|
|
|
- name: Upload Storybook build
|
|
if: success() && github.event.pull_request.head.repo.fork == false
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: storybook-static
|
|
path: storybook-static/
|
|
retention-days: 7
|
|
|
|
# Chromatic deployment only for version-bump-* branches or manual triggers
|
|
chromatic-deployment:
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'version-bump-'))
|
|
outputs:
|
|
conclusion: ${{ steps.job-status.outputs.conclusion }}
|
|
workflow-url: ${{ steps.workflow-url.outputs.url }}
|
|
chromatic-build-url: ${{ steps.chromatic.outputs.buildUrl }}
|
|
chromatic-storybook-url: ${{ steps.chromatic.outputs.storybookUrl }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0 # Required for Chromatic baseline
|
|
|
|
- name: Install pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 10
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Cache tool outputs
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: |
|
|
.cache
|
|
storybook-static
|
|
tsconfig.tsbuildinfo
|
|
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}
|
|
restore-keys: |
|
|
storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
|
|
storybook-cache-${{ runner.os }}-
|
|
storybook-tools-cache-${{ runner.os }}-
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build Storybook and run Chromatic
|
|
id: chromatic
|
|
uses: chromaui/action@latest
|
|
with:
|
|
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
|
|
buildScriptName: build-storybook
|
|
autoAcceptChanges: 'main' # Auto-accept changes on main branch
|
|
exitOnceUploaded: true # Don't wait for UI tests to complete
|
|
onlyChanged: true # Only capture changed stories
|
|
|
|
- name: Set job status
|
|
id: job-status
|
|
if: always()
|
|
run: |
|
|
echo "conclusion=${{ job.status }}" >> $GITHUB_OUTPUT
|
|
|
|
- name: Get workflow URL
|
|
id: workflow-url
|
|
if: always()
|
|
run: |
|
|
echo "url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_OUTPUT
|
|
|
|
# Deploy and comment for non-forked PRs only
|
|
deploy-and-comment:
|
|
needs: [storybook-build]
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false && always()
|
|
permissions:
|
|
pull-requests: write
|
|
contents: read
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v5
|
|
|
|
- name: Download Storybook build
|
|
if: needs.storybook-build.outputs.conclusion == 'success'
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: storybook-static
|
|
path: storybook-static
|
|
|
|
- name: Make deployment script executable
|
|
run: chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
|
|
|
|
- name: Deploy Storybook and comment on PR
|
|
env:
|
|
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
|
|
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
|
|
GITHUB_TOKEN: ${{ github.token }}
|
|
WORKFLOW_CONCLUSION: ${{ needs.storybook-build.outputs.conclusion }}
|
|
WORKFLOW_URL: ${{ needs.storybook-build.outputs.workflow-url }}
|
|
run: |
|
|
./scripts/cicd/pr-storybook-deploy-and-comment.sh \
|
|
"${{ github.event.pull_request.number }}" \
|
|
"${{ github.head_ref }}" \
|
|
"completed"
|
|
|
|
# Update comment with Chromatic URLs for version-bump branches
|
|
update-comment-with-chromatic:
|
|
needs: [chromatic-deployment, deploy-and-comment]
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false && startsWith(github.head_ref, 'version-bump-') && needs.chromatic-deployment.outputs.chromatic-build-url != ''
|
|
permissions:
|
|
pull-requests: write
|
|
steps:
|
|
- name: Update comment with Chromatic URLs
|
|
uses: actions/github-script@v7
|
|
with:
|
|
script: |
|
|
const buildUrl = '${{ needs.chromatic-deployment.outputs.chromatic-build-url }}';
|
|
const storybookUrl = '${{ needs.chromatic-deployment.outputs.chromatic-storybook-url }}';
|
|
|
|
// Find the existing Storybook comment
|
|
const { data: comments } = await github.rest.issues.listComments({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: ${{ github.event.pull_request.number }}
|
|
});
|
|
|
|
const storybookComment = comments.find(comment =>
|
|
comment.body.includes('<!-- STORYBOOK_BUILD_STATUS -->')
|
|
);
|
|
|
|
if (storybookComment && buildUrl && storybookUrl) {
|
|
// Append Chromatic info to existing comment
|
|
const updatedBody = storybookComment.body.replace(
|
|
/---\n(.*)$/s,
|
|
`---\n### 🎨 Chromatic Visual Tests\n- 📊 [View Chromatic Build](${buildUrl})\n- 📚 [View Chromatic Storybook](${storybookUrl})\n\n$1`
|
|
);
|
|
|
|
await github.rest.issues.updateComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
comment_id: storybookComment.id,
|
|
body: updatedBody
|
|
});
|
|
}
|