mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-07 08:30:06 +00:00
## Summary
- Fix `useSubscriptionCredits` test to use cents (500) instead of
incorrect micros (5000000)
- Despite API field names containing `micros`, the server actually
returns cents (1/100)
- Add clarifying comment to `usdToMicros()` about the cents vs micros
confusion
- Increase performance test threshold from 10ms to 50ms to reduce
flakiness
## Context
The API response fields are named `amount_micros`,
`cloud_credit_balance_micros`, etc., but the server actually sends
**cents** (1/100 of a dollar), not true micros (1/1,000,000).
Verified with real API response:
```json
{
"amount_micros": 2725.927956, // = $27.26 when divided by 100
"currency": "usd"
}
```
## Changes
-
`tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts`:
Update test values from micros to cents
- `packages/shared-frontend-utils/src/formatUtil.ts`: Add clarifying
documentation
- `tests-ui/tests/store/modelToNodeStore.test.ts`: Increase performance
test threshold to reduce flakiness
## Test Plan
- ✅ All unit tests pass (3202 passed, 206 skipped)
- ✅ Linting passes
- ✅ Formatting passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude <noreply@anthropic.com>
150 lines
4.4 KiB
TypeScript
150 lines
4.4 KiB
TypeScript
import { createPinia, setActivePinia } from 'pinia'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { useSubscriptionCredits } from '@/platform/cloud/subscription/composables/useSubscriptionCredits'
|
|
import { useFirebaseAuthStore } from '@/stores/firebaseAuthStore'
|
|
|
|
// Unmock firebaseAuthStore so we get the real Pinia store
|
|
vi.unmock('@/stores/firebaseAuthStore')
|
|
|
|
// Mock Firebase Auth and related modules
|
|
vi.mock('vuefire', () => ({
|
|
useFirebaseAuth: vi.fn(() => ({
|
|
onAuthStateChanged: vi.fn(),
|
|
setPersistence: vi.fn()
|
|
}))
|
|
}))
|
|
|
|
vi.mock('firebase/auth', () => ({
|
|
onAuthStateChanged: vi.fn(() => {
|
|
// Mock the callback to be called immediately for testing
|
|
return vi.fn()
|
|
}),
|
|
onIdTokenChanged: vi.fn(),
|
|
setPersistence: vi.fn().mockResolvedValue(undefined),
|
|
browserLocalPersistence: {},
|
|
GoogleAuthProvider: class {
|
|
addScope = vi.fn()
|
|
setCustomParameters = vi.fn()
|
|
},
|
|
GithubAuthProvider: class {
|
|
addScope = vi.fn()
|
|
setCustomParameters = vi.fn()
|
|
}
|
|
}))
|
|
|
|
// Mock other dependencies
|
|
vi.mock('@/services/dialogService', () => ({
|
|
useDialogService: () => ({
|
|
showDialog: vi.fn()
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/platform/telemetry', () => ({
|
|
useTelemetry: () => ({
|
|
track: vi.fn()
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/stores/toastStore', () => ({
|
|
useToastStore: () => ({
|
|
add: vi.fn()
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/stores/apiKeyAuthStore', () => ({
|
|
useApiKeyAuthStore: () => ({
|
|
headers: {}
|
|
})
|
|
}))
|
|
|
|
// Mock formatMetronomeCurrency
|
|
vi.mock('@/utils/formatUtil', () => ({
|
|
formatMetronomeCurrency: vi.fn((amount: number) => {
|
|
// Converts cents to dollars (despite the field name containing "micros")
|
|
return (amount / 100).toFixed(2)
|
|
})
|
|
}))
|
|
|
|
describe('useSubscriptionCredits', () => {
|
|
let authStore: ReturnType<typeof useFirebaseAuthStore>
|
|
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
authStore = useFirebaseAuthStore()
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('totalCredits', () => {
|
|
it('should return "0.00" when balance is null', () => {
|
|
authStore.balance = null
|
|
const { totalCredits } = useSubscriptionCredits()
|
|
expect(totalCredits.value).toBe('0.00')
|
|
})
|
|
|
|
it('should return "0.00" when amount_micros is missing', () => {
|
|
authStore.balance = {} as any
|
|
const { totalCredits } = useSubscriptionCredits()
|
|
expect(totalCredits.value).toBe('0.00')
|
|
})
|
|
|
|
it('should format amount_micros correctly', () => {
|
|
authStore.balance = { amount_micros: 500 } as any
|
|
const { totalCredits } = useSubscriptionCredits()
|
|
expect(totalCredits.value).toBe('5.00')
|
|
})
|
|
|
|
it('should handle formatting errors gracefully', async () => {
|
|
const mockFormatMetronomeCurrency = vi.mocked(
|
|
await import('@/utils/formatUtil')
|
|
).formatMetronomeCurrency
|
|
mockFormatMetronomeCurrency.mockImplementationOnce(() => {
|
|
throw new Error('Formatting error')
|
|
})
|
|
|
|
authStore.balance = { amount_micros: 500 } as any
|
|
const { totalCredits } = useSubscriptionCredits()
|
|
expect(totalCredits.value).toBe('0.00')
|
|
})
|
|
})
|
|
|
|
describe('monthlyBonusCredits', () => {
|
|
it('should return "0.00" when cloud_credit_balance_micros is missing', () => {
|
|
authStore.balance = {} as any
|
|
const { monthlyBonusCredits } = useSubscriptionCredits()
|
|
expect(monthlyBonusCredits.value).toBe('0.00')
|
|
})
|
|
|
|
it('should format cloud_credit_balance_micros correctly', () => {
|
|
authStore.balance = { cloud_credit_balance_micros: 250 } as any
|
|
const { monthlyBonusCredits } = useSubscriptionCredits()
|
|
expect(monthlyBonusCredits.value).toBe('2.50')
|
|
})
|
|
})
|
|
|
|
describe('prepaidCredits', () => {
|
|
it('should return "0.00" when prepaid_balance_micros is missing', () => {
|
|
authStore.balance = {} as any
|
|
const { prepaidCredits } = useSubscriptionCredits()
|
|
expect(prepaidCredits.value).toBe('0.00')
|
|
})
|
|
|
|
it('should format prepaid_balance_micros correctly', () => {
|
|
authStore.balance = { prepaid_balance_micros: 750 } as any
|
|
const { prepaidCredits } = useSubscriptionCredits()
|
|
expect(prepaidCredits.value).toBe('7.50')
|
|
})
|
|
})
|
|
|
|
describe('isLoadingBalance', () => {
|
|
it('should reflect authStore.isFetchingBalance', () => {
|
|
authStore.isFetchingBalance = true
|
|
const { isLoadingBalance } = useSubscriptionCredits()
|
|
expect(isLoadingBalance.value).toBe(true)
|
|
|
|
authStore.isFetchingBalance = false
|
|
expect(isLoadingBalance.value).toBe(false)
|
|
})
|
|
})
|
|
})
|