mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-18 22:10:03 +00:00
* track execution progress in vue nodes * add test * remove pointless execution state test The test was mocking everything including the provide/inject mechanism, so it wasn't testing real behavior. The execution progress feature works correctly as verified through manual testing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * remove accidentally committed PR_TEMPLATE.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [refactor] address PR review feedback from @DrJKL - Replace hardcoded #0B8CE9 color with blue-100 class for consistency - Replace magic number 56px with top-14 class for progress bar positioning - Use storeToRefs() for better Pinia reactivity - Reduce heavy commenting per maintainer preference * fix: update LGraphNode test to mock useNodeExecutionState properly The test was failing because it passed executing as a prop, but the component uses the useNodeExecutionState composable. Added proper mock for the composable to test the animate-pulse class application during execution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
192 lines
5.4 KiB
TypeScript
192 lines
5.4 KiB
TypeScript
import { createTestingPinia } from '@pinia/testing'
|
|
import { mount } from '@vue/test-utils'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { computed, ref } from 'vue'
|
|
import { createI18n } from 'vue-i18n'
|
|
|
|
import type { VueNodeData } from '@/composables/graph/useGraphNodeManager'
|
|
import { SelectedNodeIdsKey } from '@/renderer/core/canvas/injectionKeys'
|
|
import LGraphNode from '@/renderer/extensions/vueNodes/components/LGraphNode.vue'
|
|
import { useVueElementTracking } from '@/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking'
|
|
import { useNodeExecutionState } from '@/renderer/extensions/vueNodes/execution/useNodeExecutionState'
|
|
|
|
vi.mock(
|
|
'@/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking',
|
|
() => ({
|
|
useVueElementTracking: vi.fn()
|
|
})
|
|
)
|
|
|
|
vi.mock('@/composables/useErrorHandling', () => ({
|
|
useErrorHandling: () => ({
|
|
toastErrorHandler: vi.fn()
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/renderer/extensions/vueNodes/layout/useNodeLayout', () => ({
|
|
useNodeLayout: () => ({
|
|
position: { x: 100, y: 50 },
|
|
startDrag: vi.fn(),
|
|
handleDrag: vi.fn(),
|
|
endDrag: vi.fn()
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/renderer/extensions/vueNodes/lod/useLOD', () => ({
|
|
useLOD: () => ({
|
|
lodLevel: { value: 0 },
|
|
shouldRenderWidgets: { value: true },
|
|
shouldRenderSlots: { value: true },
|
|
shouldRenderContent: { value: false },
|
|
lodCssClass: { value: '' }
|
|
}),
|
|
LODLevel: { MINIMAL: 0 }
|
|
}))
|
|
|
|
vi.mock(
|
|
'@/renderer/extensions/vueNodes/execution/useNodeExecutionState',
|
|
() => ({
|
|
useNodeExecutionState: vi.fn(() => ({
|
|
executing: computed(() => false),
|
|
progress: computed(() => undefined),
|
|
progressPercentage: computed(() => undefined),
|
|
progressState: computed(() => undefined as any),
|
|
executionState: computed(() => 'idle' as const)
|
|
}))
|
|
})
|
|
)
|
|
|
|
const i18n = createI18n({
|
|
legacy: false,
|
|
locale: 'en',
|
|
messages: {
|
|
en: {
|
|
'Node Render Error': 'Node Render Error'
|
|
}
|
|
}
|
|
})
|
|
|
|
describe('LGraphNode', () => {
|
|
const mockNodeData: VueNodeData = {
|
|
id: 'test-node-123',
|
|
title: 'Test Node',
|
|
type: 'TestNode',
|
|
mode: 0,
|
|
flags: {},
|
|
inputs: [],
|
|
outputs: [],
|
|
widgets: [],
|
|
selected: false,
|
|
executing: false
|
|
}
|
|
|
|
const mountLGraphNode = (props: any, selectedNodeIds = new Set()) => {
|
|
return mount(LGraphNode, {
|
|
props,
|
|
global: {
|
|
plugins: [
|
|
createTestingPinia({
|
|
createSpy: vi.fn
|
|
}),
|
|
i18n
|
|
],
|
|
provide: {
|
|
[SelectedNodeIdsKey as symbol]: ref(selectedNodeIds)
|
|
},
|
|
stubs: {
|
|
NodeHeader: true,
|
|
NodeSlots: true,
|
|
NodeWidgets: true,
|
|
NodeContent: true,
|
|
SlotConnectionDot: true
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
// Reset to default mock
|
|
vi.mocked(useNodeExecutionState).mockReturnValue({
|
|
executing: computed(() => false),
|
|
progress: computed(() => undefined),
|
|
progressPercentage: computed(() => undefined),
|
|
progressState: computed(() => undefined as any),
|
|
executionState: computed(() => 'idle' as const)
|
|
})
|
|
})
|
|
|
|
it('should call resize tracking composable with node ID', () => {
|
|
mountLGraphNode({ nodeData: mockNodeData })
|
|
|
|
expect(useVueElementTracking).toHaveBeenCalledWith('test-node-123', 'node')
|
|
})
|
|
|
|
it('should render with data-node-id attribute', () => {
|
|
const wrapper = mountLGraphNode({ nodeData: mockNodeData })
|
|
|
|
expect(wrapper.attributes('data-node-id')).toBe('test-node-123')
|
|
})
|
|
|
|
it('should render node title', () => {
|
|
// Don't stub NodeHeader for this test so we can see the title
|
|
const wrapper = mount(LGraphNode, {
|
|
props: { nodeData: mockNodeData },
|
|
global: {
|
|
plugins: [
|
|
createTestingPinia({
|
|
createSpy: vi.fn
|
|
}),
|
|
i18n
|
|
],
|
|
provide: {
|
|
[SelectedNodeIdsKey as symbol]: ref(new Set())
|
|
},
|
|
stubs: {
|
|
NodeSlots: true,
|
|
NodeWidgets: true,
|
|
NodeContent: true,
|
|
SlotConnectionDot: true
|
|
}
|
|
}
|
|
})
|
|
|
|
expect(wrapper.text()).toContain('Test Node')
|
|
})
|
|
|
|
it('should apply selected styling when selected prop is true', () => {
|
|
const wrapper = mountLGraphNode(
|
|
{ nodeData: mockNodeData, selected: true },
|
|
new Set(['test-node-123'])
|
|
)
|
|
expect(wrapper.classes()).toContain('outline-2')
|
|
expect(wrapper.classes()).toContain('outline-black')
|
|
expect(wrapper.classes()).toContain('dark-theme:outline-white')
|
|
})
|
|
|
|
it('should apply executing animation when executing prop is true', () => {
|
|
// Mock the execution state to return executing: true
|
|
vi.mocked(useNodeExecutionState).mockReturnValue({
|
|
executing: computed(() => true),
|
|
progress: computed(() => undefined),
|
|
progressPercentage: computed(() => undefined),
|
|
progressState: computed(() => undefined as any),
|
|
executionState: computed(() => 'running' as const)
|
|
})
|
|
|
|
const wrapper = mountLGraphNode({ nodeData: mockNodeData })
|
|
|
|
expect(wrapper.classes()).toContain('animate-pulse')
|
|
})
|
|
|
|
it('should emit node-click event on pointer up', async () => {
|
|
const wrapper = mountLGraphNode({ nodeData: mockNodeData })
|
|
|
|
await wrapper.trigger('pointerup')
|
|
|
|
expect(wrapper.emitted('node-click')).toHaveLength(1)
|
|
expect(wrapper.emitted('node-click')?.[0]).toHaveLength(3)
|
|
expect(wrapper.emitted('node-click')?.[0][1]).toEqual(mockNodeData)
|
|
})
|
|
})
|