mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
74 lines
1.7 KiB
TypeScript
74 lines
1.7 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
export class BuilderFooterHelper {
|
|
constructor(private readonly comfyPage: ComfyPage) {}
|
|
|
|
private get page(): Page {
|
|
return this.comfyPage.page
|
|
}
|
|
|
|
get nav(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.footerNav)
|
|
}
|
|
|
|
get exitButton(): Locator {
|
|
return this.buttonByName('Exit app builder')
|
|
}
|
|
|
|
get nextButton(): Locator {
|
|
return this.buttonByName('Next')
|
|
}
|
|
|
|
get backButton(): Locator {
|
|
return this.buttonByName('Back')
|
|
}
|
|
|
|
get saveButton(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.saveButton)
|
|
}
|
|
|
|
get saveGroup(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.saveGroup)
|
|
}
|
|
|
|
get saveAsButton(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.saveAsButton)
|
|
}
|
|
|
|
get saveAsChevron(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.saveAsChevron)
|
|
}
|
|
|
|
get opensAsPopover(): Locator {
|
|
return this.page.getByTestId(TestIds.builder.opensAs)
|
|
}
|
|
|
|
private buttonByName(name: string): Locator {
|
|
return this.nav.getByRole('button', { name })
|
|
}
|
|
|
|
async next() {
|
|
await this.nextButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async back() {
|
|
await this.backButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async exitBuilder() {
|
|
await this.exitButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async openSaveAsFromChevron() {
|
|
await this.saveAsChevron.click()
|
|
await this.page.getByRole('menuitem', { name: 'Save as' }).click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
}
|