mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
## Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI
runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only `browser_tests/` is touched.
## Changes
- **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers):
| Fix class | Sites | Examples |
|-----------|-------|---------:|
| `expect(await ...)` -> `expect.poll()` | ~153 | interaction,
defaultKeybindings, workflows, featureFlags |
| `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 |
menu, linkInteraction, assets, bottomPanelShortcuts |
| `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 |
contextMenu, rightClickMenu, subgraphHelper |
| Redundant `nextFrame()` removed | many | defaultKeybindings, minimap,
builderSaveFlow |
| `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction
(graphdialog dismiss guard) |
| `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog
fixture |
| ContextMenu `waitForHidden` simplified (check-then-act race removed) |
1 | ContextMenu fixture |
| Non-deterministic node order -> proximity-based selection | 1 |
interaction (toggle dom widget) |
| Tight poll timeout (250ms) -> >=2000ms | 2 | templates |
- **Helper improvements**: Exposed locator getters on
`ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and
`WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying
assertions (`toHaveCount()`, `toHaveText()`) directly.
- **Flake pattern catalog**: Added section 7 table to
`browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes
for reviewers and future authors.
- **Docs**: Fixed bad examples in `browser_tests/README.md` to use
`expect.poll()`.
- **Breaking**: None
- **Dependencies**: None
## Review Focus
- All fixes follow the rules in
`browser_tests/FLAKE_PREVENTION_RULES.md`
- No behavioral changes to tests -- only timing/retry strategy is
updated
- The `ContextMenu.waitForHidden` simplification removes a
swallowed-error anti-pattern; both locators now use direct `waitFor({
state: 'hidden' })`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
118 lines
3.6 KiB
TypeScript
118 lines
3.6 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe(
|
|
'Load Workflow in Media',
|
|
{ tag: ['@screenshot', '@workflow'] },
|
|
() => {
|
|
const fileNames = [
|
|
'workflow.webp',
|
|
'edited_workflow.webp',
|
|
'no_workflow.webp',
|
|
'large_workflow.webp',
|
|
'workflow_prompt_parameters.png',
|
|
'workflow_itxt.png',
|
|
'workflow.webm',
|
|
// Skipped due to 3d widget unstable visual result.
|
|
// 3d widget shows grid after fully loaded.
|
|
// 'workflow.glb',
|
|
'workflow.mp4',
|
|
'workflow.mov',
|
|
'workflow.m4v',
|
|
'workflow.svg'
|
|
// TODO: Re-enable after fixing test asset to use core nodes only
|
|
// Currently opens missing nodes dialog which is outside scope of AVIF loading functionality
|
|
// 'workflow.avif'
|
|
]
|
|
const filesWithUpload = new Set(['no_workflow.webp'])
|
|
|
|
fileNames.forEach(async (fileName) => {
|
|
test(`Load workflow in ${fileName} (drop from filesystem)`, async ({
|
|
comfyPage
|
|
}) => {
|
|
const shouldUpload = filesWithUpload.has(fileName)
|
|
const uploadRequestPromise = shouldUpload
|
|
? comfyPage.page.waitForRequest((req) =>
|
|
req.url().includes('/upload/')
|
|
)
|
|
: null
|
|
|
|
await comfyPage.dragDrop.dragAndDropFile(`workflowInMedia/${fileName}`)
|
|
|
|
if (uploadRequestPromise) {
|
|
const request = await uploadRequestPromise
|
|
expect(request.url()).toContain('/upload/')
|
|
} else {
|
|
await expect(comfyPage.canvas).toHaveScreenshot(`${fileName}.png`)
|
|
}
|
|
})
|
|
})
|
|
|
|
const urls = [
|
|
'https://comfyanonymous.github.io/ComfyUI_examples/hidream/hidream_dev_example.png'
|
|
]
|
|
urls.forEach(async (url) => {
|
|
test(`Load workflow from URL ${url} (drop from different browser tabs)`, async ({
|
|
comfyPage
|
|
}) => {
|
|
const initialNodeCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
|
|
await comfyPage.dragDrop.dragAndDropURL(url)
|
|
|
|
// The drop triggers an async fetch → parse → loadGraphData chain.
|
|
// Poll until the graph settles with the loaded workflow's nodes.
|
|
await expect
|
|
.poll(() => comfyPage.nodeOps.getGraphNodesCount(), {
|
|
timeout: 15000
|
|
})
|
|
.toBeGreaterThan(initialNodeCount)
|
|
})
|
|
})
|
|
|
|
test('Load workflow from URL dropped onto Vue node', async ({
|
|
comfyPage
|
|
}) => {
|
|
const fakeUrl = 'https://example.com/workflow.png'
|
|
await comfyPage.page.route(fakeUrl, (route) =>
|
|
route.fulfill({
|
|
path: comfyPage.assetPath('workflowInMedia/workflow_itxt.png')
|
|
})
|
|
)
|
|
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
|
|
const initialNodeCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
|
|
const node = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
await expect.poll(() => node.boundingBox()).toBeTruthy()
|
|
const box = (await node.boundingBox())!
|
|
|
|
const dropPosition = {
|
|
x: box.x + box.width / 2,
|
|
y: box.y + box.height / 2
|
|
}
|
|
|
|
await comfyPage.dragDrop.dragAndDropURL(fakeUrl, {
|
|
dropPosition,
|
|
preserveNativePropagation: true
|
|
})
|
|
|
|
await comfyPage.page.waitForFunction(
|
|
(prevCount) => window.app!.graph.nodes.length !== prevCount,
|
|
initialNodeCount,
|
|
{ timeout: 10000 }
|
|
)
|
|
|
|
await expect
|
|
.poll(() => comfyPage.nodeOps.getGraphNodesCount())
|
|
.not.toBe(initialNodeCount)
|
|
})
|
|
}
|
|
)
|