mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
b22c646910
## Summary Add 26 E2E tests across 5 spec files covering high-impact, frequently-used UI flows: toast notifications, error overlay navigation, selection toolbox actions, linear mode layout, and selection rectangle multi-select. ## Tests | Spec file | Tests | Coverage | |---|---|---| | `toastNotifications.spec.ts` | 5 | Toast lifecycle, dismiss, severity levels | | `errorOverlaySeeErrors.spec.ts` | 6 | Error overlay → errors panel navigation flow | | `selectionToolboxActions.spec.ts` | 4 | Delete, info, convert-to-subgraph, multi-delete | | `linearMode.spec.ts` | 5 | Linear layout toggle, widget rendering, persistence | | `selectionRectangle.spec.ts` | 6 | Vue node multi-selection via rectangle drag | ## Review Focus - Selection toolbox tests use `force: true` clicks due to CSS transform positioning — is this acceptable or should we find a more robust approach? - 2 additional toolbox tests (bypass, refresh) were split to draft PR #9768 due to flaky CI visibility issues with `useSelectionToolboxPosition`. ## Stack Depends on #9554 for FeatureFlagHelper/QueueHelper infrastructure. - #9554: Test infrastructure helpers - **→ This PR**: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - #9556: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials --------- Co-authored-by: GitHub Action <action@github.com>
112 lines
3.3 KiB
TypeScript
112 lines
3.3 KiB
TypeScript
import type { Page } from '@playwright/test'
|
|
|
|
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Linear Mode', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function enterAppMode(comfyPage: {
|
|
page: Page
|
|
nextFrame: () => Promise<void>
|
|
}) {
|
|
// LinearControls requires hasOutputs to be true. Serialize the current
|
|
// graph, inject linearData with output node IDs, then reload so the
|
|
// appModeStore picks up the outputs via its activeWorkflow watcher.
|
|
await comfyPage.page.evaluate(async () => {
|
|
const graph = window.app!.graph
|
|
if (!graph) return
|
|
|
|
const outputNodeIds = graph.nodes
|
|
.filter(
|
|
(n: { type?: string }) =>
|
|
n.type === 'SaveImage' || n.type === 'PreviewImage'
|
|
)
|
|
.map((n: { id: number | string }) => String(n.id))
|
|
|
|
// Serialize, inject linearData, and reload to sync stores
|
|
const workflow = graph.serialize() as unknown as Record<string, unknown>
|
|
const extra = (workflow.extra ?? {}) as Record<string, unknown>
|
|
extra.linearData = { inputs: [], outputs: outputNodeIds }
|
|
workflow.extra = extra
|
|
await window.app!.loadGraphData(
|
|
workflow as unknown as Parameters<
|
|
NonNullable<typeof window.app>['loadGraphData']
|
|
>[0]
|
|
)
|
|
})
|
|
await comfyPage.nextFrame()
|
|
|
|
// Toggle to app mode via the command which sets canvasStore.linearMode
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.extensionManager.command.execute('Comfy.ToggleLinear')
|
|
})
|
|
await comfyPage.nextFrame()
|
|
}
|
|
|
|
async function enterGraphMode(comfyPage: {
|
|
page: Page
|
|
nextFrame: () => Promise<void>
|
|
}) {
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.extensionManager.command.execute('Comfy.ToggleLinear')
|
|
})
|
|
await comfyPage.nextFrame()
|
|
}
|
|
|
|
test('Displays linear controls when app mode active', async ({
|
|
comfyPage
|
|
}) => {
|
|
await enterAppMode(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-widgets"]')
|
|
).toBeVisible({ timeout: 5000 })
|
|
})
|
|
|
|
test('Run button visible in linear mode', async ({ comfyPage }) => {
|
|
await enterAppMode(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-run-button"]')
|
|
).toBeVisible({ timeout: 5000 })
|
|
})
|
|
|
|
test('Workflow info section visible', async ({ comfyPage }) => {
|
|
await enterAppMode(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-workflow-info"]')
|
|
).toBeVisible({ timeout: 5000 })
|
|
})
|
|
|
|
test('Returns to graph mode', async ({ comfyPage }) => {
|
|
await enterAppMode(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-widgets"]')
|
|
).toBeVisible({ timeout: 5000 })
|
|
|
|
await enterGraphMode(comfyPage)
|
|
|
|
await expect(comfyPage.canvas).toBeVisible({ timeout: 5000 })
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-widgets"]')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('Canvas not visible in app mode', async ({ comfyPage }) => {
|
|
await enterAppMode(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="linear-widgets"]')
|
|
).toBeVisible({ timeout: 5000 })
|
|
await expect(comfyPage.canvas).not.toBeVisible()
|
|
})
|
|
})
|