mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-04 21:22:07 +00:00
39e1877065
## Summary Skip the main e2e test suite on PRs that only touch unrelated paths (website, docs, storybook, markdown). ## Changes - **What**: Replace the broad `paths-ignore: ['**/*.md']` on the `pull_request` trigger with a more targeted `paths-ignore` list covering `apps/**`, `docs/**`, `**/*.md`, and `.storybook/**`. The `push` (to main), `merge_group`, and `workflow_dispatch` triggers remain unconditional. ## Review Focus - The `merge_group` trigger has no path filter, so the merge queue always runs e2e as a safety net before merge. - Using `paths-ignore` (denylist) rather than `paths` (allowlist) so new top-level directories trigger e2e by default. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11568-ci-filter-e2e-workflow-on-PRs-to-skip-unrelated-changes-34b6d73d365081ea8603ef94bc86b6e6) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
79 lines
3.3 KiB
YAML
79 lines
3.3 KiB
YAML
# Description: Deploys test results from forked PRs (forks can't access deployment secrets)
|
|
name: 'CI: Tests E2E (Deploy for Forks)'
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: ['CI: Tests E2E']
|
|
types: [requested, completed]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
deploy-and-comment-forked-pr:
|
|
runs-on: ubuntu-latest
|
|
if: |
|
|
github.repository == 'Comfy-Org/ComfyUI_frontend' &&
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
github.event.workflow_run.head_repository != null &&
|
|
github.event.workflow_run.repository != null &&
|
|
github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name
|
|
permissions:
|
|
pull-requests: write
|
|
actions: read
|
|
steps:
|
|
- name: Log workflow trigger info
|
|
run: |
|
|
echo "Repository: ${{ github.repository }}"
|
|
echo "Event: ${{ github.event.workflow_run.event }}"
|
|
echo "Head repo: ${{ github.event.workflow_run.head_repository.full_name || 'null' }}"
|
|
echo "Base repo: ${{ github.event.workflow_run.repository.full_name || 'null' }}"
|
|
echo "Is forked: ${{ github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name }}"
|
|
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Resolve PR from workflow_run context
|
|
id: pr
|
|
uses: ./.github/actions/resolve-pr-from-workflow-run
|
|
|
|
- name: Handle Test Start
|
|
if: steps.pr.outputs.skip != 'true' && github.event.action == 'requested'
|
|
env:
|
|
GITHUB_TOKEN: ${{ github.token }}
|
|
run: |
|
|
chmod +x scripts/cicd/pr-playwright-deploy-and-comment.sh
|
|
./scripts/cicd/pr-playwright-deploy-and-comment.sh \
|
|
"${{ steps.pr.outputs.number }}" \
|
|
"${{ github.event.workflow_run.head_branch }}" \
|
|
"starting"
|
|
|
|
- name: Download and Deploy Reports
|
|
if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed'
|
|
uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
|
|
with:
|
|
run_id: ${{ github.event.workflow_run.id }}
|
|
name: playwright-report-.*
|
|
name_is_regexp: true
|
|
path: reports
|
|
if_no_artifact_found: warn
|
|
|
|
- name: Handle Test Completion
|
|
if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && hashFiles('reports/**') != ''
|
|
env:
|
|
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
|
|
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
|
|
GITHUB_TOKEN: ${{ github.token }}
|
|
GITHUB_SHA: ${{ github.event.workflow_run.head_sha }}
|
|
run: |
|
|
# Rename merged report if exists
|
|
[ -d "reports/playwright-report-chromium-merged" ] && \
|
|
mv reports/playwright-report-chromium-merged reports/playwright-report-chromium
|
|
|
|
chmod +x scripts/cicd/pr-playwright-deploy-and-comment.sh
|
|
./scripts/cicd/pr-playwright-deploy-and-comment.sh \
|
|
"${{ steps.pr.outputs.number }}" \
|
|
"${{ github.event.workflow_run.head_branch }}" \
|
|
"completed"
|