mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-30 12:59:55 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
288 lines
7.7 KiB
TypeScript
288 lines
7.7 KiB
TypeScript
import { createPinia, setActivePinia } from 'pinia'
|
|
import { beforeEach, describe, expect, it } from 'vitest'
|
|
|
|
import { ServerConfig } from '@/constants/serverConfig'
|
|
import type { FormItem } from '@/platform/settings/types'
|
|
import { useServerConfigStore } from '@/stores/serverConfigStore'
|
|
|
|
const dummyFormItem: FormItem = {
|
|
name: '',
|
|
type: 'text'
|
|
}
|
|
|
|
describe('useServerConfigStore', () => {
|
|
let store: ReturnType<typeof useServerConfigStore>
|
|
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
store = useServerConfigStore()
|
|
})
|
|
|
|
it('should initialize with empty configs', () => {
|
|
expect(store.serverConfigs).toHaveLength(0)
|
|
expect(Object.keys(store.serverConfigById)).toHaveLength(0)
|
|
expect(Object.keys(store.serverConfigsByCategory)).toHaveLength(0)
|
|
expect(Object.keys(store.serverConfigValues)).toHaveLength(0)
|
|
expect(Object.keys(store.launchArgs)).toHaveLength(0)
|
|
})
|
|
|
|
it('should load server configs with default values', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1',
|
|
category: ['Test']
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {})
|
|
|
|
expect(store.serverConfigs).toHaveLength(2)
|
|
expect(store.serverConfigById['test.config1'].value).toBe('default1')
|
|
expect(store.serverConfigById['test.config2'].value).toBe('default2')
|
|
})
|
|
|
|
it('should load server configs with provided values', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1',
|
|
category: ['Test']
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': 'custom1'
|
|
})
|
|
|
|
expect(store.serverConfigs).toHaveLength(1)
|
|
expect(store.serverConfigById['test.config1'].value).toBe('custom1')
|
|
})
|
|
|
|
it('should organize configs by category', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1',
|
|
category: ['Test']
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2',
|
|
category: ['Other']
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config3',
|
|
defaultValue: 'default3'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {})
|
|
|
|
expect(Object.keys(store.serverConfigsByCategory)).toHaveLength(3)
|
|
expect(store.serverConfigsByCategory['Test']).toHaveLength(1)
|
|
expect(store.serverConfigsByCategory['Other']).toHaveLength(1)
|
|
expect(store.serverConfigsByCategory['General']).toHaveLength(1)
|
|
})
|
|
|
|
it('should generate server config values excluding defaults', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1'
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': 'custom1',
|
|
'test.config2': 'default2'
|
|
})
|
|
|
|
expect(Object.keys(store.serverConfigValues)).toHaveLength(2)
|
|
expect(store.serverConfigValues['test.config1']).toBe('custom1')
|
|
expect(store.serverConfigValues['test.config2']).toBeUndefined()
|
|
})
|
|
|
|
it('should generate launch arguments with custom getValue function', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1',
|
|
getValue: (value: string) => ({ customArg: value })
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': 'custom1',
|
|
'test.config2': 'custom2'
|
|
})
|
|
|
|
expect(Object.keys(store.launchArgs)).toHaveLength(2)
|
|
expect(store.launchArgs['customArg']).toBe('custom1')
|
|
expect(store.launchArgs['test.config2']).toBe('custom2')
|
|
})
|
|
|
|
it('should not include default values in launch arguments', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1'
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': 'custom1',
|
|
'test.config2': 'default2'
|
|
})
|
|
|
|
expect(Object.keys(store.launchArgs)).toHaveLength(1)
|
|
expect(store.launchArgs['test.config1']).toBe('custom1')
|
|
expect(store.launchArgs['test.config2']).toBeUndefined()
|
|
})
|
|
|
|
it('should not include nullish values in launch arguments', () => {
|
|
const configs: ServerConfig<any>[] = [
|
|
{ ...dummyFormItem, id: 'test.config1', defaultValue: 'default1' },
|
|
{ ...dummyFormItem, id: 'test.config2', defaultValue: 'default2' },
|
|
{ ...dummyFormItem, id: 'test.config3', defaultValue: 'default3' },
|
|
{ ...dummyFormItem, id: 'test.config4', defaultValue: null }
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': undefined,
|
|
'test.config2': null,
|
|
'test.config3': '',
|
|
'test.config4': 0
|
|
})
|
|
|
|
expect(Object.keys(store.launchArgs)).toEqual([
|
|
'test.config3',
|
|
'test.config4'
|
|
])
|
|
expect(Object.values(store.launchArgs)).toEqual(['', '0'])
|
|
expect(store.serverConfigById['test.config3'].value).toBe('')
|
|
expect(store.serverConfigById['test.config4'].value).toBe(0)
|
|
expect(Object.values(store.serverConfigValues)).toEqual([
|
|
undefined,
|
|
undefined,
|
|
'',
|
|
0
|
|
])
|
|
})
|
|
|
|
it('should convert true to empty string in launch arguments', () => {
|
|
store.loadServerConfig(
|
|
[
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 0
|
|
}
|
|
],
|
|
{
|
|
'test.config1': true
|
|
}
|
|
)
|
|
expect(store.launchArgs['test.config1']).toBe('')
|
|
expect(store.commandLineArgs).toBe('--test.config1')
|
|
})
|
|
|
|
it('should convert number to string in launch arguments', () => {
|
|
store.loadServerConfig(
|
|
[
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 1
|
|
}
|
|
],
|
|
{
|
|
'test.config1': 123
|
|
}
|
|
)
|
|
expect(store.launchArgs['test.config1']).toBe('123')
|
|
expect(store.commandLineArgs).toBe('--test.config1 123')
|
|
})
|
|
|
|
it('should drop nullish values in launch arguments', () => {
|
|
store.loadServerConfig(
|
|
[
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 1
|
|
}
|
|
],
|
|
{
|
|
'test.config1': null
|
|
}
|
|
)
|
|
expect(Object.keys(store.launchArgs)).toHaveLength(0)
|
|
})
|
|
|
|
it('should track modified configs', () => {
|
|
const configs = [
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config1',
|
|
defaultValue: 'default1'
|
|
},
|
|
{
|
|
...dummyFormItem,
|
|
id: 'test.config2',
|
|
defaultValue: 'default2'
|
|
}
|
|
]
|
|
|
|
store.loadServerConfig(configs, {
|
|
'test.config1': 'initial1'
|
|
})
|
|
|
|
// Initially no modified configs
|
|
expect(store.modifiedConfigs).toHaveLength(0)
|
|
|
|
// Modify config1's value after loading
|
|
store.serverConfigById['test.config1'].value = 'custom1'
|
|
|
|
// Now config1 should be in modified configs
|
|
expect(store.modifiedConfigs).toHaveLength(1)
|
|
expect(store.modifiedConfigs[0].id).toBe('test.config1')
|
|
expect(store.modifiedConfigs[0].value).toBe('custom1')
|
|
expect(store.modifiedConfigs[0].initialValue).toBe('initial1')
|
|
|
|
// Change config1 back to default
|
|
store.serverConfigById['test.config1'].value = 'initial1'
|
|
|
|
// Should go back to no modified configs
|
|
expect(store.modifiedConfigs).toHaveLength(0)
|
|
})
|
|
})
|