mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
78 lines
2.1 KiB
TypeScript
78 lines
2.1 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import { BaseDialog } from '@e2e/fixtures/components/BaseDialog'
|
|
|
|
export class SignInDialog extends BaseDialog {
|
|
readonly emailInput: Locator
|
|
readonly passwordInput: Locator
|
|
readonly signInButton: Locator
|
|
readonly forgotPasswordLink: Locator
|
|
readonly apiKeyButton: Locator
|
|
readonly termsLink: Locator
|
|
readonly privacyLink: Locator
|
|
|
|
constructor(page: Page) {
|
|
super(page)
|
|
this.emailInput = this.root.locator('#comfy-org-sign-in-email')
|
|
this.passwordInput = this.root.locator('#comfy-org-sign-in-password')
|
|
this.signInButton = this.root.getByRole('button', { name: 'Sign in' })
|
|
this.forgotPasswordLink = this.root.getByText('Forgot password?')
|
|
this.apiKeyButton = this.root.getByRole('button', {
|
|
name: 'Comfy API Key'
|
|
})
|
|
this.termsLink = this.root.getByRole('link', { name: 'Terms of Use' })
|
|
this.privacyLink = this.root.getByRole('link', { name: 'Privacy Policy' })
|
|
}
|
|
|
|
async open() {
|
|
await this.page.evaluate(() => {
|
|
void window.app!.extensionManager.dialog.showSignInDialog()
|
|
})
|
|
await this.waitForVisible()
|
|
}
|
|
|
|
get heading() {
|
|
return this.root.getByRole('heading').first()
|
|
}
|
|
|
|
get signUpLink() {
|
|
return this.root.getByText('Sign up', { exact: true })
|
|
}
|
|
|
|
get signInLink() {
|
|
return this.root.getByText('Sign in', { exact: true })
|
|
}
|
|
|
|
get signUpEmailInput() {
|
|
return this.root.locator('#comfy-org-sign-up-email')
|
|
}
|
|
|
|
get signUpPasswordInput() {
|
|
return this.root.locator('#comfy-org-sign-up-password')
|
|
}
|
|
|
|
get signUpConfirmPasswordInput() {
|
|
return this.root.locator('#comfy-org-sign-up-confirm-password')
|
|
}
|
|
|
|
get signUpButton() {
|
|
return this.root.getByRole('button', { name: 'Sign up', exact: true })
|
|
}
|
|
|
|
get apiKeyHeading() {
|
|
return this.root.getByRole('heading', { name: 'API Key' })
|
|
}
|
|
|
|
get apiKeyInput() {
|
|
return this.root.locator('#comfy-org-api-key')
|
|
}
|
|
|
|
get backButton() {
|
|
return this.root.getByRole('button', { name: 'Back' })
|
|
}
|
|
|
|
get dividerText() {
|
|
return this.root.getByText('Or continue with')
|
|
}
|
|
}
|