mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-05 05:32:02 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
111 lines
3.7 KiB
TypeScript
111 lines
3.7 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Node Library Essentials Tab', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
|
|
// Enable the essentials feature flag via the reactive serverFeatureFlags ref.
|
|
// In production, this flag comes via WebSocket or remoteConfig (cloud only).
|
|
// The localhost test server has neither, so we set it directly.
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.api.serverFeatureFlags.value = {
|
|
...window.app!.api.serverFeatureFlags.value,
|
|
node_library_essentials_enabled: true
|
|
}
|
|
})
|
|
|
|
// Register a mock essential node so the essentials tab has content.
|
|
await comfyPage.page.evaluate(() => {
|
|
return window.app!.registerNodeDef('TestEssentialNode', {
|
|
name: 'TestEssentialNode',
|
|
display_name: 'Test Essential Node',
|
|
category: 'essentials_test',
|
|
input: { required: {}, optional: {} },
|
|
output: ['IMAGE'],
|
|
output_name: ['image'],
|
|
output_is_list: [false],
|
|
output_node: false,
|
|
python_module: 'comfy_essentials.nodes',
|
|
description: 'Mock essential node for testing',
|
|
essentials_category: 'Image Generation'
|
|
})
|
|
})
|
|
})
|
|
|
|
test('Node library opens via sidebar', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const sidebarContent = comfyPage.page.locator(
|
|
'.comfy-vue-side-bar-container'
|
|
)
|
|
await expect(sidebarContent).toBeVisible()
|
|
})
|
|
|
|
test('Essentials tab is visible in node library', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await expect(essentialsTab).toBeVisible()
|
|
})
|
|
|
|
test('Clicking essentials tab shows essential node cards', async ({
|
|
comfyPage
|
|
}) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await essentialsTab.click()
|
|
|
|
const essentialCards = comfyPage.page.locator('[data-node-name]')
|
|
await expect(essentialCards.first()).toBeVisible()
|
|
})
|
|
|
|
test('Essential node cards have node names', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await essentialsTab.click()
|
|
|
|
const firstCard = comfyPage.page.locator('[data-node-name]').first()
|
|
await expect(firstCard).toBeVisible()
|
|
|
|
const nodeName = await firstCard.getAttribute('data-node-name')
|
|
expect(nodeName).toBeTruthy()
|
|
expect(nodeName!.length).toBeGreaterThan(0)
|
|
})
|
|
|
|
test('Node library can switch between all and essentials tabs', async ({
|
|
comfyPage
|
|
}) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
const allNodesTab = comfyPage.page.getByRole('tab', { name: /^all$/i })
|
|
|
|
await essentialsTab.click()
|
|
await expect(essentialsTab).toHaveAttribute('aria-selected', 'true')
|
|
const essentialCards = comfyPage.page.locator('[data-node-name]')
|
|
await expect(essentialCards.first()).toBeVisible()
|
|
|
|
await allNodesTab.click()
|
|
await expect(allNodesTab).toHaveAttribute('aria-selected', 'true')
|
|
await expect(essentialsTab).toHaveAttribute('aria-selected', 'false')
|
|
})
|
|
})
|