Files
ComfyUI_frontend/tests-ui/tests/composables/useConflictDetection.test.ts
2025-07-21 17:43:43 +09:00

865 lines
27 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { nextTick } from 'vue'
import { useConflictDetection } from '@/composables/useConflictDetection'
import type { components } from '@/types/comfyRegistryTypes'
import type { components as ManagerComponents } from '@/types/generatedManagerTypes'
// Mock dependencies
vi.mock('@/scripts/api', () => ({
api: {
fetchApi: vi.fn()
}
}))
vi.mock('@/services/comfyManagerService', () => ({
useComfyManagerService: vi.fn()
}))
vi.mock('@/services/comfyRegistryService', () => ({
useComfyRegistryService: vi.fn()
}))
vi.mock('@/stores/systemStatsStore', () => ({
useSystemStatsStore: vi.fn()
}))
vi.mock('@/config', () => ({
default: {
app_version: '1.24.0-1'
}
}))
describe('useConflictDetection with Registry Store', () => {
const mockComfyManagerService = {
listInstalledPacks: vi.fn()
}
const mockRegistryService = {
getPackByVersion: vi.fn()
}
const mockSystemStatsStore = {
fetchSystemStats: vi.fn(),
systemStats: {
system: {
comfyui_version: '0.3.41',
python_version: '3.12.11',
os: 'Darwin'
},
devices: [
{
name: 'Apple M1 Pro',
type: 'mps',
vram_total: 17179869184
}
]
} as any
}
beforeEach(async () => {
vi.clearAllMocks()
// Reset mock system stats to default state
mockSystemStatsStore.systemStats = {
system: {
comfyui_version: '0.3.41',
python_version: '3.12.11',
os: 'Darwin'
},
devices: [
{
name: 'Apple M1 Pro',
type: 'mps',
vram_total: 17179869184
}
]
} as any
// Reset mock functions
mockSystemStatsStore.fetchSystemStats.mockResolvedValue(undefined)
mockComfyManagerService.listInstalledPacks.mockReset()
mockRegistryService.getPackByVersion.mockReset()
// Mock useComfyManagerService
const { useComfyManagerService } = await import(
'@/services/comfyManagerService'
)
vi.mocked(useComfyManagerService).mockReturnValue(
mockComfyManagerService as any
)
// Mock useComfyRegistryService
const { useComfyRegistryService } = await import(
'@/services/comfyRegistryService'
)
vi.mocked(useComfyRegistryService).mockReturnValue(
mockRegistryService as any
)
// Mock useSystemStatsStore
const { useSystemStatsStore } = await import('@/stores/systemStatsStore')
vi.mocked(useSystemStatsStore).mockReturnValue(mockSystemStatsStore as any)
})
afterEach(() => {
vi.restoreAllMocks()
})
describe('system environment detection', () => {
it('should collect system environment information successfully', async () => {
const { detectSystemEnvironment } = useConflictDetection()
const environment = await detectSystemEnvironment()
expect(environment.comfyui_version).toBe('0.3.41')
expect(environment.frontend_version).toBe('1.24.0-1')
expect(environment.python_version).toBe('3.12.11')
expect(environment.available_accelerators).toContain('Metal')
expect(environment.available_accelerators).toContain('CPU')
expect(environment.primary_accelerator).toBe('Metal')
})
it('should return fallback environment information when systemStatsStore fails', async () => {
// Mock systemStatsStore failure
mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
new Error('Store failure')
)
mockSystemStatsStore.systemStats = null
const { detectSystemEnvironment } = useConflictDetection()
const environment = await detectSystemEnvironment()
expect(environment.comfyui_version).toBe('unknown')
expect(environment.frontend_version).toBe('1.24.0-1')
expect(environment.python_version).toBe('unknown')
expect(environment.available_accelerators).toEqual(['CPU'])
})
})
describe('package requirements detection with Registry Store', () => {
it('should fetch and combine local + Registry data successfully', async () => {
// Mock installed packages
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
'ComfyUI-Manager': {
ver: 'cb0fa5829d5378e5dddb8e8515b30a3ff20e1471',
cnr_id: '',
aux_id: 'viva-jinyi/ComfyUI-Manager',
enabled: true
},
'ComfyUI-TestNode': {
ver: '1.0.0',
cnr_id: 'test-node',
aux_id: null,
enabled: false
}
}
// Mock Registry data
const mockRegistryPacks: components['schemas']['Node'][] = [
{
id: 'ComfyUI-Manager',
name: 'ComfyUI Manager',
supported_os: ['Windows', 'Linux', 'macOS'],
supported_accelerators: ['CUDA', 'Metal', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node'],
{
id: 'ComfyUI-TestNode',
name: 'Test Node',
supported_os: ['Windows', 'Linux'],
supported_accelerators: ['CUDA'],
supported_comfyui_version: '>=0.2.0',
status: 'NodeStatusBanned'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
// Mock Registry Service individual calls
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockRegistryPacks.find(
(p) => p.id === packageName
)
if (packageData) {
return Promise.resolve({
...packageData,
supported_comfyui_version: packageData.supported_comfyui_version,
supported_os: packageData.supported_os,
supported_accelerators: packageData.supported_accelerators,
status: packageData.status
})
}
return Promise.resolve(null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.total_packages).toBe(2)
expect(result.results).toHaveLength(2)
// Verify individual calls were made
expect(mockRegistryService.getPackByVersion).toHaveBeenCalledWith(
'ComfyUI-Manager',
'cb0fa5829d5378e5dddb8e8515b30a3ff20e1471',
expect.anything()
)
expect(mockRegistryService.getPackByVersion).toHaveBeenCalledWith(
'ComfyUI-TestNode',
'1.0.0',
expect.anything()
)
// Check that Registry data was properly integrated
const managerNode = result.results.find(
(r) => r.package_id === 'ComfyUI-Manager'
)
expect(managerNode?.is_compatible).toBe(true) // Should be compatible
// Disabled + banned node should have conflicts
const testNode = result.results.find(
(r) => r.package_id === 'ComfyUI-TestNode'
)
expect(testNode?.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'banned',
severity: 'error'
})
])
)
})
it('should handle Registry Store failures gracefully', async () => {
// Mock installed packages
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
'Unknown-Package': {
ver: '1.0.0',
cnr_id: 'unknown',
aux_id: null,
enabled: true
}
}
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
// Mock Registry Service returning null (no packages found)
mockRegistryService.getPackByVersion.mockResolvedValue(null)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.total_packages).toBe(1)
expect(result.results).toHaveLength(1)
// Should have warning about missing Registry data
const unknownPackage = result.results[0]
expect(unknownPackage.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'security_pending',
severity: 'warning',
description: expect.stringContaining('Registry data not available')
})
])
)
})
it('should return empty array when local package information cannot be retrieved', async () => {
mockComfyManagerService.listInstalledPacks.mockResolvedValue(null)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.total_packages).toBe(0)
expect(result.results).toHaveLength(0)
})
})
describe('conflict detection logic with Registry Store', () => {
it('should detect no conflicts for fully compatible packages', async () => {
// Mock compatible package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
CompatibleNode: {
ver: '1.0.0',
cnr_id: 'compatible-node',
aux_id: null,
enabled: true
}
}
const mockCompatibleRegistryPacks: components['schemas']['Node'][] = [
{
id: 'CompatibleNode',
name: 'Compatible Node',
supported_os: ['Windows', 'Linux', 'macOS'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
// Mock Registry Service for compatible package
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockCompatibleRegistryPacks.find(
(p) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.conflicted_packages).toBe(0)
expect(result.summary.compatible_packages).toBe(1)
expect(result.results[0].conflicts).toHaveLength(0)
})
it('should detect OS incompatibility conflicts', async () => {
// Mock OS-incompatible package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
WindowsOnlyNode: {
ver: '1.0.0',
cnr_id: 'windows-only',
aux_id: null,
enabled: true
}
}
const mockWindowsOnlyRegistryPacks: components['schemas']['Node'][] = [
{
id: 'WindowsOnlyNode',
name: 'Windows Only Node',
supported_os: ['Windows'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockWindowsOnlyRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.conflicted_packages).toBe(1)
const windowsNode = result.results[0]
expect(windowsNode.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'os',
severity: 'error',
description: expect.stringContaining('Unsupported operating system')
})
])
)
})
it('should detect accelerator incompatibility conflicts', async () => {
// Mock CUDA-only package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
CudaOnlyNode: {
ver: '1.0.0',
cnr_id: 'cuda-only',
aux_id: null,
enabled: true
}
}
const mockCudaOnlyRegistryPacks: components['schemas']['Node'][] = [
{
id: 'CudaOnlyNode',
name: 'CUDA Only Node',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['CUDA'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockCudaOnlyRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.conflicted_packages).toBe(1)
const cudaNode = result.results[0]
expect(cudaNode.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'accelerator',
severity: 'error',
description: expect.stringContaining(
'Required GPU/accelerator not available'
)
})
])
)
})
it('should treat Registry-banned packages as conflicts', async () => {
// Mock Registry-banned package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
BannedNode: {
ver: '1.0.0',
cnr_id: 'banned-node',
aux_id: null,
enabled: true
}
}
const mockBannedRegistryPacks: components['schemas']['NodeVersion'][] = [
{
id: 'BannedNode',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeVersionStatusBanned'
} as components['schemas']['NodeVersion']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockBannedRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.banned_packages).toBe(1)
const bannedNode = result.results[0]
expect(bannedNode.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'banned',
severity: 'error',
description: expect.stringContaining('Package is banned')
})
])
)
expect(bannedNode.recommended_action.action_type).toBe('disable')
})
it('should treat locally disabled packages as banned', async () => {
// Mock locally disabled package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
DisabledNode: {
ver: '1.0.0',
cnr_id: 'disabled-node',
aux_id: null,
enabled: false
}
}
const mockActiveRegistryPacks: components['schemas']['Node'][] = [
{
id: 'DisabledNode',
name: 'Disabled Node',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockActiveRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.banned_packages).toBe(1)
const disabledNode = result.results[0]
expect(disabledNode.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'banned',
severity: 'error',
description: expect.stringContaining('Package is disabled locally')
})
])
)
expect(disabledNode.recommended_action.action_type).toBe('disable')
})
})
describe('computed properties with Registry Store', () => {
it('should return true for hasConflicts when Registry conflicts exist', async () => {
// Mock package with OS incompatibility
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
ConflictedNode: {
ver: '1.0.0',
cnr_id: 'conflicted-node',
aux_id: null,
enabled: true
}
}
const mockConflictedRegistryPacks: components['schemas']['Node'][] = [
{
id: 'ConflictedNode',
name: 'Conflicted Node',
supported_os: ['Windows'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockConflictedRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { hasConflicts, performConflictDetection } = useConflictDetection()
// Initial value should be false
expect(hasConflicts.value).toBe(false)
// Execute conflict detection
await performConflictDetection()
await nextTick()
// Should be true when conflicts are detected
expect(hasConflicts.value).toBe(true)
})
it('should return only error-level conflicts for criticalConflicts', async () => {
// Mock package with error-level conflict
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
ErrorNode: {
ver: '1.0.0',
cnr_id: 'error-node',
aux_id: null,
enabled: true
}
}
const mockErrorRegistryPacks: components['schemas']['Node'][] = [
{
id: 'ErrorNode',
name: 'Error Node',
supported_os: ['Windows'],
supported_accelerators: ['CUDA'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockErrorRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { criticalConflicts, performConflictDetection } =
useConflictDetection()
await performConflictDetection()
await nextTick()
expect(criticalConflicts.value.length).toBeGreaterThan(0)
expect(
criticalConflicts.value.every(
(conflict) => conflict.severity === 'error'
)
).toBe(true)
})
it('should return only banned packages for bannedPackages', async () => {
// Mock one banned and one normal package
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
BannedNode: {
ver: '1.0.0',
cnr_id: 'banned-node',
aux_id: null,
enabled: false
},
NormalNode: {
ver: '1.0.0',
cnr_id: 'normal-node',
aux_id: null,
enabled: true
}
}
const mockRegistryPacks: components['schemas']['Node'][] = [
{
id: 'BannedNode',
name: 'Banned Node',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node'],
{
id: 'NormalNode',
name: 'Normal Node',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
supported_comfyui_version: '>=0.3.0',
status: 'NodeStatusActive'
} as components['schemas']['Node']
]
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { bannedPackages, performConflictDetection } =
useConflictDetection()
await performConflictDetection()
await nextTick()
expect(bannedPackages.value).toHaveLength(1)
expect(bannedPackages.value[0].package_id).toBe('BannedNode')
})
})
describe('error resilience with Registry Store', () => {
it('should continue execution even when system environment detection fails', async () => {
// Mock system stats store failure
mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
new Error('Store error')
)
mockSystemStatsStore.systemStats = null
mockComfyManagerService.listInstalledPacks.mockResolvedValue({})
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = [].find((p: any) => p.id === packageName)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.detected_system_environment?.comfyui_version).toBe(
'unknown'
)
})
it('should continue system operation even when local package information fails', async () => {
// Mock local package service failure
mockComfyManagerService.listInstalledPacks.mockRejectedValue(
new Error('Service error')
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.total_packages).toBe(0)
})
it('should handle Registry Store partial data gracefully', async () => {
// Mock successful local data but partial Registry data
const mockInstalledPacks: ManagerComponents['schemas']['InstalledPacksResponse'] =
{
'Package-A': {
ver: '1.0.0',
cnr_id: 'a',
aux_id: null,
enabled: true
},
'Package-B': {
ver: '2.0.0',
cnr_id: 'b',
aux_id: null,
enabled: true
}
}
mockComfyManagerService.listInstalledPacks.mockResolvedValue(
mockInstalledPacks
)
// Only first package found in Registry / Registry에서 첫 번째 패키지만 찾음
const mockPartialRegistryPacks: components['schemas']['Node'][] = [
{
id: 'Package-A',
name: 'Package A',
supported_os: ['windows', 'linux', 'macos'],
supported_accelerators: ['Metal', 'CUDA', 'CPU'],
status: 'NodeStatusActive'
} as components['schemas']['Node']
// Package-B is missing from Registry results
]
mockRegistryService.getPackByVersion.mockImplementation(
(packageName: string) => {
const packageData = mockPartialRegistryPacks.find(
(p: any) => p.id === packageName
)
return Promise.resolve(packageData || null)
}
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true)
expect(result.summary.total_packages).toBe(2)
// Package A should have Registry data
const packageA = result.results.find((r) => r.package_id === 'Package-A')
expect(packageA?.conflicts).toHaveLength(0) // No conflicts
// Package B should have warning about missing Registry data
const packageB = result.results.find((r) => r.package_id === 'Package-B')
expect(packageB?.conflicts).toEqual(
expect.arrayContaining([
expect.objectContaining({
type: 'security_pending',
severity: 'warning',
description: expect.stringContaining('Registry data not available')
})
])
)
})
it('should handle complete system failure gracefully', async () => {
// Mock all stores/services failing
mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
new Error('Critical error')
)
mockSystemStatsStore.systemStats = null
mockComfyManagerService.listInstalledPacks.mockRejectedValue(
new Error('Critical error')
)
mockRegistryService.getPackByVersion.mockRejectedValue(
new Error('Critical error')
)
const { performConflictDetection } = useConflictDetection()
const result = await performConflictDetection()
expect(result.success).toBe(true) // Error resilience maintains success
expect(result.summary.total_packages).toBe(0)
})
})
describe('initialization', () => {
it('should execute initializeConflictDetection without errors', async () => {
mockComfyManagerService.listInstalledPacks.mockResolvedValue({})
const { initializeConflictDetection } = useConflictDetection()
expect(() => {
void initializeConflictDetection()
}).not.toThrow()
})
it('should set initial state values correctly', () => {
const {
isDetecting,
lastDetectionTime,
detectionError,
systemEnvironment,
detectionResults,
detectionSummary
} = useConflictDetection()
expect(isDetecting.value).toBe(false)
expect(lastDetectionTime.value).toBeNull()
expect(detectionError.value).toBeNull()
expect(systemEnvironment.value).toBeNull()
expect(detectionResults.value).toEqual([])
expect(detectionSummary.value).toBeNull()
})
})
})