Files
ComfyUI_frontend/src/stores/subgraphNavigationStore.test.ts
Dante c77c8a9476 test: migrate fromAny to fromPartial for type-checked test mocks (#10788)
## Summary
- Convert `fromAny` → `fromPartial` in 7 test files where object
literals or interfaces are passed
- `fromPartial` type-checks the provided fields, unlike `fromAny` which
bypasses all checking (same as `as unknown as`)
- Class-based types (`LGraphNode`, `LGraph`) remain `fromAny` due to
shoehorn's `PartialDeep` incompatibility with class constructors

## Changes
- **Pure conversions** (all `fromAny` → `fromPartial`):
`domWidgetZIndex`, `matchPromotedInput`, `promotionUtils`,
`subgraphNavigationStore`
- **Mixed** (some converted, some kept): `promotedWidgetView`,
`widgetUtil`
- **Cleanup**: `nodeOutputStore` type param normalization

Follows up on #10761.

## Test plan
- [x] `pnpm typecheck` passes
- [x] `pnpm vitest run` on all 7 changed files — 169 tests pass
- [x] `pnpm lint` passes

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10788-test-migrate-fromAny-to-fromPartial-for-type-checked-test-mocks-3356d73d365081f7bf61d48a47af530c)
by [Unito](https://www.unito.io)
2026-03-31 21:11:50 -07:00

264 lines
8.0 KiB
TypeScript

import { createTestingPinia } from '@pinia/testing'
import { fromPartial } from '@total-typescript/shoehorn'
import { setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { nextTick } from 'vue'
import type { Subgraph } from '@/lib/litegraph/src/LGraph'
import type { ComfyWorkflow } from '@/platform/workflow/management/stores/workflowStore'
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
import { app } from '@/scripts/app'
import { useSubgraphNavigationStore } from '@/stores/subgraphNavigationStore'
type MockSubgraph = Pick<Subgraph, 'id' | 'rootGraph' | '_nodes' | 'nodes'>
function createMockSubgraph(id: string, rootGraph = app.rootGraph): Subgraph {
const mockSubgraph = {
id,
rootGraph,
_nodes: [],
nodes: []
} satisfies MockSubgraph
return fromPartial<Subgraph>(mockSubgraph)
}
vi.mock('@/scripts/app', () => {
const mockCanvas = {
subgraph: null,
ds: {
scale: 1,
offset: [0, 0],
state: {
scale: 1,
offset: [0, 0]
}
},
setDirty: vi.fn()
}
const mockGraph = {
_nodes: [],
nodes: [],
subgraphs: new Map(),
getNodeById: vi.fn()
}
return {
app: {
graph: mockGraph,
rootGraph: mockGraph,
canvas: mockCanvas
}
}
})
vi.mock('@/renderer/core/canvas/canvasStore', () => ({
useCanvasStore: () => ({
getCanvas: () => app.canvas
})
}))
vi.mock('@/utils/graphTraversalUtil', () => ({
findSubgraphPathById: vi.fn()
}))
vi.mock('@vueuse/router', () => ({ useRouteHash: vi.fn() }))
describe('useSubgraphNavigationStore', () => {
beforeEach(() => {
setActivePinia(createTestingPinia({ stubActions: false }))
app.rootGraph.subgraphs.clear()
app.canvas.subgraph = undefined
app.canvas.ds.scale = 1
app.canvas.ds.offset = [0, 0]
app.canvas.ds.state.scale = 1
app.canvas.ds.state.offset = [0, 0]
app.graph.getNodeById = vi.fn()
vi.resetAllMocks()
})
it('should not clear navigation stack when workflow internal state changes', async () => {
const navigationStore = useSubgraphNavigationStore()
const workflowStore = useWorkflowStore()
// Mock a workflow
const mockWorkflow = {
path: 'test-workflow.json',
filename: 'test-workflow.json',
changeTracker: null
} as ComfyWorkflow
// Set the active workflow (cast to bypass TypeScript check in test)
workflowStore.activeWorkflow =
mockWorkflow as typeof workflowStore.activeWorkflow
// Simulate being in a subgraph by restoring state
navigationStore.restoreState(['subgraph-1', 'subgraph-2'])
expect(navigationStore.exportState()).toHaveLength(2)
// Simulate a change to the workflow's internal state
// (e.g., changeTracker.activeState being reassigned)
mockWorkflow.changeTracker = {
activeState: {}
} as typeof mockWorkflow.changeTracker
// The navigation stack should NOT be cleared because the path hasn't changed
expect(navigationStore.exportState()).toHaveLength(2)
expect(navigationStore.exportState()).toEqual(['subgraph-1', 'subgraph-2'])
})
it('should preserve navigation stack per workflow', async () => {
const navigationStore = useSubgraphNavigationStore()
const workflowStore = useWorkflowStore()
const { findSubgraphPathById } = await import('@/utils/graphTraversalUtil')
const workflow1 = {
path: 'workflow1.json',
filename: 'workflow1.json'
} as ComfyWorkflow
const workflow2 = {
path: 'workflow2.json',
filename: 'workflow2.json'
} as ComfyWorkflow
const sub1 = createMockSubgraph('sub-1')
const sub2 = createMockSubgraph('sub-2')
app.rootGraph.subgraphs.set(sub1.id, sub1)
app.rootGraph.subgraphs.set(sub2.id, sub2)
vi.mocked(findSubgraphPathById).mockImplementation((_rootGraph, id) => {
if (id === sub1.id) return [sub1.id]
if (id === sub2.id) return [sub1.id, sub2.id]
return null
})
// Workflow1 is in a nested subgraph (sub-1 -> sub-2)
app.canvas.subgraph = sub2
workflowStore.activeWorkflow =
workflow1 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([sub1.id, sub2.id])
// Switch to workflow2 at root level
app.canvas.subgraph = undefined
workflowStore.activeWorkflow =
workflow2 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([])
// Switch back to workflow1 in its subgraph
app.canvas.subgraph = sub2
workflowStore.activeWorkflow =
workflow1 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([sub1.id, sub2.id])
})
it('should reset navigation on workflow switch and restore on switch back', async () => {
const navigationStore = useSubgraphNavigationStore()
const workflowStore = useWorkflowStore()
const { findSubgraphPathById } = await import('@/utils/graphTraversalUtil')
const workflow1 = {
path: 'workflow1.json',
filename: 'workflow1.json'
} as ComfyWorkflow
const workflow1Subgraph = createMockSubgraph('sub-1')
app.rootGraph.subgraphs.set(workflow1Subgraph.id, workflow1Subgraph)
vi.mocked(findSubgraphPathById).mockImplementation((_rootGraph, id) =>
id === workflow1Subgraph.id ? [workflow1Subgraph.id] : null
)
app.canvas.subgraph = workflow1Subgraph
workflowStore.activeWorkflow =
workflow1 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([workflow1Subgraph.id])
const workflow2 = {
path: 'workflow2.json',
filename: 'workflow2.json'
} as ComfyWorkflow
app.canvas.subgraph = undefined
workflowStore.activeWorkflow =
workflow2 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([])
app.canvas.subgraph = workflow1Subgraph
workflowStore.activeWorkflow =
workflow1 as typeof workflowStore.activeWorkflow
await nextTick()
expect(navigationStore.exportState()).toEqual([workflow1Subgraph.id])
})
it('should handle restoreState with unreachable subgraph IDs', () => {
const navigationStore = useSubgraphNavigationStore()
navigationStore.restoreState(['nonexistent-sub'])
expect(navigationStore.exportState()).toEqual(['nonexistent-sub'])
expect(navigationStore.navigationStack).toEqual([])
})
it('should clear navigation when activeSubgraph becomes undefined', async () => {
const navigationStore = useSubgraphNavigationStore()
const workflowStore = useWorkflowStore()
const { findSubgraphPathById } = await import('@/utils/graphTraversalUtil')
// Create mock subgraph and graph structure
const mockSubgraph = createMockSubgraph('subgraph-1', app.graph)
// Add the subgraph to the graph's subgraphs map
app.graph.subgraphs.set('subgraph-1', mockSubgraph)
// First set an active workflow
const mockWorkflow = {
path: 'test-workflow.json',
filename: 'test-workflow.json'
} as ComfyWorkflow
workflowStore.activeWorkflow =
mockWorkflow as typeof workflowStore.activeWorkflow
// Mock findSubgraphPathById to return the correct path
vi.mocked(findSubgraphPathById).mockReturnValue(['subgraph-1'])
// Set canvas.subgraph and trigger update to set activeSubgraph
app.canvas.subgraph = mockSubgraph
workflowStore.updateActiveGraph()
// Wait for Vue's reactivity to process the change
await nextTick()
// Verify navigation was set by the watcher
expect(navigationStore.exportState()).toHaveLength(1)
expect(navigationStore.exportState()).toEqual(['subgraph-1'])
// Clear canvas.subgraph and trigger update (simulating navigating back to root)
app.canvas.subgraph = undefined
workflowStore.updateActiveGraph()
// Wait for Vue's reactivity to process the change
await nextTick()
// Stack should be cleared when activeSubgraph becomes undefined
expect(navigationStore.exportState()).toHaveLength(0)
})
})