ComfyUI_frontend

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-06-28 10:37:16 +00:00

Files

DrJKL 974975c722 fix: harden NodeId boundaries against strict asNodeId

Address CodeRabbit review on the branded-number NodeId refactor:

- Add non-throwing tryAsNodeId / tryStripGraphPrefix helpers and use them at
  untrusted boundaries (clipboard paste remap, link-drop, slot-hover, widget
  processing) so invalid metadata is skipped instead of crashing.
- Use nullish checks for numeric NodeId guards so node id 0 is handled.
- Constrain last_node_id to a non-negative integer.
- Drop unsound Record<NodeId, NodeError> casts; key node errors by string.
- Normalize the 'executing' event payload via asNodeExecutionId.
- Brand storeJob node keys as NodeExecutionId.
- Restore layoutStore currentSource via try/finally.
- Clarify isNodeExecutionId JSDoc and ADR 0008 NodeId primitive.
- Fix tests comparing/keying NodeId values as strings.

Amp-Thread-ID: https://ampcode.com/threads/T-019edd35-b5b0-7048-be21-c704ce1e46ef
Co-authored-by: Amp <amp@ampcode.com>

2026-06-18 18:05:56 -07:00

adr

fix: harden NodeId boundaries against strict asNodeId

2026-06-18 18:05:56 -07:00

architecture

docs: ECS pattern survey appendix + PromotionStore cleanup (#12580 )

2026-06-02 00:25:34 -07:00

extensions

feat: remove deprecated group nodes, auto-convert to subgraphs on load (#12931 )

2026-06-18 21:16:24 +00:00

guidance

chore: One more unnecessary -- (#12468 )