mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-06-28 18:47:16 +00:00
4f60d09420
## Summary - Merges the separate Playwright and Storybook bot comments into the existing `<!-- COMFYUI_FRONTEND_PR_REPORT -->` unified comment, using named sections via `upsert-comment-section` - Each workflow independently upserts its own section without clobbering others - `pr-report.yaml` cleans up legacy `<!-- PLAYWRIGHT_TEST_STATUS -->` and `<!-- STORYBOOK_BUILD_STATUS -->` comments on first run - Perf report: collapses detailed metric tables in `<details>` by default — only headline FPS/TBT/heap summary and a brief regression count are visible inline ## Before → After **Before:** 4–5 separate bot comments per PR (Playwright, Storybook, Bundle/Perf/Coverage, Chromatic URLs) + CodeRabbit + Codecov **After:** 1 unified comment with collapsible sections: ``` <!-- COMFYUI_FRONTEND_PR_REPORT --> <!-- section:playwright:start --> ... <!-- section:playwright:end --> <!-- section:storybook:start --> ... <!-- section:storybook:end --> <!-- section:ci-metrics:start --> ... <!-- section:ci-metrics:end --> <!-- section:chromatic:start --> ... <!-- section:chromatic:end --> ``` (CodeRabbit and Codecov are external and can't be merged) ## How it works `upsert-comment-section` already existed for the website CI comment. This PR extends that pattern to the main PR report comment: 1. **Playwright** — shell script writes to `SUMMARY_FILE` when set, CI workflow uses `upsert-comment-section` with `section-name: playwright` 2. **Storybook** — same pattern, `section-name: storybook` 3. **Bundle/Perf/Coverage** — `pr-report.yaml` now also uses `upsert-comment-section` instead of replacing the whole comment, `section-name: ci-metrics` 4. **Chromatic** — `section-name: chromatic`, no script change needed Both fork and non-fork PR paths updated. ## Perf report noise fix Previously the full per-metric regression table was shown inline. Now: - **Visible:** headline summary (avg FPS, P5 FPS, TBT, heap per test) + "⚠️ N regressions detected" count - **Collapsed by default:** regression detail table, all-metrics table, historical variance, trend data ## Test plan - [ ] Open a PR with frontend changes — confirm single unified bot comment appears - [ ] Confirm Playwright section appears with ⏳ then updates to results - [ ] Confirm Storybook section appears only when storybook-relevant files change - [ ] Confirm legacy standalone Playwright/Storybook comments are deleted by `pr-report.yaml` - [ ] Confirm perf report shows headline only, details collapsed - [ ] Test with a fork PR — confirm fork path also works 🤖 Generated with [Claude Code](https://claude.ai/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11935-ci-consolidate-PR-bot-comments-into-one-unified-comment-3566d73d36508173964cdf596cfae1f8) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org>