mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-16 08:49:09 +00:00
c304f206a6
## Problem The **CI: E2E Coverage** `merge` job fails in the *Generate HTML coverage report* step ([example run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/28051468752)): ``` genhtml: ERROR: localhost-8188/assets/nodeDefs-BNhq_6cm.js is not readable or doesn't exist. ##[error]Process completed with exit code 1. ``` V8/Playwright coverage records scripts the test server serves at `localhost-8188/assets/*.js` (built bundles), which are not source files on disk. `genhtml` aborts on the missing source even with `--ignore-errors source`, so the whole job fails. ## Change Add a *Strip non-source entries from coverage* step that runs `lcov --remove '*localhost-8188*'` on the merged lcov. It is placed **after** the data-loss validation (so the merged-vs-shard integrity check stays consistent) and **before** the Codecov upload and genhtml — which also makes the Codecov report more accurate, since those served bundles aren't repo source. ## Validation - YAML parses cleanly; pre-commit lint/format/typecheck pass. - The removed paths are non-source served assets only; real `src/**` entries (absolute paths under the repo workspace) are untouched by the `*localhost-8188*` pattern. - `--ignore-errors unused` guards against runs where no such entries exist.
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.