mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Enable `better-tailwindcss/enforce-canonical-classes` lint rule and auto-fix all 611 violations across 173 files. Stacked on #9417. ## Changes - **What**: Simplify Tailwind classes to canonical forms via `eslint --fix`: - `h-X w-X` → `size-X` - `overflow-x-hidden overflow-y-hidden` → `overflow-hidden` - and other canonical simplifications - Enable `enforce-canonical-classes` as `'error'` in eslint config ## Review Focus Mechanical auto-fix PR — all changes produced by `eslint --fix`. No visual or behavioral changes; canonical forms are functionally identical. **Stack:** #9417 → **this PR** → PR 3 (class order) Fixes #9300 (partial — 2 of 3 rules) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9427-fix-enable-enforce-canonical-classes-tailwind-lint-rule-31a6d73d365081a49340d7d4640ede45) by [Unito](https://www.unito.io)
209 lines
5.6 KiB
Vue
209 lines
5.6 KiB
Vue
<template>
|
|
<a
|
|
ref="wrapperRef"
|
|
v-tooltip.bottom="{
|
|
value: tooltipText,
|
|
showDelay: 512
|
|
}"
|
|
draggable="false"
|
|
href="#"
|
|
class="p-breadcrumb-item-link h-8 cursor-pointer px-2"
|
|
:class="{
|
|
'flex items-center gap-1': isActive,
|
|
'p-breadcrumb-item-link-menu-visible': menu?.overlayVisible,
|
|
'p-breadcrumb-item-link-icon-visible': isActive,
|
|
'active-breadcrumb-item': isActive
|
|
}"
|
|
@click="handleClick"
|
|
>
|
|
<i
|
|
v-if="hasMissingNodes && isRoot"
|
|
class="icon-[lucide--triangle-alert] text-warning-background"
|
|
/>
|
|
<span class="p-breadcrumb-item-label px-2">{{ item.label }}</span>
|
|
<Tag v-if="item.isBlueprint" value="Blueprint" severity="primary" />
|
|
<i v-if="isActive" class="pi pi-angle-down text-[10px]"></i>
|
|
</a>
|
|
<Menu
|
|
v-if="isActive || isRoot"
|
|
ref="menu"
|
|
:model="menuItems"
|
|
:popup="true"
|
|
:pt="{
|
|
root: {
|
|
style: 'background-color: var(--comfy-menu-bg)'
|
|
},
|
|
itemLink: {
|
|
class: 'py-2'
|
|
}
|
|
}"
|
|
/>
|
|
<InputText
|
|
v-if="isEditing"
|
|
ref="itemInputRef"
|
|
v-model="itemLabel"
|
|
class="fixed z-10000 p-2 text-[.8rem]"
|
|
@blur="inputBlur(false)"
|
|
@click.stop
|
|
@keydown.enter="inputBlur(true)"
|
|
@keydown.esc="inputBlur(false)"
|
|
/>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import InputText from 'primevue/inputtext'
|
|
import type { MenuState } from 'primevue/menu'
|
|
import Menu from 'primevue/menu'
|
|
import type { MenuItem } from 'primevue/menuitem'
|
|
import Tag from 'primevue/tag'
|
|
import { computed, nextTick, ref } from 'vue'
|
|
import { useI18n } from 'vue-i18n'
|
|
|
|
import { useWorkflowActionsMenu } from '@/composables/useWorkflowActionsMenu'
|
|
import { ensureWorkflowSuffix, getWorkflowSuffix } from '@/utils/formatUtil'
|
|
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
|
|
import {
|
|
ComfyWorkflow,
|
|
useWorkflowStore
|
|
} from '@/platform/workflow/management/stores/workflowStore'
|
|
import { app } from '@/scripts/app'
|
|
import { useDialogService } from '@/services/dialogService'
|
|
import { useCommandStore } from '@/stores/commandStore'
|
|
import { useNodeDefStore } from '@/stores/nodeDefStore'
|
|
import { useSubgraphNavigationStore } from '@/stores/subgraphNavigationStore'
|
|
import { graphHasMissingNodes } from '@/workbench/extensions/manager/utils/graphHasMissingNodes'
|
|
|
|
interface Props {
|
|
item: MenuItem
|
|
isActive?: boolean
|
|
}
|
|
|
|
const { item, isActive } = defineProps<Props>()
|
|
|
|
const nodeDefStore = useNodeDefStore()
|
|
const hasMissingNodes = computed(() =>
|
|
graphHasMissingNodes(app.rootGraph, nodeDefStore.nodeDefsByName)
|
|
)
|
|
|
|
const { t } = useI18n()
|
|
const menu = ref<InstanceType<typeof Menu> & MenuState>()
|
|
const dialogService = useDialogService()
|
|
const workflowStore = useWorkflowStore()
|
|
const workflowService = useWorkflowService()
|
|
const isEditing = ref(false)
|
|
const itemLabel = ref<string>()
|
|
const itemInputRef = ref<{ $el?: HTMLInputElement }>()
|
|
const wrapperRef = ref<HTMLAnchorElement>()
|
|
|
|
const rename = async (
|
|
newName: string | null | undefined,
|
|
initialName: string
|
|
) => {
|
|
if (newName && newName !== initialName) {
|
|
// Synchronize the node titles with the new name
|
|
item.updateTitle?.(newName)
|
|
|
|
if (workflowStore.activeSubgraph) {
|
|
workflowStore.activeSubgraph.name = newName
|
|
} else if (workflowStore.activeWorkflow) {
|
|
try {
|
|
const suffix = getWorkflowSuffix(workflowStore.activeWorkflow.suffix)
|
|
await workflowService.renameWorkflow(
|
|
workflowStore.activeWorkflow,
|
|
ComfyWorkflow.basePath + ensureWorkflowSuffix(newName, suffix)
|
|
)
|
|
} catch (error) {
|
|
console.error(error)
|
|
dialogService.showErrorDialog(error)
|
|
return
|
|
}
|
|
}
|
|
|
|
// Force the navigation stack to recompute the labels
|
|
// TODO: investigate if there is a better way to do this
|
|
const navigationStore = useSubgraphNavigationStore()
|
|
navigationStore.restoreState(navigationStore.exportState())
|
|
}
|
|
}
|
|
|
|
const isRoot = item.key === 'root'
|
|
|
|
const tooltipText = computed(() => {
|
|
if (hasMissingNodes.value && isRoot) {
|
|
return t('breadcrumbsMenu.missingNodesWarning')
|
|
}
|
|
return item.label
|
|
})
|
|
|
|
const startRename = async () => {
|
|
// Check if element is hidden (collapsed breadcrumb)
|
|
// When collapsed, root item is hidden via CSS display:none, so use rename command
|
|
if (isRoot && wrapperRef.value?.offsetParent === null) {
|
|
await useCommandStore().execute('Comfy.RenameWorkflow')
|
|
return
|
|
}
|
|
|
|
isEditing.value = true
|
|
itemLabel.value = item.label as string
|
|
void nextTick(() => {
|
|
if (itemInputRef.value?.$el) {
|
|
itemInputRef.value.$el.focus()
|
|
itemInputRef.value.$el.select()
|
|
if (wrapperRef.value) {
|
|
itemInputRef.value.$el.style.width = `${Math.max(200, wrapperRef.value.offsetWidth)}px`
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
const { menuItems } = useWorkflowActionsMenu(startRename, { isRoot })
|
|
|
|
const handleClick = (event: MouseEvent) => {
|
|
if (isEditing.value) {
|
|
return
|
|
}
|
|
|
|
if (event.detail === 1) {
|
|
if (isActive) {
|
|
menu.value?.toggle(event)
|
|
} else {
|
|
item.command?.({ item: item, originalEvent: event })
|
|
}
|
|
} else if (isActive && event.detail === 2) {
|
|
menu.value?.hide()
|
|
event.stopPropagation()
|
|
event.preventDefault()
|
|
startRename()
|
|
}
|
|
}
|
|
|
|
const inputBlur = async (doRename: boolean) => {
|
|
if (doRename) {
|
|
await rename(itemLabel.value, item.label as string)
|
|
}
|
|
|
|
isEditing.value = false
|
|
}
|
|
</script>
|
|
|
|
<style scoped>
|
|
.p-breadcrumb-item-link,
|
|
.p-breadcrumb-item-icon {
|
|
user-select: none;
|
|
}
|
|
|
|
.p-breadcrumb-item-link {
|
|
overflow: hidden;
|
|
}
|
|
|
|
.p-breadcrumb-item-label {
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.active-breadcrumb-item {
|
|
color: var(--text-primary);
|
|
}
|
|
</style>
|