mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
## Summary Pass target tier to billing portal API for deep linking to Stripe's subscription update confirmation screen when user has an active subscription. ## Changes - **What**: When a user with an active subscription clicks a tier in PricingTable, pass the target tier (including billing cycle) to `accessBillingPortal` which sends it as `target_tier` in the request body. This enables the backend to create a Stripe billing portal deep link directly to the subscription update confirmation screen. - **Dependencies**: Requires comfy-api PR for `POST /customers/billing` `target_tier` support ## Review Focus - PricingTable now differentiates between new subscriptions (checkout flow) and existing subscriptions (billing portal with deep link) - Type derivation uses `Parameters<typeof authStore.accessBillingPortal>[0]` to avoid duplicating the tier union (matches codebase pattern) - Registry types manually updated to include `target_tier` field (will be regenerated when API is deployed) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7692-feat-pass-target-tier-to-billing-portal-for-subscription-updates-2d06d73d365081b38fe4c81e95dce58c) by [Unito](https://www.unito.io) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com>
238 lines
6.8 KiB
TypeScript
238 lines
6.8 KiB
TypeScript
import { createTestingPinia } from '@pinia/testing'
|
|
import { flushPromises, mount } from '@vue/test-utils'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { computed, ref } from 'vue'
|
|
import { createI18n } from 'vue-i18n'
|
|
|
|
import PricingTable from '@/platform/cloud/subscription/components/PricingTable.vue'
|
|
|
|
const mockIsActiveSubscription = ref(false)
|
|
const mockSubscriptionTier = ref<
|
|
'STANDARD' | 'CREATOR' | 'PRO' | 'FOUNDERS_EDITION' | null
|
|
>(null)
|
|
const mockIsYearlySubscription = ref(false)
|
|
const mockAccessBillingPortal = vi.fn()
|
|
const mockReportError = vi.fn()
|
|
const mockGetAuthHeader = vi.fn(() =>
|
|
Promise.resolve({ Authorization: 'Bearer test-token' })
|
|
)
|
|
|
|
vi.mock('@/platform/cloud/subscription/composables/useSubscription', () => ({
|
|
useSubscription: () => ({
|
|
isActiveSubscription: computed(() => mockIsActiveSubscription.value),
|
|
subscriptionTier: computed(() => mockSubscriptionTier.value),
|
|
isYearlySubscription: computed(() => mockIsYearlySubscription.value)
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/composables/auth/useFirebaseAuthActions', () => ({
|
|
useFirebaseAuthActions: () => ({
|
|
accessBillingPortal: mockAccessBillingPortal,
|
|
reportError: mockReportError
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/composables/useErrorHandling', () => ({
|
|
useErrorHandling: () => ({
|
|
wrapWithErrorHandlingAsync: vi.fn(
|
|
(fn, errorHandler) =>
|
|
async (...args: unknown[]) => {
|
|
try {
|
|
return await fn(...args)
|
|
} catch (error) {
|
|
if (errorHandler) {
|
|
errorHandler(error)
|
|
}
|
|
throw error
|
|
}
|
|
}
|
|
)
|
|
})
|
|
}))
|
|
|
|
vi.mock('@/stores/firebaseAuthStore', () => ({
|
|
useFirebaseAuthStore: () => ({
|
|
getAuthHeader: mockGetAuthHeader
|
|
}),
|
|
FirebaseAuthStoreError: class extends Error {}
|
|
}))
|
|
|
|
vi.mock('@/platform/distribution/types', () => ({
|
|
isCloud: true
|
|
}))
|
|
|
|
global.fetch = vi.fn()
|
|
|
|
const i18n = createI18n({
|
|
legacy: false,
|
|
locale: 'en',
|
|
messages: {
|
|
en: {
|
|
subscription: {
|
|
yearly: 'Yearly',
|
|
monthly: 'Monthly',
|
|
mostPopular: 'Most Popular',
|
|
usdPerMonth: '/ month',
|
|
billedYearly: 'Billed yearly ({total})',
|
|
billedMonthly: 'Billed monthly',
|
|
currentPlan: 'Current Plan',
|
|
subscribeTo: 'Subscribe to {plan}',
|
|
changeTo: 'Change to {plan}',
|
|
maxDuration: {
|
|
standard: '30 min',
|
|
creator: '30 min',
|
|
pro: '1 hr'
|
|
},
|
|
tiers: {
|
|
standard: { name: 'Standard' },
|
|
creator: { name: 'Creator' },
|
|
pro: { name: 'Pro' }
|
|
},
|
|
benefits: {
|
|
monthlyCredits: '{credits} monthly credits',
|
|
maxDuration: '{duration} max duration',
|
|
gpu: 'RTX 6000 Pro GPU',
|
|
addCredits: 'Add more credits anytime',
|
|
customLoRAs: 'Import custom LoRAs'
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
function createWrapper() {
|
|
return mount(PricingTable, {
|
|
global: {
|
|
plugins: [createTestingPinia({ createSpy: vi.fn }), i18n],
|
|
stubs: {
|
|
SelectButton: {
|
|
template: '<div><slot /></div>',
|
|
props: ['modelValue', 'options'],
|
|
emits: ['update:modelValue']
|
|
},
|
|
Popover: { template: '<div><slot /></div>' },
|
|
Button: {
|
|
template:
|
|
'<button @click="$emit(\'click\')" :disabled="disabled" :data-tier="dataTier">{{ label }}</button>',
|
|
props: ['loading', 'label', 'severity', 'disabled', 'dataTier', 'pt'],
|
|
emits: ['click']
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
describe('PricingTable', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockIsActiveSubscription.value = false
|
|
mockSubscriptionTier.value = null
|
|
mockIsYearlySubscription.value = false
|
|
vi.mocked(global.fetch).mockResolvedValue({
|
|
ok: true,
|
|
json: async () => ({ checkout_url: 'https://checkout.stripe.com/test' })
|
|
} as Response)
|
|
})
|
|
|
|
describe('billing portal deep linking', () => {
|
|
it('should call accessBillingPortal with yearly tier suffix when billing cycle is yearly (default)', async () => {
|
|
mockIsActiveSubscription.value = true
|
|
mockSubscriptionTier.value = 'STANDARD'
|
|
|
|
const wrapper = createWrapper()
|
|
await flushPromises()
|
|
|
|
const creatorButton = wrapper
|
|
.findAll('button')
|
|
.find((btn) => btn.text().includes('Creator'))
|
|
|
|
expect(creatorButton).toBeDefined()
|
|
await creatorButton?.trigger('click')
|
|
await flushPromises()
|
|
|
|
expect(mockAccessBillingPortal).toHaveBeenCalledWith('creator-yearly')
|
|
})
|
|
|
|
it('should call accessBillingPortal with different tiers correctly', async () => {
|
|
mockIsActiveSubscription.value = true
|
|
mockSubscriptionTier.value = 'STANDARD'
|
|
|
|
const wrapper = createWrapper()
|
|
await flushPromises()
|
|
|
|
const proButton = wrapper
|
|
.findAll('button')
|
|
.find((btn) => btn.text().includes('Pro'))
|
|
|
|
await proButton?.trigger('click')
|
|
await flushPromises()
|
|
|
|
expect(mockAccessBillingPortal).toHaveBeenCalledWith('pro-yearly')
|
|
})
|
|
|
|
it('should not call accessBillingPortal when clicking current plan', async () => {
|
|
mockIsActiveSubscription.value = true
|
|
mockSubscriptionTier.value = 'CREATOR'
|
|
|
|
const wrapper = createWrapper()
|
|
await flushPromises()
|
|
|
|
const currentPlanButton = wrapper
|
|
.findAll('button')
|
|
.find((btn) => btn.text().includes('Current Plan'))
|
|
|
|
await currentPlanButton?.trigger('click')
|
|
await flushPromises()
|
|
|
|
expect(mockAccessBillingPortal).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should initiate checkout instead of billing portal for new subscribers', async () => {
|
|
mockIsActiveSubscription.value = false
|
|
|
|
const windowOpenSpy = vi
|
|
.spyOn(window, 'open')
|
|
.mockImplementation(() => null)
|
|
|
|
const wrapper = createWrapper()
|
|
await flushPromises()
|
|
|
|
const subscribeButton = wrapper
|
|
.findAll('button')
|
|
.find((btn) => btn.text().includes('Subscribe'))
|
|
|
|
await subscribeButton?.trigger('click')
|
|
await flushPromises()
|
|
|
|
expect(mockAccessBillingPortal).not.toHaveBeenCalled()
|
|
expect(global.fetch).toHaveBeenCalledWith(
|
|
expect.stringContaining('/customers/cloud-subscription-checkout/'),
|
|
expect.any(Object)
|
|
)
|
|
expect(windowOpenSpy).toHaveBeenCalledWith(
|
|
'https://checkout.stripe.com/test',
|
|
'_blank'
|
|
)
|
|
|
|
windowOpenSpy.mockRestore()
|
|
})
|
|
|
|
it('should pass correct tier for each subscription level', async () => {
|
|
mockIsActiveSubscription.value = true
|
|
mockSubscriptionTier.value = 'PRO'
|
|
|
|
const wrapper = createWrapper()
|
|
await flushPromises()
|
|
|
|
const standardButton = wrapper
|
|
.findAll('button')
|
|
.find((btn) => btn.text().includes('Standard'))
|
|
|
|
await standardButton?.trigger('click')
|
|
await flushPromises()
|
|
|
|
expect(mockAccessBillingPortal).toHaveBeenCalledWith('standard-yearly')
|
|
})
|
|
})
|
|
})
|