mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-27 10:14:06 +00:00
## Summary Remove Tailwind `@apply` from Vue styles across `src/` and `apps/desktop-ui/src/` to align with Tailwind v4 guidance, replacing usages with template utilities or native CSS while preserving behavior. ## Changes - **What**: - Batch 1: migrated low-risk template/style utility bundles out of `@apply`. - Batch 2: converted PrimeVue/`:deep()` override `@apply` blocks to native CSS declarations. - Batch 3: converted `src/components/node/NodeHelpContent.vue` markdown styling from `@apply` to native CSS/token-based declarations. - Batch 4: converted final desktop pseudo-element `@apply` styles and removed stale `@reference` directives no longer required. - Verified `rg -n "^\s*@apply\b" src apps -g "*.vue"` has no real CSS `@apply` directives remaining (only known template false-positive event binding in `NodeSearchContent.vue`). ## Review Focus - Visual parity in components that previously depended on `@apply` in `:deep()` selectors and markdown content: - topbar tabs/popovers, dialogs, breadcrumb, terminal overrides - desktop install/dialog/update/maintenance surfaces - node help markdown rendering - Confirm no regressions from removal of now-unneeded `@reference` directives. ## Screenshots (if applicable) - No new screenshots included in this PR. - Screenshot Playwright suite was run with `--grep="@screenshot"` and reports baseline diffs in this environment (164 passed, 39 failed, 3 skipped) plus a teardown `EPERM` restore error on local path `C:\Users\DrJKL\ComfyUI\LTXV\user`. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9146-fix-eradicate-tailwind-apply-usage-in-vue-styles-3116d73d3650813d8642e0bada13df32) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
44 lines
1.3 KiB
TypeScript
44 lines
1.3 KiB
TypeScript
import path from 'node:path'
|
|
|
|
export default {
|
|
'tests-ui/**': () =>
|
|
'echo "Files in tests-ui/ are deprecated. Colocate tests with source files." && exit 1',
|
|
|
|
'./**/*.{css,vue}': (stagedFiles: string[]) => {
|
|
const joinedPaths = toJoinedRelativePaths(stagedFiles)
|
|
return [`pnpm exec stylelint --allow-empty-input ${joinedPaths}`]
|
|
},
|
|
|
|
'./**/*.js': (stagedFiles: string[]) => formatAndEslint(stagedFiles),
|
|
|
|
'./**/*.{ts,tsx,vue,mts}': (stagedFiles: string[]) => {
|
|
const commands = [...formatAndEslint(stagedFiles), 'pnpm typecheck']
|
|
|
|
const hasBrowserTestsChanges = stagedFiles
|
|
.map((f) => path.relative(process.cwd(), f).replace(/\\/g, '/'))
|
|
.some((f) => f.startsWith('browser_tests/'))
|
|
|
|
if (hasBrowserTestsChanges) {
|
|
commands.push('pnpm typecheck:browser')
|
|
}
|
|
|
|
return commands
|
|
}
|
|
}
|
|
|
|
function formatAndEslint(fileNames: string[]) {
|
|
const joinedPaths = toJoinedRelativePaths(fileNames)
|
|
return [
|
|
`pnpm exec oxfmt --write ${joinedPaths}`,
|
|
`pnpm exec oxlint --fix ${joinedPaths}`,
|
|
`pnpm exec eslint --cache --fix --no-warn-ignored ${joinedPaths}`
|
|
]
|
|
}
|
|
|
|
function toJoinedRelativePaths(fileNames: string[]) {
|
|
const relativePaths = fileNames.map((f) =>
|
|
path.relative(process.cwd(), f).replace(/\\/g, '/')
|
|
)
|
|
return relativePaths.map((p) => `"${p}"`).join(' ')
|
|
}
|