mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
50 lines
1.5 KiB
TypeScript
50 lines
1.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { PropertiesPanelHelper } from '@e2e/tests/propertiesPanel/PropertiesPanelHelper'
|
|
|
|
test.describe('Properties panel - Title editing', () => {
|
|
let panel: PropertiesPanelHelper
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
panel = new PropertiesPanelHelper(comfyPage.page)
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
await comfyPage.nodeOps.selectNodes(['KSampler'])
|
|
})
|
|
|
|
test('should show pencil icon for editable title', async () => {
|
|
await expect(panel.titleEditIcon).toBeVisible()
|
|
})
|
|
|
|
test('should enter edit mode on pencil click', async () => {
|
|
await panel.titleEditIcon.click()
|
|
await expect(panel.titleInput).toBeVisible()
|
|
})
|
|
|
|
test('should update node title on edit', async () => {
|
|
const newTitle = 'My Custom Sampler'
|
|
await panel.editTitle(newTitle)
|
|
await expect(panel.panelTitle).toContainText(newTitle)
|
|
})
|
|
|
|
test('should not show pencil icon for multi-selection', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.nodeOps.selectNodes([
|
|
'KSampler',
|
|
'CLIP Text Encode (Prompt)'
|
|
])
|
|
await expect(panel.titleEditIcon).toBeHidden()
|
|
})
|
|
|
|
test('should not show pencil icon when nothing is selected', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.canvas.deselectAll()
|
|
})
|
|
await expect(panel.panelTitle).toContainText('Workflow Overview')
|
|
await expect(panel.titleEditIcon).toBeHidden()
|
|
})
|
|
})
|