Dante
19fff29204
test: backfill e2e coverage gaps for toolkit widgets, minimap, mask editor, painter (#11183)
## Summary
Backfills missing e2e test coverage identified in the [FixIt
Burndown](https://www.notion.so/comfy-org/FixIt-Burndown-32e6d73d365080609a81cdc9bc884460)
audit. Adds 39 new behavioral tests across 5 spec files with zero
test-code overlap.
## Changes
- **What**: New e2e specs for Image Crop (6 tests) and Curve Widget (6
tests). Deepened coverage for Minimap (+6), Mask Editor (+10), Painter
(+11).
- **New fixtures**: `curve_widget.json`, updated
`image_crop_widget.json`
## Test Inventory
| Spec | New tests | Coverage area |
|---|---|---|
| `imageCrop.spec.ts` | 6 | Empty state, bounding box inputs, ratio
selector/presets, lock toggle, programmatic value update |
| `curveWidget.spec.ts` | 6 | SVG render, click-to-add point,
drag-to-reshape, Ctrl+click remove, interpolation mode switch, min-2
guard |
| `minimap.spec.ts` | +6 | Click-to-pan, drag-to-pan, zoom viewport
shrink, node count changes, workflow reload, pan state reflection |
| `maskEditor.spec.ts` | +10 | Brush drawing, undo/redo, clear, cancel,
invert, Ctrl+Z, tool panel/switching, brush settings, save with mock,
eraser |
| `painter.spec.ts` | +11 | Clear, eraser, control visibility toggle,
brush size slider, stroke width comparison, canvas dimensions,
background color, multi-stroke accumulate, color picker, opacity,
partial erase |
## Review Focus
- Mask editor tests use `.maskEditor_toolPanelContainer` class selectors
— may need test-id hardening later
- Painter slider interaction tests could be flaky if slider layout
changes
- All canvas pixel-count assertions use `expect.poll()` with timeouts
for reliability
## Test plan
- [ ] CI passes all new/modified specs
- [ ] No duplicate coverage with existing tests (verified via grep
before writing)
- [ ] No `waitForTimeout` usage (confirmed)
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11183-test-backfill-e2e-coverage-gaps-for-toolkit-widgets-minimap-mask-editor-painter-3416d73d3650819ca33edd1f27b9651a)
by [Unito](https://www.unito.io)
---------
Co-authored-by: GitHub Action <action@github.com>
2026-04-16 09:48:13 +00:00
..
2026-03-15 22:46:47 +09:00
2026-03-15 22:46:47 +09:00
2026-04-15 15:25:47 +00:00
2025-12-29 15:03:34 -08:00
2026-03-27 09:11:26 +09:00
2026-03-15 22:46:47 +09:00
2026-03-28 13:08:52 -07:00
2026-04-13 00:09:50 -04:00
2026-04-09 20:50:56 -07:00
2026-04-15 15:25:47 +00:00
2026-04-09 20:50:56 -07:00
2026-03-15 22:46:47 +09:00
2026-03-27 16:04:36 -04:00
2026-03-28 23:19:04 -07:00
2026-03-27 09:11:26 +09:00
2026-03-15 22:46:47 +09:00
2025-12-08 19:48:11 -07:00
2026-03-15 22:46:47 +09:00
2025-12-08 19:48:11 -07:00
2026-04-13 00:13:04 -04:00
2026-01-16 22:11:00 -07:00
2026-04-15 10:58:24 +00:00
2026-04-11 01:25:14 +00:00
2026-03-15 22:46:47 +09:00
2026-03-15 22:46:47 +09:00
2026-03-24 12:25:18 -07:00
2026-03-12 01:10:26 -07:00
2026-03-17 10:46:19 -07:00
2026-04-15 15:25:47 +00:00
2026-04-15 16:52:41 +00:00
2026-03-29 08:27:53 +09:00
2026-04-13 20:43:25 +00:00
2026-03-27 09:11:26 +09:00
2026-04-15 15:25:47 +00:00
2026-03-15 22:46:47 +09:00
2026-04-13 20:43:25 +00:00
2026-04-15 11:42:22 +00:00
2026-04-10 19:47:20 +00:00
2026-04-13 15:50:11 +00:00
2026-04-15 11:42:22 +00:00
2026-04-15 11:42:22 +00:00
2026-04-10 19:47:20 +00:00
2026-04-10 19:47:20 +00:00
2026-04-08 11:28:59 -07:00
2026-04-08 11:28:59 -07:00
2026-04-14 23:33:11 +00:00
2026-04-13 20:43:25 +00:00
2026-04-13 20:43:25 +00:00
2026-04-14 17:40:23 +00:00
2026-04-15 15:25:47 +00:00
2026-04-15 15:25:47 +00:00
2026-04-15 15:25:47 +00:00
2026-04-15 15:25:47 +00:00
2026-04-09 20:50:56 -07:00
2026-04-15 15:25:47 +00:00
2026-04-13 15:50:11 +00:00
2026-04-14 17:30:49 +00:00
2026-04-15 15:25:47 +00:00
2026-04-09 20:50:56 -07:00
2026-04-08 11:28:59 -07:00
2026-04-08 11:28:59 -07:00
2026-04-16 09:44:06 +00:00
2026-04-13 20:43:25 +00:00
2026-04-15 15:25:47 +00:00
2026-04-14 14:31:31 -07:00
2026-04-11 01:25:14 +00:00
2026-04-14 14:31:31 -07:00
2026-04-15 10:58:24 +00:00
2026-04-10 19:47:20 +00:00
2026-04-13 20:43:25 +00:00
2026-04-11 01:25:14 +00:00
2026-04-16 13:43:02 +09:00
2026-04-11 01:25:14 +00:00
2026-04-15 15:25:47 +00:00
2026-04-09 20:50:56 -07:00
2026-04-15 16:52:41 +00:00
2026-04-15 16:52:41 +00:00
2026-04-15 10:50:44 -04:00
2026-04-16 09:48:13 +00:00
2026-04-09 20:50:56 -07:00
2026-04-15 15:25:47 +00:00
2026-04-14 17:40:23 +00:00
2026-04-10 19:47:20 +00:00
2026-04-09 20:50:56 -07:00
2026-04-14 17:40:23 +00:00
2026-04-08 11:28:59 -07:00
2026-04-09 20:50:56 -07:00
2026-04-09 20:50:56 -07:00
2026-04-16 09:48:13 +00:00
2026-04-13 20:43:25 +00:00
2026-04-16 09:48:13 +00:00
2026-04-15 15:25:47 +00:00
2026-04-09 20:50:56 -07:00
2026-04-15 16:52:41 +00:00
2026-04-11 01:25:14 +00:00
2026-04-15 15:25:47 +00:00
2026-04-14 17:40:23 +00:00
2026-04-13 20:43:25 +00:00
2026-04-15 15:25:47 +00:00
2026-04-11 01:25:14 +00:00
2026-04-11 01:25:14 +00:00
2026-04-08 11:28:59 -07:00
2026-04-13 20:43:25 +00:00
2026-04-16 09:48:13 +00:00
2026-04-13 20:43:25 +00:00
2026-04-11 01:25:14 +00:00
2026-04-08 11:28:59 -07:00
2026-04-10 19:47:20 +00:00
2026-04-13 20:43:25 +00:00
2026-04-13 20:43:25 +00:00
2026-04-08 11:28:59 -07:00
2026-04-14 17:40:23 +00:00
2026-04-14 17:40:23 +00:00
2026-04-15 15:25:47 +00:00
2026-04-13 20:43:25 +00:00
2026-04-14 17:30:49 +00:00
2026-04-15 15:25:47 +00:00
2026-04-15 15:25:47 +00:00
2026-04-15 16:52:41 +00:00
2026-04-14 23:20:45 +00:00
2026-04-15 16:52:41 +00:00
2026-04-13 20:43:25 +00:00
2026-04-08 11:28:59 -07:00
2026-04-13 20:43:25 +00:00
2026-04-14 17:40:23 +00:00
2026-04-08 11:28:59 -07:00
2026-04-11 01:25:14 +00:00
2026-04-13 20:43:25 +00:00
2026-04-15 15:25:47 +00:00
2026-04-11 01:25:14 +00:00
2026-04-13 22:15:45 +00:00
2026-04-15 16:52:41 +00:00
2026-04-13 20:43:25 +00:00
2026-04-11 01:25:14 +00:00