mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
121 lines
4.2 KiB
TypeScript
121 lines
4.2 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { PropertiesPanelHelper } from '@e2e/tests/propertiesPanel/PropertiesPanelHelper'
|
|
|
|
test.describe('Properties panel - Node settings', () => {
|
|
let panel: PropertiesPanelHelper
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
panel = new PropertiesPanelHelper(comfyPage.page)
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
await comfyPage.nodeOps.selectNodes(['KSampler'])
|
|
await panel.switchToTab('Settings')
|
|
})
|
|
|
|
test.describe('Node state', () => {
|
|
test('should show Normal, Bypass, and Mute state buttons', async () => {
|
|
await expect(panel.getNodeStateButton('Normal')).toBeVisible()
|
|
await expect(panel.getNodeStateButton('Bypass')).toBeVisible()
|
|
await expect(panel.getNodeStateButton('Mute')).toBeVisible()
|
|
})
|
|
|
|
test('should set node to Bypass mode', async ({ comfyPage }) => {
|
|
await panel.getNodeStateButton('Bypass').click()
|
|
|
|
const nodeLocator = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
await expect(nodeLocator.getByText('Bypassed')).toBeVisible()
|
|
})
|
|
|
|
test('should set node to Mute mode', async ({ comfyPage }) => {
|
|
await panel.getNodeStateButton('Mute').click()
|
|
|
|
const nodeLocator = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
await expect(nodeLocator.getByText('Muted')).toBeVisible()
|
|
})
|
|
|
|
test('should restore node to Normal mode', async ({ comfyPage }) => {
|
|
await panel.getNodeStateButton('Bypass').click()
|
|
const nodeLocator = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
await expect(nodeLocator.getByText('Bypassed')).toBeVisible()
|
|
|
|
await panel.getNodeStateButton('Normal').click()
|
|
await expect(nodeLocator.getByText('Bypassed')).toBeHidden()
|
|
await expect(nodeLocator.getByText('Muted')).toBeHidden()
|
|
})
|
|
})
|
|
|
|
test.describe('Node color', () => {
|
|
test('should display color swatches', async () => {
|
|
await expect(panel.getColorSwatch('noColor')).toBeVisible()
|
|
await expect(panel.getColorSwatch('red')).toBeVisible()
|
|
await expect(panel.getColorSwatch('blue')).toBeVisible()
|
|
})
|
|
|
|
test('should apply color to node', async ({ comfyPage }) => {
|
|
await panel.getColorSwatch('red').click()
|
|
|
|
await expect
|
|
.poll(() =>
|
|
comfyPage.page.evaluate(() => {
|
|
const selected = window.app!.canvas.selected_nodes
|
|
const node = Object.values(selected)[0]
|
|
return node?.color != null
|
|
})
|
|
)
|
|
.toBe(true)
|
|
})
|
|
|
|
test('should remove color with noColor swatch', async ({ comfyPage }) => {
|
|
await panel.getColorSwatch('red').click()
|
|
|
|
await expect
|
|
.poll(() =>
|
|
comfyPage.page.evaluate(() => {
|
|
const selected = window.app!.canvas.selected_nodes
|
|
const node = Object.values(selected)[0]
|
|
return node?.color != null
|
|
})
|
|
)
|
|
.toBe(true)
|
|
|
|
await panel.getColorSwatch('noColor').click()
|
|
|
|
await expect
|
|
.poll(() =>
|
|
comfyPage.page.evaluate(() => {
|
|
const selected = window.app!.canvas.selected_nodes
|
|
const node = Object.values(selected)[0]
|
|
return node?.color
|
|
})
|
|
)
|
|
.toBeFalsy()
|
|
})
|
|
})
|
|
|
|
test.describe('Pinned state', () => {
|
|
test('should display pinned toggle', async () => {
|
|
await expect(panel.pinnedSwitch).toBeVisible()
|
|
})
|
|
|
|
test('should toggle pinned state', async ({ comfyPage }) => {
|
|
await panel.pinnedSwitch.click()
|
|
|
|
const nodeLocator = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
await expect(nodeLocator.getByTestId('node-pin-indicator')).toBeVisible()
|
|
})
|
|
|
|
test('should unpin previously pinned node', async ({ comfyPage }) => {
|
|
const nodeLocator = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
|
|
await panel.pinnedSwitch.click()
|
|
await expect(nodeLocator.getByTestId('node-pin-indicator')).toBeVisible()
|
|
|
|
await panel.pinnedSwitch.click()
|
|
await expect(nodeLocator.getByTestId('node-pin-indicator')).toBeHidden()
|
|
})
|
|
})
|
|
})
|