mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
56 lines
1.9 KiB
TypeScript
56 lines
1.9 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.describe('Vue Nodes Renaming', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.Graph.CanvasMenu', false)
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('should display node title', async ({ comfyPage }) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
await expect(vueNode.header).toContainText('KSampler')
|
|
})
|
|
|
|
test('should allow title renaming by double clicking on the node header', async ({
|
|
comfyPage
|
|
}) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
// Test renaming with Enter
|
|
await vueNode.setTitle('My Custom Sampler')
|
|
await expect(vueNode.title).toHaveText('My Custom Sampler')
|
|
await expect(vueNode.header).toContainText('My Custom Sampler')
|
|
|
|
// Test cancel with Escape
|
|
await vueNode.title.dblclick()
|
|
await comfyPage.nextFrame()
|
|
await vueNode.titleInput.fill('This Should Be Cancelled')
|
|
await vueNode.titleInput.press('Escape')
|
|
await comfyPage.nextFrame()
|
|
|
|
// Title should remain as the previously saved value
|
|
await expect(vueNode.title).toHaveText('My Custom Sampler')
|
|
})
|
|
|
|
test('Double click node body does not trigger edit', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = comfyPage.vueNodes
|
|
.getNodeByTitle('Load Checkpoint')
|
|
.first()
|
|
const nodeBbox = await loadCheckpointNode.boundingBox()
|
|
if (!nodeBbox) throw new Error('Node not found')
|
|
await loadCheckpointNode.dblclick()
|
|
|
|
const editingTitleInput = comfyPage.page.getByTestId(
|
|
TestIds.node.titleInput
|
|
)
|
|
await expect(editingTitleInput).toBeHidden()
|
|
})
|
|
})
|