mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
0d535631a5
## Summary
Extract inline `getByRole('dialog')` calls across E2E tests into
reusable page objects.
## Changes
- **What**: Extract `ConfirmDialog` class from `ComfyPage.ts` into
`browser_tests/fixtures/components/ConfirmDialog.ts` with new `save`
button locator. Add `MediaLightbox` and `TemplatesDialog` page objects.
Refactor 4 test files to use these page objects instead of raw dialog
locators.
- **Skipped**: `appModeDropdownClipping.spec.ts` uses
`getByRole('dialog')` for a PrimeVue Popover (not a true dialog), left
as-is.
## Review Focus
The `ConfirmDialog.click()` method now supports a `save` action used by
`workflowPersistence.spec.ts`, which also waits for the dialog mask to
disappear and workflow service to settle.
Fixes #10723
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10822-refactor-test-extract-dialog-page-objects-from-inline-getByRole-usage-3366d73d365081b3bc0ee7ef0ddce658)
by [Unito](https://www.unito.io)
31 lines
890 B
TypeScript
31 lines
890 B
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Confirm dialog text wrapping', { tag: ['@mobile'] }, () => {
|
|
test('@mobile confirm dialog buttons are visible with long unbreakable text', async ({
|
|
comfyPage
|
|
}) => {
|
|
const longFilename = 'workflow_checkpoint_' + 'a'.repeat(200) + '.json'
|
|
|
|
await comfyPage.page.evaluate((msg) => {
|
|
window
|
|
.app!.extensionManager.dialog.confirm({
|
|
title: 'Confirm',
|
|
type: 'default',
|
|
message: msg
|
|
})
|
|
.catch(() => {})
|
|
}, longFilename)
|
|
|
|
const { root, confirm, reject } = comfyPage.confirmDialog
|
|
await expect(root).toBeVisible()
|
|
|
|
await expect(confirm).toBeVisible()
|
|
await expect(confirm).toBeInViewport()
|
|
|
|
await expect(reject).toBeVisible()
|
|
await expect(reject).toBeInViewport()
|
|
})
|
|
})
|