mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-02 22:37:32 +00:00
82bacb82a7
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
import type { Locator } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
async function verifyCustomIconSvg(iconElement: Locator) {
|
|
const svgVariable = await iconElement.evaluate((element) => {
|
|
const styles = getComputedStyle(element)
|
|
return styles.getPropertyValue('--svg')
|
|
})
|
|
|
|
expect(svgVariable).toBeTruthy()
|
|
const dataUrlMatch = svgVariable.match(
|
|
/url\("data:image\/svg\+xml,([^"]+)"\)/
|
|
)
|
|
expect(dataUrlMatch).toBeTruthy()
|
|
|
|
const encodedSvg = dataUrlMatch![1]
|
|
const decodedSvg = decodeURIComponent(encodedSvg)
|
|
|
|
// Check for SVG header to confirm it's a valid SVG
|
|
expect(decodedSvg).toContain("<svg xmlns='http://www.w3.org/2000/svg'")
|
|
}
|
|
|
|
test.describe('Custom Icons', { tag: '@settings' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('sidebar tab icons use custom SVGs', async ({ comfyPage }) => {
|
|
// Find the icon in the sidebar
|
|
const icon = comfyPage.page.locator(
|
|
'.icon-\\[comfy--ai-model\\].side-bar-button-icon'
|
|
)
|
|
await expect(icon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(icon)
|
|
})
|
|
|
|
test('Browse Templates menu item uses custom template icon', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Open the topbar menu
|
|
await comfyPage.menu.topbar.openTopbarMenu()
|
|
const menuItem = comfyPage.menu.topbar.getMenuItem('Browse Templates')
|
|
|
|
// Find the icon as a previous sibling of the menu item label
|
|
const templateIcon = menuItem
|
|
.locator('..')
|
|
.locator('.icon-\\[comfy--template\\]')
|
|
await expect(templateIcon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(templateIcon)
|
|
})
|
|
})
|