mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
4a8f68a6bd
Upgrades `pnpm/action-setup` from v4.2.0 to v4.4.0 across all 16 workflow files and the shared `setup-frontend` action. ## Why GitHub Actions will force Node.js 24 as the default starting June 2, 2026. The v4.2.0 pin ran on Node.js 20 and emitted deprecation warnings on every CI run. v4.4.0 was released specifically to address this, updating the action runtime to Node.js 24. - Fixes the warning: *"pnpm/action-setup@41ff72... Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026"* ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10137-ci-upgrade-pnpm-action-setup-to-v4-4-0-Node-js-24-3266d73d36508176b157fcd1d33f2274) by [Unito](https://www.unito.io)
101 lines
3.2 KiB
YAML
101 lines
3.2 KiB
YAML
name: 'CI: Dist Telemetry Scan'
|
|
|
|
on:
|
|
pull_request:
|
|
branches-ignore: [wip/*, draft/*, temp/*]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
scan:
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
|
|
|
- name: Install pnpm
|
|
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
|
|
with:
|
|
version: 10
|
|
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build project
|
|
run: pnpm build
|
|
env:
|
|
DISTRIBUTION: localhost
|
|
|
|
- name: Scan dist for GTM telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for Google Tag Manager references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e 'Google Tag Manager' \
|
|
-e '(?i)\bgtm\.js\b' \
|
|
-e '(?i)googletagmanager\.com/gtm\.js\\?id=' \
|
|
-e '(?i)googletagmanager\.com/ns\.html\\?id=' \
|
|
dist; then
|
|
echo '❌ ERROR: Google Tag Manager references found in dist assets!'
|
|
echo 'GTM must be properly tree-shaken from OSS builds.'
|
|
exit 1
|
|
fi
|
|
echo '✅ No GTM references found'
|
|
|
|
- name: Scan dist for Mixpanel telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for Mixpanel references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e '(?i)mixpanel\.init' \
|
|
-e '(?i)mixpanel\.identify' \
|
|
-e 'MixpanelTelemetryProvider' \
|
|
-e 'mp\.comfy\.org' \
|
|
-e 'mixpanel-browser' \
|
|
-e '(?i)mixpanel\.track\(' \
|
|
dist; then
|
|
echo '❌ ERROR: Mixpanel references found in dist assets!'
|
|
echo 'Mixpanel must be properly tree-shaken from OSS builds.'
|
|
echo ''
|
|
echo 'To fix this:'
|
|
echo '1. Use the TelemetryProvider pattern (see src/platform/telemetry/)'
|
|
echo '2. Call telemetry via useTelemetry() hook'
|
|
echo '3. Use conditional dynamic imports behind isCloud checks'
|
|
exit 1
|
|
fi
|
|
echo '✅ No Mixpanel references found'
|
|
|
|
- name: Scan dist for PostHog telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for PostHog references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e '(?i)posthog\.init' \
|
|
-e '(?i)posthog\.capture' \
|
|
-e 'PostHogTelemetryProvider' \
|
|
-e 'ph\.comfy\.org' \
|
|
-e 'posthog-js' \
|
|
dist; then
|
|
echo '❌ ERROR: PostHog references found in dist assets!'
|
|
echo 'PostHog must be properly tree-shaken from OSS builds.'
|
|
exit 1
|
|
fi
|
|
echo '✅ No PostHog references found'
|