mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
66daa6d645
## Summary Refactors the error system to improve separation of concerns, fix DDD layer violations, and address code quality issues. - Extract `missingNodesErrorStore` from `executionErrorStore`, removing the delegation pattern that coupled missing-node logic into the execution error store - Extract `useNodeErrorFlagSync` composable for node error flag reconciliation (previously inlined) - Extract `useErrorClearingHooks` composable with explicit callback cleanup on node removal - Extract `useErrorActions` composable to deduplicate telemetry+command patterns across error card components - Move `getCnrIdFromNode`/`getCnrIdFromProperties` to `platform/nodeReplacement` layer (DDD fix) - Move `missingNodesErrorStore` to `platform/nodeReplacement` (DDD alignment) - Add unmount cancellation guard to `useErrorReport` async `onMounted` - Return watch stop handle from `useNodeErrorFlagSync` - Add `asyncResolvedIds` eviction on `missingNodesError` reset - Add `console.warn` to silent catch blocks and empty array guard - Hoist `useCommandStore` to setup scope, fix floating promises - Add `data-testid` to error groups, image/video error spans, copy button - Update E2E tests to use scoped locators and testids - Add unit tests for `onNodeRemoved` restoration and double-install guard Fixes #9875, Fixes #10027, Fixes #10033, Fixes #10085 ## Test plan - [x] Existing unit tests pass with updated imports and mocks - [x] New unit tests for `useErrorClearingHooks` (callback restoration, double-install guard) - [x] E2E tests updated to use scoped locators and `data-testid` - [ ] Manual: verify error tab shows runtime errors and missing nodes correctly - [ ] Manual: verify "Find on GitHub", "Copy", and "Get Help" buttons work in error cards ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10302-refactor-error-system-cleanup-store-separation-DDD-fix-test-improvements-3286d73d365081838279d045b8dd957a) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
68 lines
2.0 KiB
TypeScript
68 lines
2.0 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import type { LGraphNode } from '@/lib/litegraph/src/litegraph'
|
|
|
|
import { getCnrIdFromNode, getCnrIdFromProperties } from './cnrIdUtil'
|
|
|
|
describe('getCnrIdFromProperties', () => {
|
|
it('returns cnr_id when present', () => {
|
|
expect(getCnrIdFromProperties({ cnr_id: 'my-pack' })).toBe('my-pack')
|
|
})
|
|
|
|
it('returns aux_id when cnr_id is absent', () => {
|
|
expect(getCnrIdFromProperties({ aux_id: 'my-aux-pack' })).toBe(
|
|
'my-aux-pack'
|
|
)
|
|
})
|
|
|
|
it('prefers cnr_id over aux_id', () => {
|
|
expect(
|
|
getCnrIdFromProperties({ cnr_id: 'primary', aux_id: 'secondary' })
|
|
).toBe('primary')
|
|
})
|
|
|
|
it('returns undefined when neither is present', () => {
|
|
expect(getCnrIdFromProperties({})).toBeUndefined()
|
|
})
|
|
|
|
it('returns undefined for null properties', () => {
|
|
expect(getCnrIdFromProperties(null)).toBeUndefined()
|
|
})
|
|
|
|
it('returns undefined for undefined properties', () => {
|
|
expect(getCnrIdFromProperties(undefined)).toBeUndefined()
|
|
})
|
|
|
|
it('returns undefined when cnr_id is not a string', () => {
|
|
expect(getCnrIdFromProperties({ cnr_id: 123 })).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('getCnrIdFromNode', () => {
|
|
it('returns cnr_id from node properties', () => {
|
|
const node = {
|
|
properties: { cnr_id: 'node-pack' }
|
|
} as unknown as LGraphNode
|
|
expect(getCnrIdFromNode(node)).toBe('node-pack')
|
|
})
|
|
|
|
it('returns aux_id when cnr_id is absent', () => {
|
|
const node = {
|
|
properties: { aux_id: 'node-aux-pack' }
|
|
} as unknown as LGraphNode
|
|
expect(getCnrIdFromNode(node)).toBe('node-aux-pack')
|
|
})
|
|
|
|
it('prefers cnr_id over aux_id in node properties', () => {
|
|
const node = {
|
|
properties: { cnr_id: 'primary', aux_id: 'secondary' }
|
|
} as unknown as LGraphNode
|
|
expect(getCnrIdFromNode(node)).toBe('primary')
|
|
})
|
|
|
|
it('returns undefined when node has no cnr_id or aux_id', () => {
|
|
const node = { properties: {} } as unknown as LGraphNode
|
|
expect(getCnrIdFromNode(node)).toBeUndefined()
|
|
})
|
|
})
|