mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
92 lines
2.6 KiB
TypeScript
92 lines
2.6 KiB
TypeScript
import type { Locator } from '@playwright/test'
|
|
|
|
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Job History Actions', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
|
|
// Expand the queue overlay so the JobHistoryActionsMenu is visible
|
|
await comfyPage.page.getByTestId('queue-overlay-toggle').click()
|
|
})
|
|
|
|
async function openMoreOptionsPopover(comfyPage: {
|
|
page: { getByLabel(label: string | RegExp): Locator }
|
|
}) {
|
|
const moreButton = comfyPage.page.getByLabel(/More options/i).first()
|
|
await moreButton.click()
|
|
}
|
|
|
|
test('More options popover opens', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="docked-job-history-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Docked job history action is visible with text', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="docked-job-history-action"]'
|
|
)
|
|
await expect(action).toBeVisible()
|
|
await expect(action).not.toBeEmpty()
|
|
})
|
|
|
|
test('Show run progress bar action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="show-run-progress-bar-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clear history action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="clear-history-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clicking docked job history closes popover', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="docked-job-history-action"]'
|
|
)
|
|
await expect(action).toBeVisible()
|
|
await action.click()
|
|
|
|
await expect(action).not.toBeVisible()
|
|
})
|
|
|
|
test('Clicking show run progress bar toggles setting', async ({
|
|
comfyPage
|
|
}) => {
|
|
const settingBefore = await comfyPage.settings.getSetting<boolean>(
|
|
'Comfy.Queue.ShowRunProgressBar'
|
|
)
|
|
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="show-run-progress-bar-action"]'
|
|
)
|
|
await action.click()
|
|
|
|
const settingAfter = await comfyPage.settings.getSetting<boolean>(
|
|
'Comfy.Queue.ShowRunProgressBar'
|
|
)
|
|
expect(settingAfter).toBe(!settingBefore)
|
|
})
|
|
})
|