mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
127 lines
4.0 KiB
TypeScript
127 lines
4.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { SystemStats } from '@/schemas/apiSchema'
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Version Mismatch Warnings', { tag: '@slow' }, () => {
|
|
const ALWAYS_AHEAD_OF_INSTALLED_VERSION = '100.100.100'
|
|
const ALWAYS_BEHIND_INSTALLED_VERSION = '0.0.0'
|
|
|
|
const createMockSystemStatsRes = (
|
|
requiredFrontendVersion: string
|
|
): SystemStats => {
|
|
return {
|
|
system: {
|
|
os: 'posix',
|
|
ram_total: 67235385344,
|
|
ram_free: 13464207360,
|
|
comfyui_version: '0.3.46',
|
|
required_frontend_version: requiredFrontendVersion,
|
|
python_version: '3.12.3 (main, Jun 18 2025, 17:59:45) [GCC 13.3.0]',
|
|
pytorch_version: '2.6.0+cu124',
|
|
embedded_python: false,
|
|
argv: ['main.py']
|
|
},
|
|
devices: [
|
|
{
|
|
name: 'cuda:0 NVIDIA GeForce RTX 4070 : cudaMallocAsync',
|
|
type: 'cuda',
|
|
index: 0,
|
|
vram_total: 12557156352,
|
|
vram_free: 2439249920,
|
|
torch_vram_total: 0,
|
|
torch_vram_free: 0
|
|
}
|
|
]
|
|
}
|
|
}
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.VersionCompatibility.DisableWarnings',
|
|
false
|
|
)
|
|
})
|
|
|
|
test('should show version mismatch warnings when installed version lower than required', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_AHEAD_OF_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Expect a warning toast to be shown
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('should not show version mismatch warnings when installed version is ahead of required', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_BEHIND_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Expect no warning toast to be shown
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('should persist dismissed state across sessions', async ({
|
|
comfyPage
|
|
}) => {
|
|
test.setTimeout(30_000)
|
|
// Mock system_stats route to indicate that the installed version is always ahead of the required version
|
|
await comfyPage.page.route('**/system_stats**', async (route) => {
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(
|
|
createMockSystemStatsRes(ALWAYS_AHEAD_OF_INSTALLED_VERSION)
|
|
)
|
|
})
|
|
})
|
|
await comfyPage.setup()
|
|
|
|
// Locate the warning toast and dismiss it
|
|
const warningToast = comfyPage.page.locator('.p-toast-message').filter({
|
|
hasText: 'Version Compatibility'
|
|
})
|
|
await warningToast.waitFor({ state: 'visible' })
|
|
const dismissButton = warningToast.getByRole('button', { name: 'Close' })
|
|
await dismissButton.click()
|
|
|
|
// Wait for the dismissed state to be persisted
|
|
await comfyPage.page.waitForFunction(
|
|
() => !!localStorage.getItem('comfy.versionMismatch.dismissals')
|
|
)
|
|
|
|
// Reload the page, keeping local storage
|
|
await comfyPage.setup({ clearStorage: false })
|
|
|
|
// The same warning from same versions should not be shown to the user again
|
|
await expect(
|
|
comfyPage.page.getByText('Version Compatibility Warning')
|
|
).not.toBeVisible()
|
|
})
|
|
})
|