mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
67 lines
2.5 KiB
TypeScript
67 lines
2.5 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
import type { WorkspaceStore } from '@e2e/types/globals'
|
|
|
|
test.describe(
|
|
'Change Tracker - isLoadingGraph guard',
|
|
{ tag: '@workflow' },
|
|
() => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.workflow.setupWorkflowsDirectory({})
|
|
})
|
|
|
|
test('Prevents checkState from corrupting workflow state during tab switch', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Tab 0: default workflow (7 nodes)
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(7)
|
|
|
|
// Save tab 0 so it has a unique name for tab switching
|
|
await comfyPage.menu.topbar.saveWorkflow('workflow-a')
|
|
|
|
// Register an extension that forces checkState during graph loading.
|
|
// This simulates the bug scenario where a user clicks during graph loading
|
|
// which triggers a checkState call on the wrong graph, corrupting the activeState.
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.registerExtension({
|
|
name: 'TestCheckStateDuringLoad',
|
|
afterConfigureGraph() {
|
|
const workflow = (window.app!.extensionManager as WorkspaceStore)
|
|
.workflow.activeWorkflow
|
|
if (!workflow) throw new Error('No workflow found')
|
|
// Bypass the guard to reproduce the corruption bug:
|
|
// ; (workflow.changeTracker.constructor as unknown as { isLoadingGraph: boolean }).isLoadingGraph = false
|
|
|
|
// Simulate the user clicking during graph loading
|
|
workflow.changeTracker.checkState()
|
|
}
|
|
})
|
|
})
|
|
|
|
// Create tab 1: blank workflow (0 nodes)
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(0)
|
|
|
|
// Switch back to tab 0 (workflow-a).
|
|
const tab0 = comfyPage.menu.topbar.getWorkflowTab('workflow-a')
|
|
await tab0.click()
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(7)
|
|
|
|
// switch to blank tab and back to verify no corruption
|
|
const tab1 = comfyPage.menu.topbar.getWorkflowTab('Unsaved Workflow')
|
|
await tab1.click()
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(0)
|
|
|
|
// switch again and verify no corruption
|
|
await tab0.click()
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(7)
|
|
})
|
|
}
|
|
)
|