mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
297 lines
7.7 KiB
TypeScript
297 lines
7.7 KiB
TypeScript
import { mount } from '@vue/test-utils'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
|
|
import { useWorkflowAutoSave } from '@/platform/workflow/persistence/composables/useWorkflowAutoSave'
|
|
import { api } from '@/scripts/api'
|
|
|
|
vi.mock('@/scripts/api', () => ({
|
|
api: {
|
|
addEventListener: vi.fn(),
|
|
removeEventListener: vi.fn()
|
|
}
|
|
}))
|
|
|
|
vi.mock('@/platform/workflow/core/services/workflowService', () => ({
|
|
useWorkflowService: vi.fn(() => ({
|
|
saveWorkflow: vi.fn()
|
|
}))
|
|
}))
|
|
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: vi.fn(() => ({
|
|
get: vi.fn((key) => {
|
|
if (key === 'Comfy.Workflow.AutoSave') return mockAutoSaveSetting
|
|
if (key === 'Comfy.Workflow.AutoSaveDelay') return mockAutoSaveDelay
|
|
return null
|
|
})
|
|
}))
|
|
}))
|
|
|
|
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
|
useWorkflowStore: vi.fn(() => ({
|
|
activeWorkflow: mockActiveWorkflow
|
|
}))
|
|
}))
|
|
|
|
let mockAutoSaveSetting: string = 'off'
|
|
let mockAutoSaveDelay: number = 1000
|
|
let mockActiveWorkflow: { isModified: boolean; isPersisted?: boolean } | null =
|
|
null
|
|
|
|
describe('useWorkflowAutoSave', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.useFakeTimers()
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('should auto-save workflow after delay when modified and autosave enabled', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalledWith(
|
|
mockActiveWorkflow
|
|
)
|
|
})
|
|
|
|
it('should not auto-save workflow after delay when not modified and autosave enabled', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: false, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).not.toHaveBeenCalledWith(
|
|
mockActiveWorkflow
|
|
)
|
|
})
|
|
|
|
it('should not auto save workflow when autosave is off', async () => {
|
|
mockAutoSaveSetting = 'off'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
vi.advanceTimersByTime(mockAutoSaveDelay)
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should respect the user specified auto save delay', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 2000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).not.toHaveBeenCalled()
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should debounce save requests', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 2000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
const graphChangedCallback = (api.addEventListener as any).mock.calls[0][1]
|
|
|
|
graphChangedCallback()
|
|
|
|
vi.advanceTimersByTime(500)
|
|
|
|
graphChangedCallback()
|
|
|
|
vi.advanceTimersByTime(1999)
|
|
expect(serviceInstance.saveWorkflow).not.toHaveBeenCalled()
|
|
|
|
vi.advanceTimersByTime(1)
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('should handle save error gracefully', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
const consoleErrorSpy = vi
|
|
.spyOn(console, 'error')
|
|
.mockImplementation(() => {})
|
|
|
|
try {
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
serviceInstance.saveWorkflow.mockRejectedValue(new Error('Test Error'))
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
await Promise.resolve()
|
|
|
|
expect(consoleErrorSpy).toHaveBeenCalledWith(
|
|
'Auto save failed:',
|
|
expect.any(Error)
|
|
)
|
|
} finally {
|
|
consoleErrorSpy.mockRestore()
|
|
}
|
|
})
|
|
|
|
it('should queue autosave requests during saving and reschedule after save completes', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
let resolveSave: () => void
|
|
const firstSavePromise = new Promise<void>((resolve) => {
|
|
resolveSave = resolve
|
|
})
|
|
|
|
serviceInstance.saveWorkflow.mockImplementationOnce(() => firstSavePromise)
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
const graphChangedCallback = (api.addEventListener as any).mock.calls[0][1]
|
|
graphChangedCallback()
|
|
|
|
resolveSave!()
|
|
await Promise.resolve()
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalledTimes(2)
|
|
})
|
|
|
|
it('should clean up event listeners on component unmount', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
|
|
const wrapper = mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
wrapper.unmount()
|
|
|
|
expect(api.removeEventListener).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle edge case delay values properly', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 0
|
|
mockActiveWorkflow = { isModified: true, isPersisted: true }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
await vi.runAllTimersAsync()
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalledTimes(1)
|
|
serviceInstance.saveWorkflow.mockClear()
|
|
|
|
mockAutoSaveDelay = -500
|
|
|
|
const graphChangedCallback = (api.addEventListener as any).mock.calls[0][1]
|
|
graphChangedCallback()
|
|
|
|
await vi.runAllTimersAsync()
|
|
|
|
expect(serviceInstance.saveWorkflow).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('should not autosave if workflow is not persisted', async () => {
|
|
mockAutoSaveSetting = 'after delay'
|
|
mockAutoSaveDelay = 1000
|
|
mockActiveWorkflow = { isModified: true, isPersisted: false }
|
|
|
|
mount({
|
|
template: `<div></div>`,
|
|
setup() {
|
|
useWorkflowAutoSave()
|
|
return {}
|
|
}
|
|
})
|
|
|
|
vi.advanceTimersByTime(1000)
|
|
|
|
const serviceInstance = (useWorkflowService as any).mock.results[0].value
|
|
expect(serviceInstance.saveWorkflow).not.toHaveBeenCalledWith(
|
|
mockActiveWorkflow
|
|
)
|
|
})
|
|
})
|