ComfyUI_frontend

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-03 20:51:58 +00:00

Files

Christian Byrne 0e5bd539ec fix: 3D asset disappears when switching to image output in app mode (#9622 )

## Summary

Fix 3D asset disappearing when switching between 3D and image outputs in
app mode — missing `onUnmounted` cleanup leaked WebGL contexts.

## Changes

- **What**: Add `onUnmounted` hook to `Preview3d.vue` that calls
`viewer.cleanup()`, releasing the WebGL context when Vue destroys the
component via its v-if chain. Add unit tests covering init, cleanup on
unmount, and remount behavior.

## Review Focus

When switching outputs in app mode, Vue's v-if chain destroys and
recreates `Preview3d`. Without `onUnmounted` cleanup, the old `Load3d`
instance (WebGL context, RAF loop, ResizeObserver) leaks. After ~8-16
toggles, the browser's WebGL context limit is exhausted and new 3D
viewers silently fail to render.

<!-- Pipeline-Ticket: e36489d2-a9fb-47ca-9e27-88eb3170836b -->

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>

2026-03-18 01:08:04 +00:00

adr

fix: 3D asset disappears when switching to image output in app mode (#9622 )

2026-03-18 01:08:04 +00:00

architecture

docs: add change tracker architecture documentation (#9767 )

2026-03-12 03:03:07 -07:00

extensions

Chore: Oxfmt formatting pass (#8341 )

2026-01-27 17:59:19 -08:00

guidance

fix: eradicate tailwind @apply usage in vue styles (#9146 )