Files
ComfyUI_frontend/browser_tests/tests/load3d/load3d.spec.ts
pythongosssss a6c3ff1a54 fix: load3d used wrong i18n key, add test (#11546)
## Summary

Toast for Load3D initialization failure was using the wrong key and so
showed an untranslated key to the user.

## Changes

- **What**: 
- Update to use correct existing key
- Add test that forces init failure

## Screenshots (if applicable)
Fixed
<img width="482" height="121" alt="image"
src="https://github.com/user-attachments/assets/f89eef99-c1a6-463a-a711-7e9c16d0e89a"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11546-fix-load3d-used-wrong-i18n-key-add-test-34a6d73d36508159aab9f042d3e9c4f0)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
2026-04-23 11:52:42 -04:00

314 lines
10 KiB
TypeScript

import { expect } from '@playwright/test'
import { assetPath } from '@e2e/fixtures/utils/paths'
import { load3dTest as test } from '@e2e/fixtures/helpers/Load3DFixtures'
test.describe('Load3D', () => {
test(
'Renders canvas with upload buttons and controls menu',
{ tag: ['@smoke', '@screenshot'] },
async ({ load3d }) => {
await expect(load3d.node).toBeVisible()
await expect(load3d.canvas).toBeVisible()
await expect
.poll(async () => {
const b = await load3d.canvas.boundingBox()
return b?.width ?? 0
})
.toBeGreaterThan(0)
await expect
.poll(async () => {
const b = await load3d.canvas.boundingBox()
return b?.height ?? 0
})
.toBeGreaterThan(0)
await expect(load3d.getUploadButton('upload 3d model')).toBeVisible()
await expect(
load3d.getUploadButton('upload extra resources')
).toBeVisible()
await expect(load3d.getUploadButton('clear')).toBeVisible()
await expect(load3d.menuButton).toBeVisible()
await expect(load3d.node).toHaveScreenshot('load3d-empty-node.png', {
maxDiffPixelRatio: 0.05
})
}
)
test(
'Controls menu opens and shows all categories',
{ tag: ['@smoke', '@screenshot'] },
async ({ load3d }) => {
await load3d.openMenu()
await expect(load3d.getMenuCategory('Scene')).toBeVisible()
await expect(load3d.getMenuCategory('Model')).toBeVisible()
await expect(load3d.getMenuCategory('Camera')).toBeVisible()
await expect(load3d.getMenuCategory('Light')).toBeVisible()
await expect(load3d.getMenuCategory('Export')).toBeVisible()
await expect(load3d.node).toHaveScreenshot(
'load3d-controls-menu-open.png',
{ maxDiffPixelRatio: 0.05 }
)
}
)
test(
'Changing background color updates the scene',
{ tag: ['@smoke', '@screenshot'] },
async ({ comfyPage, load3d }) => {
await load3d.setBackgroundColor('#cc3333')
await comfyPage.nextFrame()
await expect
.poll(() =>
comfyPage.page.evaluate(() => {
const n = window.app!.graph.getNodeById(1)
const config = n?.properties?.['Scene Config'] as
| Record<string, string>
| undefined
return config?.backgroundColor
})
)
.toBe('#cc3333')
await expect(load3d.node).toHaveScreenshot('load3d-red-background.png', {
maxDiffPixelRatio: 0.05
})
}
)
test(
'Recording controls are visible for Load3D',
{ tag: '@smoke' },
async ({ load3d }) => {
await expect(load3d.recordingButton).toBeVisible()
}
)
test(
'Uploads a 3D model via button and renders it',
{ tag: ['@screenshot'] },
async ({ comfyPage, load3d }) => {
const uploadResponsePromise = comfyPage.page.waitForResponse(
(resp) => resp.url().includes('/upload/') && resp.status() === 200,
{ timeout: 15000 }
)
const fileChooserPromise = comfyPage.page.waitForEvent('filechooser')
await load3d.getUploadButton('upload 3d model').click()
const fileChooser = await fileChooserPromise
await fileChooser.setFiles(assetPath('cube.obj'))
await uploadResponsePromise
const node = await comfyPage.nodeOps.getNodeRefById(1)
const modelFileWidget = await node.getWidget(0)
await expect.poll(() => modelFileWidget.getValue()).toContain('cube.obj')
await load3d.waitForModelLoaded()
await comfyPage.expectScreenshot(
load3d.node,
'load3d-uploaded-cube-obj.png',
{ maxDiffPixelRatio: 0.1 }
)
}
)
test(
'Drag-and-drops a 3D model onto the canvas',
{ tag: ['@screenshot'] },
async ({ comfyPage, load3d }) => {
const canvasBox = await load3d.canvas.boundingBox()
expect(canvasBox, 'Canvas bounding box should exist').not.toBeNull()
const dropPosition = {
x: canvasBox!.x + canvasBox!.width / 2,
y: canvasBox!.y + canvasBox!.height / 2
}
await comfyPage.dragDrop.dragAndDropFile('cube.obj', {
dropPosition,
waitForUpload: true
})
const node = await comfyPage.nodeOps.getNodeRefById(1)
const modelFileWidget = await node.getWidget(0)
await expect.poll(() => modelFileWidget.getValue()).toContain('cube.obj')
await load3d.waitForModelLoaded()
await comfyPage.expectScreenshot(
load3d.node,
'load3d-dropped-cube-obj.png',
{ maxDiffPixelRatio: 0.1 }
)
}
)
test(
'Uploading a background image populates Scene Config and surfaces panorama/remove controls',
{ tag: ['@screenshot'] },
async ({ comfyPage, load3d }) => {
await expect(load3d.uploadBackgroundImageButton).toBeVisible()
const node = await comfyPage.nodeOps.getNodeRefById(1)
const readBackgroundImage = async () => {
const properties =
await node.getProperty<Record<string, { backgroundImage?: string }>>(
'properties'
)
return properties['Scene Config']?.backgroundImage ?? ''
}
expect(
await readBackgroundImage(),
'Scene Config.backgroundImage should start empty'
).toBe('')
await test.step('Upload an image via file picker', async () => {
const uploadResponse = comfyPage.page.waitForResponse(
(resp) => resp.url().includes('/upload/') && resp.status() === 200
)
const fileChooser = comfyPage.page.waitForEvent('filechooser')
await load3d.uploadBackgroundImageButton.click()
await (await fileChooser).setFiles(assetPath('image64x64.webp'))
await uploadResponse
})
await expect.poll(readBackgroundImage).not.toBe('')
await expect(load3d.panoramaModeButton).toBeVisible()
await expect(load3d.removeBackgroundImageButton).toBeVisible()
await comfyPage.expectScreenshot(
load3d.node,
'load3d-background-image-tiled.png',
{ maxDiffPixelRatio: 0.05 }
)
await test.step('Toggling panorama mode updates Scene Config.backgroundRenderMode', async () => {
await load3d.panoramaModeButton.click()
await expect
.poll(async () => {
const properties =
await node.getProperty<
Record<string, { backgroundRenderMode?: string }>
>('properties')
return properties['Scene Config']?.backgroundRenderMode
})
.toBe('panorama')
await comfyPage.expectScreenshot(
load3d.node,
'load3d-background-image-panorama.png',
{ maxDiffPixelRatio: 0.05 }
)
})
await test.step('Remove background image clears the Scene Config', async () => {
await load3d.removeBackgroundImageButton.click()
await expect.poll(readBackgroundImage).toBe('')
await expect(load3d.removeBackgroundImageButton).toHaveCount(0)
await expect(load3d.panoramaModeButton).toHaveCount(0)
})
}
)
test(
'Grid toggle hides and restores the Scene grid helper',
{ tag: ['@screenshot'] },
async ({ comfyPage, load3d }) => {
await expect(load3d.gridToggleButton).toBeVisible()
const node = await comfyPage.nodeOps.getNodeRefById(1)
const readShowGrid = async () => {
const properties =
await node.getProperty<Record<string, { showGrid?: boolean }>>(
'properties'
)
return properties['Scene Config']?.showGrid
}
expect(
await readShowGrid(),
'Load3D workflow should start with grid visible (true or undefined)'
).not.toBe(false)
await comfyPage.expectScreenshot(load3d.node, 'load3d-grid-visible.png', {
maxDiffPixelRatio: 0.05
})
await load3d.gridToggleButton.click()
await expect.poll(readShowGrid).toBe(false)
await comfyPage.expectScreenshot(load3d.node, 'load3d-grid-hidden.png', {
maxDiffPixelRatio: 0.05
})
await load3d.gridToggleButton.click()
await expect.poll(readShowGrid).toBe(true)
await comfyPage.expectScreenshot(load3d.node, 'load3d-grid-visible.png', {
maxDiffPixelRatio: 0.05
})
}
)
test('Recording controls show stop/export/clear buttons after a recording', async ({
comfyPage,
load3d
}) => {
await expect(load3d.recordingButton).toBeVisible()
await expect(load3d.stopRecordingButton).toHaveCount(0)
await test.step('Start recording flips button to stop-recording', async () => {
await load3d.recordingButton.click()
await expect(load3d.stopRecordingButton).toBeVisible()
})
await test.step('Stop recording surfaces export/clear controls and a 1s duration', async () => {
// Record for 1s wall-clock so the duration display settles on 00:01.
await comfyPage.delay(1000)
await load3d.stopRecordingButton.click()
await expect(load3d.recordingButton).toBeVisible()
await expect(load3d.exportRecordingButton).toBeVisible()
await expect(load3d.clearRecordingButton).toBeVisible()
await expect(load3d.recordingDuration).toHaveText('00:01')
})
await test.step('Clear recording removes export and clear controls', async () => {
await load3d.clearRecordingButton.click()
await expect(load3d.exportRecordingButton).toHaveCount(0)
await expect(load3d.clearRecordingButton).toHaveCount(0)
})
})
})
test.describe('Load3D initialization failure', () => {
test('Surfaces a toast when the THREE.WebGLRenderer cannot be created', async ({
comfyPage
}) => {
// Force `new THREE.WebGLRenderer(...)` inside Load3d to throw by making
// WebGL getContext() calls return null.
await comfyPage.page.evaluate(() => {
const proto = HTMLCanvasElement.prototype as {
getContext: (
this: HTMLCanvasElement,
type: string,
options?: unknown
) => unknown
}
const original = proto.getContext
proto.getContext = function (type, options) {
if (type === 'webgl' || type === 'webgl2') return null
return original.call(this, type, options)
}
})
await comfyPage.workflow.loadWorkflow('3d/load3d_node')
await expect(
comfyPage.toast.visibleToasts.filter({
hasText: 'Failed to initialize 3D Viewer'
})
).not.toHaveCount(0)
})
})