mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-19 20:09:42 +00:00
## Summary Adds two Playwright specs extending \`browser_tests/tests/vueNodes/widgets/\` to cover float and combo value types, following the existing \`integerWidget.spec.ts\` / \`multilineStringWidget.spec.ts\` pattern. Part of a widget-test-coverage sequence. ## Changes - **What**: - \`browser_tests/tests/vueNodes/widgets/float/floatWidget.spec.ts\` (3) — number-input value change, increment/decrement on \`denoise\`, and persistence through litegraph widget state after user edit. - \`browser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.ts\` (3) — dropdown lists known sampler options, combo value updates on select, \`scheduler\` value persists. Reuses the existing \`vueNodes/linked-int-widget.json\` fixture (KSampler exposes \`cfg\` / \`denoise\` floats and \`sampler_name\` / \`scheduler\` combos). No new fixture files. ## Review Focus - Specs tagged \`@vue-nodes\`, consistent with the sibling suites. - Persistence assertions read widget state via \`window.graph._nodes_by_id[...].widgets\` (typed through \`TestGraphAccess\` from \`@e2e/types/globals\`) rather than JSON-serializing the whole graph — avoids \`unknown\` typing on \`window.graph.serialize()\`. - Boolean and color e2e specs are intentionally NOT in this PR — they'd need new workflow fixtures, which I'd prefer to design with you before writing. - \`pnpm typecheck:browser\` is clean locally; CI run needed to validate the Playwright behaviour since I couldn't run the full e2e suite locally. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11447-test-add-e2e-specs-for-float-and-combo-Vue-widgets-3486d73d365081f79302edc87595130c) by [Unito](https://www.unito.io)