mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-14 17:37:46 +00:00
## Summary Add sidebar badge behavior for queue/asset visibility updates: - Job History tab icon shows active jobs count (`queued + running`) only when the Job History panel is closed. - Assets tab icon no longer mirrors active jobs; when QPO V2 is enabled it now shows the number of assets added since the last time Assets was opened. - Opening Assets clears the unseen added-assets badge count. ## Changes - Added `iconBadge` logic to Job History sidebar tab. - Replaced Assets sidebar badge source with new unseen-assets counter logic. - Added `assetsSidebarBadgeStore` to track unseen asset additions from history updates and reset on Assets open. - Added/updated unit tests for both sidebar tab composables and the new store behavior. https://github.com/user-attachments/assets/33588a2a-c607-4fcc-8221-e7f11c3d79cc ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9050-fix-add-job-history-and-assets-sidebar-badge-behavior-30e6d73d365081c38297fe6aac9cd34c) by [Unito](https://www.unito.io) --------- Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
29 lines
922 B
TypeScript
29 lines
922 B
TypeScript
import { markRaw } from 'vue'
|
|
|
|
import JobHistorySidebarTab from '@/components/sidebar/tabs/JobHistorySidebarTab.vue'
|
|
import { useQueueStore } from '@/stores/queueStore'
|
|
import { useSidebarTabStore } from '@/stores/workspace/sidebarTabStore'
|
|
import type { SidebarTabExtension } from '@/types/extensionTypes'
|
|
|
|
export const useJobHistorySidebarTab = (): SidebarTabExtension => {
|
|
return {
|
|
id: 'job-history',
|
|
icon: 'icon-[lucide--history]',
|
|
title: 'queue.jobHistory',
|
|
tooltip: 'queue.jobHistory',
|
|
label: 'queue.jobHistory',
|
|
component: markRaw(JobHistorySidebarTab),
|
|
type: 'vue',
|
|
iconBadge: () => {
|
|
const sidebarTabStore = useSidebarTabStore()
|
|
if (sidebarTabStore.activeSidebarTabId === 'job-history') {
|
|
return null
|
|
}
|
|
|
|
const queueStore = useQueueStore()
|
|
const count = queueStore.activeJobsCount
|
|
return count > 0 ? count.toString() : null
|
|
}
|
|
}
|
|
}
|