mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-14 09:27:41 +00:00
## Summary Address several trivial CodeRabbit-filed issues: type guard extraction, ESLint globals, curve editor optimizations, and type relocation. ## Changes - **What**: Extract `isSingleImage()` type guard in WidgetImageCompare; add `__DISTRIBUTION__`/`__IS_NIGHTLY__` to ESLint globals and remove stale disable comments; remove unnecessary `toFixed(4)` from curve path generation; optimize `histogramToPath` with array join; move `CurvePoint` type to curve domain - Fixes #9175 - Fixes #8281 - Fixes #9116 - Fixes #9145 - Fixes #9147 ## Review Focus All changes are mechanical/trivial. Curve path output changes from fixed-precision to raw floats — SVG handles both fine. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9196-fix-address-trivial-CodeRabbit-issues-3126d73d365081f19a5ce20305403098) by [Unito](https://www.unito.io)
142 lines
3.7 KiB
TypeScript
142 lines
3.7 KiB
TypeScript
import { computed, onBeforeUnmount, ref } from 'vue'
|
|
import type { Ref } from 'vue'
|
|
|
|
import { createMonotoneInterpolator } from '@/components/curve/curveUtils'
|
|
import type { CurvePoint } from '@/components/curve/types'
|
|
|
|
interface UseCurveEditorOptions {
|
|
svgRef: Ref<SVGSVGElement | null>
|
|
modelValue: Ref<CurvePoint[]>
|
|
}
|
|
|
|
export function useCurveEditor({ svgRef, modelValue }: UseCurveEditorOptions) {
|
|
const dragIndex = ref(-1)
|
|
let cleanupDrag: (() => void) | null = null
|
|
|
|
const curvePath = computed(() => {
|
|
const points = modelValue.value
|
|
if (points.length < 2) return ''
|
|
|
|
const interpolate = createMonotoneInterpolator(points)
|
|
const xMin = points[0][0]
|
|
const xMax = points[points.length - 1][0]
|
|
const segments = 128
|
|
const range = xMax - xMin
|
|
const parts: string[] = []
|
|
for (let i = 0; i <= segments; i++) {
|
|
const x = xMin + range * (i / segments)
|
|
const y = 1 - interpolate(x)
|
|
parts.push(`${i === 0 ? 'M' : 'L'}${x},${y}`)
|
|
}
|
|
return parts.join('')
|
|
})
|
|
|
|
function svgCoords(e: PointerEvent): [number, number] {
|
|
const svg = svgRef.value
|
|
if (!svg) return [0, 0]
|
|
|
|
const ctm = svg.getScreenCTM()
|
|
if (!ctm) return [0, 0]
|
|
|
|
const svgPt = new DOMPoint(e.clientX, e.clientY).matrixTransform(
|
|
ctm.inverse()
|
|
)
|
|
return [
|
|
Math.max(0, Math.min(1, svgPt.x)),
|
|
Math.max(0, Math.min(1, 1 - svgPt.y))
|
|
]
|
|
}
|
|
|
|
function findNearestPoint(x: number, y: number): number {
|
|
const threshold2 = 0.04 * 0.04
|
|
let nearest = -1
|
|
let minDist2 = threshold2
|
|
for (let i = 0; i < modelValue.value.length; i++) {
|
|
const dx = modelValue.value[i][0] - x
|
|
const dy = modelValue.value[i][1] - y
|
|
const dist2 = dx * dx + dy * dy
|
|
if (dist2 < minDist2) {
|
|
minDist2 = dist2
|
|
nearest = i
|
|
}
|
|
}
|
|
return nearest
|
|
}
|
|
|
|
function handleSvgPointerDown(e: PointerEvent) {
|
|
if (e.button !== 0) return
|
|
|
|
const [x, y] = svgCoords(e)
|
|
|
|
const nearby = findNearestPoint(x, y)
|
|
if (nearby >= 0) {
|
|
startDrag(nearby, e)
|
|
return
|
|
}
|
|
|
|
if (e.ctrlKey) return
|
|
|
|
const newPoint: CurvePoint = [x, y]
|
|
const newPoints: CurvePoint[] = [...modelValue.value, newPoint]
|
|
newPoints.sort((a, b) => a[0] - b[0])
|
|
modelValue.value = newPoints
|
|
|
|
startDrag(newPoints.indexOf(newPoint), e)
|
|
}
|
|
|
|
function startDrag(index: number, e: PointerEvent) {
|
|
cleanupDrag?.()
|
|
|
|
if (e.button === 2 || (e.button === 0 && e.ctrlKey)) {
|
|
if (modelValue.value.length > 2) {
|
|
const newPoints = [...modelValue.value]
|
|
newPoints.splice(index, 1)
|
|
modelValue.value = newPoints
|
|
}
|
|
return
|
|
}
|
|
|
|
dragIndex.value = index
|
|
const svg = svgRef.value
|
|
if (!svg) return
|
|
|
|
svg.setPointerCapture(e.pointerId)
|
|
|
|
const onMove = (ev: PointerEvent) => {
|
|
if (dragIndex.value < 0) return
|
|
const [x, y] = svgCoords(ev)
|
|
const movedPoint: CurvePoint = [x, y]
|
|
const newPoints = [...modelValue.value]
|
|
newPoints[dragIndex.value] = movedPoint
|
|
newPoints.sort((a, b) => a[0] - b[0])
|
|
modelValue.value = newPoints
|
|
dragIndex.value = newPoints.indexOf(movedPoint)
|
|
}
|
|
|
|
const endDrag = () => {
|
|
if (dragIndex.value < 0) return
|
|
dragIndex.value = -1
|
|
svg.removeEventListener('pointermove', onMove)
|
|
svg.removeEventListener('pointerup', endDrag)
|
|
svg.removeEventListener('lostpointercapture', endDrag)
|
|
cleanupDrag = null
|
|
}
|
|
|
|
cleanupDrag = endDrag
|
|
|
|
svg.addEventListener('pointermove', onMove)
|
|
svg.addEventListener('pointerup', endDrag)
|
|
svg.addEventListener('lostpointercapture', endDrag)
|
|
}
|
|
|
|
onBeforeUnmount(() => {
|
|
cleanupDrag?.()
|
|
})
|
|
|
|
return {
|
|
curvePath,
|
|
handleSvgPointerDown,
|
|
startDrag
|
|
}
|
|
}
|