mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
## Summary - Remove the legacy missing nodes modal dialog and migrate all functionality to the existing Error Overlay / TabErrors system - Migrate core node version warning from `MissingCoreNodesMessage.vue` to `MissingNodeCard` in the errors tab - Remove `Comfy.Workflow.ShowMissingNodesWarning` setting (errors tab always surfaces missing nodes) - Delete 6 legacy files: `useMissingNodesDialog.ts`, `MissingNodesContent.vue`, `MissingNodesFooter.vue`, `MissingNodesHeader.vue`, `MissingCoreNodesMessage.vue` and its test - Rename `showMissingNodesDialog`/`showMissingModelsDialog` params to `showMissingNodes`/`showMissingModels` - Add `errorOverlay` and `missingNodeCard` to centralized `TestIds` - Migrate all E2E tests from legacy dialog selectors to error overlay testIds - Add new E2E test: MissingNodeCard visible via "See Errors" button flow - Add new E2E test: subgraph missing node type verified by expanding pack row - Add `surfaceMissingNodes` unit tests to `executionErrorStore` - Guard `semver.compare` against invalid version strings - Add `role="alert"`, `aria-hidden` for accessibility - Use reactive props destructuring in `MissingNodeCard` and `MissingPackGroupRow` **Net change: -669 lines** (19 files, +323 / -992) <img width="733" height="579" alt="image" src="https://github.com/user-attachments/assets/c497809d-b176-43bf-9872-34bd74c6ea0d" /> ## Test plan - [x] Unit tests: MissingNodeCard core node warning (7 tests) - [x] Unit tests: surfaceMissingNodes (4 tests) - [x] Unit tests: workflowService showPendingWarnings (updated) - [x] E2E: Error overlay visible on missing nodes workflow - [x] E2E: Error overlay visible on subgraph missing nodes - [x] E2E: MissingNodeCard visible via See Errors button - [x] E2E: Subgraph node type visible after expanding pack row - [x] E2E: Error overlay does not resurface on undo/redo - [x] E2E: Error overlay does not reappear on workflow tab switch - [x] Typecheck, lint, knip all passing ## Related issues - Closes #9923 (partially — `errorOverlay` and `missingNodeCard` added to TestIds) - References #10027 (mock hoisting inconsistency) - References #10033 (i18n-based test selectors) - References #10085 (DDD layer violation + focusedErrorNodeId) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10102-refactor-remove-legacy-missing-nodes-dialog-3256d73d365081c194d2e90bc6401846) by [Unito](https://www.unito.io)
91 lines
3.6 KiB
TypeScript
91 lines
3.6 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import { TestIds } from '../fixtures/selectors'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
// If an input is optional by node definition, it should be shown as
|
|
// a hollow circle no matter what shape it was defined in the workflow JSON.
|
|
test.describe('Optional input', { tag: ['@screenshot', '@node'] }, () => {
|
|
test('No shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_no_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Wrong shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_wrong_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Correct shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_correct_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Force input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/force_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('force_input.png')
|
|
})
|
|
|
|
test('Default input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/default_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('default_input.png')
|
|
})
|
|
|
|
test('Only optional inputs', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/only_optional_inputs')
|
|
expect(await comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
).not.toBeVisible()
|
|
|
|
// If the node's multiline text widget is visible, then it was loaded successfully
|
|
await expect(comfyPage.page.locator('.comfy-multiline-input')).toHaveCount(
|
|
1
|
|
)
|
|
})
|
|
test('Old workflow with converted input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/old_workflow_converted_input')
|
|
const node = await comfyPage.nodeOps.getNodeRefById('1')
|
|
const inputs = (await node.getProperty('inputs')) as {
|
|
name: string
|
|
link?: number | null
|
|
}[]
|
|
const vaeInput = inputs.find((w) => w.name === 'vae')
|
|
const convertedInput = inputs.find((w) => w.name === 'strength')
|
|
|
|
expect(vaeInput).toBeDefined()
|
|
expect(convertedInput).toBeDefined()
|
|
expect(vaeInput!.link).toBeNull()
|
|
expect(convertedInput!.link).not.toBeNull()
|
|
})
|
|
test('Renamed converted input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/renamed_converted_widget')
|
|
const node = await comfyPage.nodeOps.getNodeRefById('3')
|
|
const inputs = (await node.getProperty('inputs')) as { name: string }[]
|
|
const renamedInput = inputs.find((w) => w.name === 'breadth')
|
|
expect(renamedInput).toBeUndefined()
|
|
})
|
|
test('slider', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/simple_slider')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('simple_slider.png')
|
|
})
|
|
test('unknown converted widget', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'missing/missing_nodes_converted_widget'
|
|
)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'missing_nodes_converted_widget.png'
|
|
)
|
|
})
|
|
test('dynamically added input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/dynamically_added_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'dynamically_added_input.png'
|
|
)
|
|
})
|
|
})
|