mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-11 09:42:22 +00:00
- positive prompt-id attribution: capture the /prompt response id as the primary event filter (seen-set + graph membership stay as depth); a new attribution self-check injects a foreign-prompt terminal error mid-run and proves it cannot fail the run - console collection now includes pageerror (uncaught exceptions and rejections), with a collector self-check as positive control; surfaces a real Custom-Scripts betterCombos typeof-null bug, ledgered with mechanism - connectivity allowlists are two-way stale-guarded: every entry must be observed failing in its recorded way, all stale keys reported per run - manifest pins are required full 40-hex SHAs (CUSTOM_NODES_ALLOW_UNPINNED=1 admits only empty pins, reserved for the planned pack-HEAD canary); pack must be a plain path segment; contract pinned by pure specs - CI installs each pack under custom_nodes/<pack> with charset and pin gates before cloning (attribution keys on the install dirname) - allNodes renderer loops honor rendererPassesFor (vueNodesCompatible) - curated T1 asserts every display sink emitted a ui payload; console sinks documented as excluded (no ui payload by design) - the always()-wrapper suggestion was rejected on sibling evidence: ci-tests-unit.yaml gates its required check with a changes job and job-level if, and no repo workflow uses a wrapper Reviewed via ninja pipeline: 4-hat CORE panel (2 passes), senior QA gate (2 rounds, discrimination proven by falsification), gated review (Primary, Double Checker, Ultimate Skeptic - 15-entry evidence ledger, all PROVEN). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>