mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 07:00:23 +00:00
5233749fe3
## Summary - Allow default browser copy (Ctrl+C / Cmd+C) when text is selected anywhere in the document - Previously, the graph node copy handler intercepted copy events even in dialogs ## Problem Users could not copy error messages from the PromptExecutionError dialog or other modal dialogs. When pressing Ctrl+C with text selected in a dialog, the graph copy handler would intercept the event and prevent the default browser copy behavior. ## Solution Add a `hasTextSelection()` check to `shouldIgnoreCopyPaste()`. When the user has any text selected in the document, the function returns `true`, allowing the default browser copy to proceed. ## Test plan - [ ] Open an error dialog (trigger a workflow error) - [ ] Click "Show Report" to expand error details - [ ] Select some text in the dialog - [ ] Press Ctrl+C (or Cmd+C on Mac) - [ ] Paste elsewhere to verify the text was copied - [ ] Verify graph node copy still works when no text is selected https://github.com/user-attachments/assets/30a0c501-95ee-4148-b321-3d60339a41c5 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7166-Fix-copy-not-working-when-text-is-selected-in-dialogs-2bf6d73d36508182a240fd3153cb6969) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
40 lines
1.1 KiB
TypeScript
40 lines
1.1 KiB
TypeScript
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
|
|
/**
|
|
* Utility functions for handling workbench events
|
|
*/
|
|
|
|
/**
|
|
* Check if there is selected text in the document.
|
|
*/
|
|
function hasTextSelection(): boolean {
|
|
const selection = window.getSelection()
|
|
return selection !== null && selection.toString().trim().length > 0
|
|
}
|
|
|
|
/**
|
|
* Used by clipboard handlers to determine if copy/paste events should be
|
|
* intercepted for graph operations vs. allowing default browser behavior
|
|
* for text inputs and other UI elements.
|
|
*
|
|
* @param target - The event target to check
|
|
* @returns true if copy paste events will be handled by target
|
|
*/
|
|
export function shouldIgnoreCopyPaste(target: EventTarget | null): boolean {
|
|
const isTextInput =
|
|
target instanceof HTMLTextAreaElement ||
|
|
(target instanceof HTMLInputElement &&
|
|
![
|
|
'button',
|
|
'checkbox',
|
|
'file',
|
|
'hidden',
|
|
'image',
|
|
'radio',
|
|
'range',
|
|
'reset',
|
|
'search',
|
|
'submit'
|
|
].includes(target.type))
|
|
return isTextInput || useCanvasStore().linearMode || hasTextSelection()
|
|
}
|