mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-20 23:04:06 +00:00
7c4486ed29
## Description When loading a template workflow, always call `fitView()` to ensure the template is properly framed within the viewport. This provides a better initial viewing experience for users. ## Problem Previously, templates with embedded viewport positions (`extra.ds`) would load at arbitrary positions, sometimes showing a blank canvas. Users had to navigate significantly to find the workflow content. ## Solution Added a single condition in `loadGraphData()` to check if `openSource === 'template'` and force `fitView()` when true, bypassing the saved viewport position. This change only affects template loading - normal workflow loading behavior remains unchanged. ## Changes - `src/scripts/app.ts`: Added condition to always call `fitView()` when loading templates ## Testing - Load various templates from the template selector - Verify the workflow is fully visible and centered on load - Verify normal workflow loading still respects saved positions ## Related - Fixes COM-14156 - Related to COM-10087 (Center view on workflow when loading templates - Done) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8749-feat-automatically-fit-view-when-loading-templates-3016d73d36508167a63de2ae407de7b8) by [Unito](https://www.unito.io)
57 lines
1.9 KiB
TypeScript
57 lines
1.9 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
/**
|
|
* Tests that templates are automatically fitted to view when loaded.
|
|
*
|
|
* When openSource === 'template', fitView() is called to ensure
|
|
* templates with saved off-screen viewport positions (extra.ds)
|
|
* are always displayed correctly.
|
|
*/
|
|
test.describe('Template Fit View', { tag: ['@canvas', '@workflow'] }, () => {
|
|
test('should automatically fit view when loading a template with off-screen saved position', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.EnableWorkflowViewRestore', true)
|
|
|
|
// Serialize the current default graph, inject an extreme off-screen
|
|
// viewport position, then reload it as a template. Without the fix,
|
|
// the saved offset [-5000, -5000] would be restored and nodes would
|
|
// be invisible.
|
|
const viewportState = await comfyPage.page.evaluate(async () => {
|
|
const app = window.app!
|
|
const workflow = app.graph.serialize()
|
|
|
|
workflow.extra = {
|
|
...workflow.extra,
|
|
ds: { scale: 1, offset: [-5000, -5000] }
|
|
}
|
|
|
|
await app.loadGraphData(workflow as ComfyWorkflowJSON, true, true, null, {
|
|
openSource: 'template'
|
|
})
|
|
|
|
return {
|
|
offsetX: app.canvas.ds.offset[0],
|
|
offsetY: app.canvas.ds.offset[1],
|
|
nodeCount: app.graph._nodes.length
|
|
}
|
|
})
|
|
|
|
expect(viewportState.nodeCount).toBeGreaterThan(0)
|
|
|
|
// fitView() should have overridden the saved [-5000, -5000] offset
|
|
expect(
|
|
viewportState.offsetX,
|
|
'Viewport X offset should not be the saved off-screen value'
|
|
).not.toBe(-5000)
|
|
expect(
|
|
viewportState.offsetY,
|
|
'Viewport Y offset should not be the saved off-screen value'
|
|
).not.toBe(-5000)
|
|
})
|
|
})
|