mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Expands the performance testing infrastructure to collect 4 additional CDP metrics that are already returned by `Performance.getMetrics` but were not being read. This is a zero-cost expansion — no additional CDP calls, just reading more fields from the existing response. ## New Metrics | Metric | CDP Source | What It Detects | |---|---|---| | `domNodes` | `Nodes` | DOM node count delta — widget DOM leaks during node create/destroy | | `jsHeapTotalBytes` | `JSHeapTotalSize` | Total heap delta — combined with `heapDeltaBytes` shows GC pressure | | `scriptDurationMs` | `ScriptDuration` | JS execution time vs total task time — script vs rendering balance | | `eventListeners` | `JSEventListeners` | Listener count delta — detects listener accumulation across lifecycle | ## Changes ### `browser_tests/fixtures/helpers/PerformanceHelper.ts` - Added 4 fields to `PerfSnapshot` interface - Added 4 fields to `PerfMeasurement` interface - Wired through `getSnapshot()` and `stopMeasuring()` ### `scripts/perf-report.ts` - Added 4 fields to `PerfMeasurement` interface - Expanded `MetricKey` type and `REPORTED_METRICS` array with 3 new reported metrics (`domNodes`, `scriptDurationMs`, `eventListeners`) - `jsHeapTotalBytes` is collected but not in `REPORTED_METRICS` — it's used alongside `heapDeltaBytes` for GC pressure ratio analysis ## Why These 4 From a gap analysis of all ~30 CDP metrics, these were identified as highest priority for ComfyUI: - **`Nodes`** (P0): ComfyUI dynamically creates/destroys widget DOM. DOM bloat from leaked widgets is a key performance risk, especially for Vue Nodes 2.0. - **`ScriptDuration`** (P1): Separates JS execution from layout/paint. Reveals whether perf issues are script-heavy or rendering-heavy. - **`JSEventListeners`** (P1): Widget lifecycle can leak listeners across node add/remove cycles. - **`JSHeapTotalSize`** (P1): With `JSHeapUsedSize`, the ratio shows GC fragmentation pressure. ## Backward Compatibility The `PerfMeasurement` interface is extended (not changed). Old baseline `perf-metrics.json` files without these fields will have `undefined` values, which the report script handles gracefully (shows `—` for missing data). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9887-feat-expand-CDP-perf-metrics-add-DOM-nodes-script-duration-event-listeners-3226d73d3650818abea1d4a441667c38) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
113 lines
3.2 KiB
TypeScript
113 lines
3.2 KiB
TypeScript
import type { CDPSession, Page } from '@playwright/test'
|
|
|
|
interface PerfSnapshot {
|
|
RecalcStyleCount: number
|
|
RecalcStyleDuration: number
|
|
LayoutCount: number
|
|
LayoutDuration: number
|
|
TaskDuration: number
|
|
JSHeapUsedSize: number
|
|
Timestamp: number
|
|
Nodes: number
|
|
JSHeapTotalSize: number
|
|
ScriptDuration: number
|
|
JSEventListeners: number
|
|
}
|
|
|
|
export interface PerfMeasurement {
|
|
name: string
|
|
durationMs: number
|
|
styleRecalcs: number
|
|
styleRecalcDurationMs: number
|
|
layouts: number
|
|
layoutDurationMs: number
|
|
taskDurationMs: number
|
|
heapDeltaBytes: number
|
|
domNodes: number
|
|
jsHeapTotalBytes: number
|
|
scriptDurationMs: number
|
|
eventListeners: number
|
|
}
|
|
|
|
export class PerformanceHelper {
|
|
private cdp: CDPSession | null = null
|
|
private snapshot: PerfSnapshot | null = null
|
|
|
|
constructor(private readonly page: Page) {}
|
|
|
|
async init(): Promise<void> {
|
|
this.cdp = await this.page.context().newCDPSession(this.page)
|
|
await this.cdp.send('Performance.enable')
|
|
}
|
|
|
|
async dispose(): Promise<void> {
|
|
this.snapshot = null
|
|
if (this.cdp) {
|
|
try {
|
|
await this.cdp.send('Performance.disable')
|
|
} finally {
|
|
await this.cdp.detach()
|
|
this.cdp = null
|
|
}
|
|
}
|
|
}
|
|
|
|
private async getSnapshot(): Promise<PerfSnapshot> {
|
|
if (!this.cdp) throw new Error('PerformanceHelper not initialized')
|
|
const { metrics } = (await this.cdp.send('Performance.getMetrics')) as {
|
|
metrics: { name: string; value: number }[]
|
|
}
|
|
function get(name: string): number {
|
|
return metrics.find((m) => m.name === name)?.value ?? 0
|
|
}
|
|
return {
|
|
RecalcStyleCount: get('RecalcStyleCount'),
|
|
RecalcStyleDuration: get('RecalcStyleDuration'),
|
|
LayoutCount: get('LayoutCount'),
|
|
LayoutDuration: get('LayoutDuration'),
|
|
TaskDuration: get('TaskDuration'),
|
|
JSHeapUsedSize: get('JSHeapUsedSize'),
|
|
Timestamp: get('Timestamp'),
|
|
Nodes: get('Nodes'),
|
|
JSHeapTotalSize: get('JSHeapTotalSize'),
|
|
ScriptDuration: get('ScriptDuration'),
|
|
JSEventListeners: get('JSEventListeners')
|
|
}
|
|
}
|
|
|
|
async startMeasuring(): Promise<void> {
|
|
if (this.snapshot) {
|
|
throw new Error(
|
|
'Measurement already in progress — call stopMeasuring() first'
|
|
)
|
|
}
|
|
this.snapshot = await this.getSnapshot()
|
|
}
|
|
|
|
async stopMeasuring(name: string): Promise<PerfMeasurement> {
|
|
if (!this.snapshot) throw new Error('Call startMeasuring() first')
|
|
const after = await this.getSnapshot()
|
|
const before = this.snapshot
|
|
this.snapshot = null
|
|
|
|
function delta(key: keyof PerfSnapshot): number {
|
|
return after[key] - before[key]
|
|
}
|
|
|
|
return {
|
|
name,
|
|
durationMs: delta('Timestamp') * 1000,
|
|
styleRecalcs: delta('RecalcStyleCount'),
|
|
styleRecalcDurationMs: delta('RecalcStyleDuration') * 1000,
|
|
layouts: delta('LayoutCount'),
|
|
layoutDurationMs: delta('LayoutDuration') * 1000,
|
|
taskDurationMs: delta('TaskDuration') * 1000,
|
|
heapDeltaBytes: delta('JSHeapUsedSize'),
|
|
domNodes: delta('Nodes'),
|
|
jsHeapTotalBytes: delta('JSHeapTotalSize'),
|
|
scriptDurationMs: delta('ScriptDuration') * 1000,
|
|
eventListeners: delta('JSEventListeners')
|
|
}
|
|
}
|
|
}
|