mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
120 lines
4.0 KiB
TypeScript
120 lines
4.0 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.describe('Right Side Panel Tabs', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('Properties panel opens with workflow overview', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
await expect(propertiesPanel.root).toBeVisible()
|
|
await expect(propertiesPanel.panelTitle).toContainText('Workflow Overview')
|
|
})
|
|
|
|
test('Properties panel shows node details on selection', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
await comfyPage.nodeOps.selectNodes(['KSampler'])
|
|
|
|
await expect(propertiesPanel.panelTitle).toContainText('KSampler')
|
|
})
|
|
|
|
test('Node title input is editable', async ({ comfyPage }) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
await comfyPage.nodeOps.selectNodes(['KSampler'])
|
|
await expect(propertiesPanel.panelTitle).toContainText('KSampler')
|
|
|
|
// Click on the title to enter edit mode
|
|
await propertiesPanel.panelTitle.click()
|
|
const titleInput = propertiesPanel.root.getByTestId(TestIds.node.titleInput)
|
|
await expect(titleInput).toBeVisible()
|
|
|
|
await titleInput.fill('My Custom Sampler')
|
|
await titleInput.press('Enter')
|
|
|
|
await expect(propertiesPanel.panelTitle).toContainText('My Custom Sampler')
|
|
})
|
|
|
|
test('Search box filters properties', async ({ comfyPage }) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
await comfyPage.nodeOps.selectNodes([
|
|
'KSampler',
|
|
'CLIP Text Encode (Prompt)'
|
|
])
|
|
|
|
await expect(propertiesPanel.panelTitle).toContainText('3 items selected')
|
|
await expect(propertiesPanel.root.getByText('KSampler')).toHaveCount(1)
|
|
await expect(
|
|
propertiesPanel.root.getByText('CLIP Text Encode (Prompt)')
|
|
).toHaveCount(2)
|
|
|
|
await propertiesPanel.searchBox.fill('seed')
|
|
await expect(propertiesPanel.root.getByText('KSampler')).toHaveCount(1)
|
|
await expect(
|
|
propertiesPanel.root.getByText('CLIP Text Encode (Prompt)')
|
|
).toHaveCount(0)
|
|
|
|
await propertiesPanel.searchBox.fill('')
|
|
await expect(propertiesPanel.root.getByText('KSampler')).toHaveCount(1)
|
|
await expect(
|
|
propertiesPanel.root.getByText('CLIP Text Encode (Prompt)')
|
|
).toHaveCount(2)
|
|
})
|
|
|
|
test('Expand all / Collapse all toggles sections', async ({ comfyPage }) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
// Select multiple nodes so collapse toggle button appears
|
|
await comfyPage.nodeOps.selectNodes([
|
|
'KSampler',
|
|
'CLIP Text Encode (Prompt)'
|
|
])
|
|
|
|
// Sections default to collapsed when multiple nodes are selected,
|
|
// so the button initially shows "Expand all"
|
|
const expandButton = propertiesPanel.root.getByRole('button', {
|
|
name: 'Expand all'
|
|
})
|
|
await expect(expandButton).toBeVisible()
|
|
await expandButton.click()
|
|
|
|
const collapseButton = propertiesPanel.root.getByRole('button', {
|
|
name: 'Collapse all'
|
|
})
|
|
await expect(collapseButton).toBeVisible()
|
|
await collapseButton.click()
|
|
|
|
// After collapsing, the button label switches back to "Expand all"
|
|
await expect(expandButton).toBeVisible()
|
|
})
|
|
|
|
test('Properties panel can be closed', async ({ comfyPage }) => {
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
const { propertiesPanel } = comfyPage.menu
|
|
|
|
await expect(propertiesPanel.root).toBeVisible()
|
|
|
|
// The actionbar toggle button hides when the panel is open,
|
|
// so use the close button inside the panel itself
|
|
const closeButton = comfyPage.page.getByLabel('Toggle properties panel')
|
|
await closeButton.click()
|
|
await expect(propertiesPanel.root).toBeHidden()
|
|
})
|
|
})
|